performance(semantic): Removed Arc from function body. (#8438)

Author: orizi

crates/cairo-lang-lowering/src/lower/context.rs

@@ -1,5 +1,4 @@
 use std::ops::{Deref, DerefMut, Index};
-use std::sync::Arc;
 
 use cairo_lang_defs::ids::LanguageElementId;
 use cairo_lang_diagnostics::{DiagnosticAdded, Maybe};
@@ -87,7 +86,7 @@ pub struct EncapsulatingLoweringContext<'db> {
     /// Id for the current function being lowered.
     pub semantic_function_id: defs::ids::FunctionWithBodyId<'db>,
     /// Semantic model for current function body.
-    pub function_body: Arc<semantic::FunctionBody<'db>>,
+    pub function_body: &'db semantic::FunctionBody<'db>,
     /// Definitions encountered for semantic bindings. Since Constants are not lowered, this is
     /// only used for variables.
     // TODO(spapini): consider moving to semantic model.
@@ -105,7 +104,7 @@ impl<'db> EncapsulatingLoweringContext<'db> {
         semantic_function_id: defs::ids::FunctionWithBodyId<'db>,
     ) -> Maybe<Self> {
         let function_body = db.function_body(semantic_function_id)?;
-        let usages = Usages::from_function_body(&function_body);
+        let usages = Usages::from_function_body(function_body);
         Ok(Self {
             db,
             semantic_function_id,

crates/cairo-lang-semantic/src/items/free_function.rs

@@ -172,7 +172,7 @@ fn priv_free_function_body_data<'db>(
         expr_lookup,
         pattern_lookup,
         resolver_data,
-        body: Arc::new(FunctionBody { arenas, body_expr }),
+        body: FunctionBody { arenas, body_expr },
     })
 }
 
@@ -249,6 +249,10 @@ pub trait FreeFunctionSemantic<'db>: Database {
             .map(|data| data.diagnostics.clone())
             .unwrap_or_default()
     }
+    /// Returns the definition of a free function.
+    fn free_function_body(&'db self, id: FreeFunctionId<'db>) -> Maybe<&'db FunctionBody<'db>> {
+        Ok(&self.priv_free_function_body_data(id)?.body)
+    }
     /// Returns the resolution resolved_items of a free function's body.
     fn free_function_body_resolver_data(
         &'db self,

crates/cairo-lang-semantic/src/items/function_with_body.rs

@@ -56,7 +56,7 @@ pub struct FunctionBodyData<'db> {
     pub expr_lookup: UnorderedHashMap<ast::ExprPtr<'db>, ExprId>,
     pub pattern_lookup: UnorderedHashMap<ast::PatternPtr<'db>, PatternId>,
     pub resolver_data: Arc<ResolverData<'db>>,
-    pub body: Arc<FunctionBody<'db>>,
+    pub body: FunctionBody<'db>,
 }
 
 unsafe impl<'db> salsa::Update for FunctionBodyData<'db> {
@@ -68,7 +68,7 @@ unsafe impl<'db> salsa::Update for FunctionBodyData<'db> {
         let res = unsafe {
             Diagnostics::maybe_update(&mut old_value.diagnostics, new_value.diagnostics)
                 | Arc::maybe_update(&mut old_value.resolver_data, new_value.resolver_data)
-                | Arc::maybe_update(&mut old_value.body, new_value.body)
+                | FunctionBody::maybe_update(&mut old_value.body, new_value.body)
         };
         if res {
             old_value.expr_lookup = new_value.expr_lookup;
@@ -331,14 +331,12 @@ pub trait FunctionWithBodySemantic<'db>: Database {
     fn function_body(
         &'db self,
         function_id: FunctionWithBodyId<'db>,
-    ) -> Maybe<Arc<FunctionBody<'db>>> {
-        Ok(match function_id {
-            FunctionWithBodyId::Free(id) => self.priv_free_function_body_data(id)?.body.clone(),
-            FunctionWithBodyId::Impl(id) => self.priv_impl_function_body_data(id)?.body.clone(),
-            FunctionWithBodyId::Trait(id) => {
-                self.priv_trait_function_body_data(id)?.ok_or(DiagnosticAdded)?.body.clone()
-            }
-        })
+    ) -> Maybe<&'db FunctionBody<'db>> {
+        match function_id {
+            FunctionWithBodyId::Free(id) => self.free_function_body(id),
+            FunctionWithBodyId::Impl(id) => self.impl_function_body(id),
+            FunctionWithBodyId::Trait(id) => self.trait_function_body(id)?.ok_or(DiagnosticAdded),
+        }
     }
     /// Returns the body expr of a function (with a body).
     fn function_body_expr(

crates/cairo-lang-semantic/src/items/imp.rs

@@ -3648,7 +3648,7 @@ fn priv_impl_function_body_data<'db>(
         expr_lookup,
         pattern_lookup,
         resolver_data,
-        body: Arc::new(FunctionBody { arenas, body_expr }),
+        body: FunctionBody { arenas, body_expr },
     })
 }
 
@@ -4378,8 +4378,8 @@ pub trait ImplSemantic<'db>: Database {
     fn impl_function_body(
         &'db self,
         impl_function_id: ImplFunctionId<'db>,
-    ) -> Maybe<Arc<FunctionBody<'db>>> {
-        Ok(self.priv_impl_function_body_data(impl_function_id)?.body.clone())
+    ) -> Maybe<&'db FunctionBody<'db>> {
+        Ok(&self.priv_impl_function_body_data(impl_function_id)?.body)
     }
     /// Returns the resolution resolved_items of an impl function's definition.
     fn impl_function_body_resolver_data(

crates/cairo-lang-semantic/src/items/trt.rs

@@ -1168,7 +1168,7 @@ fn priv_trait_function_body_data<'db>(
         expr_lookup,
         pattern_lookup,
         resolver_data,
-        body: Arc::new(FunctionBody { arenas, body_expr }),
+        body: FunctionBody { arenas, body_expr },
     }))
 }
 
@@ -1442,8 +1442,8 @@ pub trait TraitSemantic<'db>: Database {
     fn trait_function_body(
         &'db self,
         trait_function_id: TraitFunctionId<'db>,
-    ) -> Maybe<Option<Arc<FunctionBody<'db>>>> {
-        Ok(self.priv_trait_function_body_data(trait_function_id)?.map(|data| data.body.clone()))
+    ) -> Maybe<Option<&'db FunctionBody<'db>>> {
+        Ok(self.priv_trait_function_body_data(trait_function_id)?.map(|data| &data.body))
     }
     /// Returns the resolution resolved_items of a trait function.
     fn trait_function_body_resolver_data(

crates/cairo-lang-semantic/src/usage/test.rs

@@ -40,7 +40,7 @@ fn test_function_usage(
     let expr_formatter = ExprFormatter { db, function_id: test_function.function_id };
     let function_def =
         db.function_body(test_function.concrete_function_id.function_with_body_id(db)).unwrap();
-    let usages = Usages::from_function_body(&function_def);
+    let usages = Usages::from_function_body(function_def);
 
     let mut usages_str = String::new();
     for (expr_id, usage) in usages.usages.iter() {