performance(semantic): No clone of ImplicitPrecedence. (#8437)

Author: orizi

crates/cairo-lang-semantic/src/items/free_function.rs

@@ -199,11 +199,10 @@ pub trait FreeFunctionSemantic<'db>: Database {
     fn free_function_declaration_implicit_precedence(
         &'db self,
         id: FreeFunctionId<'db>,
-    ) -> Maybe<ImplicitPrecedence<'db>> {
-        Ok(free_function_declaration_data(self.as_dyn_database(), id)
+    ) -> Maybe<&'db ImplicitPrecedence<'db>> {
+        Ok(&free_function_declaration_data(self.as_dyn_database(), id)
             .maybe_as_ref()?
-            .implicit_precedence
-            .clone())
+            .implicit_precedence)
     }
     /// Returns the generic params of a free function.
     fn free_function_generic_params(

crates/cairo-lang-semantic/src/items/function_with_body.rs

@@ -278,7 +278,7 @@ pub trait FunctionWithBodySemantic<'db>: Database {
     fn function_declaration_implicit_precedence(
         &'db self,
         function_id: FunctionWithBodyId<'db>,
-    ) -> Maybe<ImplicitPrecedence<'db>> {
+    ) -> Maybe<&'db ImplicitPrecedence<'db>> {
         match function_id {
             FunctionWithBodyId::Free(id) => self.free_function_declaration_implicit_precedence(id),
             FunctionWithBodyId::Impl(id) => self.impl_function_declaration_implicit_precedence(id),

crates/cairo-lang-semantic/src/items/imp.rs

@@ -4352,12 +4352,11 @@ pub trait ImplSemantic<'db>: Database {
     fn impl_function_declaration_implicit_precedence(
         &'db self,
         id: ImplFunctionId<'db>,
-    ) -> Maybe<ImplicitPrecedence<'db>> {
-        Ok(impl_function_declaration_data(self.as_dyn_database(), id)
+    ) -> Maybe<&'db ImplicitPrecedence<'db>> {
+        Ok(&impl_function_declaration_data(self.as_dyn_database(), id)
             .maybe_as_ref()?
             .function_declaration_data
-            .implicit_precedence
-            .clone())
+            .implicit_precedence)
     }
     /// Returns the trait function of an impl function.
     fn impl_function_trait_function(

crates/cairo-lang-semantic/src/items/trt.rs

@@ -1424,11 +1424,8 @@ pub trait TraitSemantic<'db>: Database {
     fn trait_function_declaration_implicit_precedence(
         &'db self,
         trait_function_id: TraitFunctionId<'db>,
-    ) -> Maybe<ImplicitPrecedence<'db>> {
-        Ok(self
-            .priv_trait_function_declaration_data(trait_function_id)?
-            .implicit_precedence
-            .clone())
+    ) -> Maybe<&'db ImplicitPrecedence<'db>> {
+        Ok(&self.priv_trait_function_declaration_data(trait_function_id)?.implicit_precedence)
     }
     /// Returns the semantic diagnostics of a trait function definition (declaration + body).
     fn trait_function_body_diagnostics(