From 0ecba37e620ff7c62b14dc9f29cc724c307aa7b7 Mon Sep 17 00:00:00 2001
From: Gilad Chase <gilad@starkware.com>
Date: Thu, 4 Sep 2025 06:36:07 +0300
Subject: [PATCH] refactor(test): remove `compare_spans` util

It was pre-PartialEq legacy code
---
 corelib/src/test/byte_array_test.cairo | 23 +++--------------------
 1 file changed, 3 insertions(+), 20 deletions(-)

diff --git a/corelib/src/test/byte_array_test.cairo b/corelib/src/test/byte_array_test.cairo
index 51699d614d5..2e37954f03a 100644
--- a/corelib/src/test/byte_array_test.cairo
+++ b/corelib/src/test/byte_array_test.cairo
@@ -442,12 +442,12 @@ fn test_serde() {
     let mut serialized = array![];
     let ba: ByteArray = "";
     ba.serialize(ref serialized);
-    compare_spans(serialized.span(), [0, 0, 0].span());
+    assert_eq!(serialized.span(), [0, 0, 0].span());
 
     let mut serialized = array![];
     let ba: ByteArray = "hello";
     ba.serialize(ref serialized);
-    compare_spans(
+    assert_eq!(
         serialized.span(),
         [0, // data len
         0x68656c6c6f, // pending_word
@@ -458,7 +458,7 @@ fn test_serde() {
     let mut serialized = array![];
     let ba: ByteArray = "Long string, more than 31 characters.";
     ba.serialize(ref serialized);
-    compare_spans(
+    assert_eq!(
         serialized.span(),
         [
             1, // data len
@@ -495,23 +495,6 @@ fn test_from_collect() {
 
 // ========= Test helper functions =========
 
-fn compare_spans<T, +crate::fmt::Debug<T>, +PartialEq<T>, +Copy<T>, +Drop<T>>(
-    mut a: Span<T>, mut b: Span<T>,
-) {
-    assert_eq!(a.len(), b.len());
-    let mut index = 0;
-    loop {
-        match a.pop_front() {
-            Some(current_a) => {
-                let current_b = b.pop_front().unwrap();
-                assert_eq!(*current_a, *current_b, "wrong data for index: {index}");
-            },
-            None(_) => { break; },
-        }
-        index += 1;
-    }
-}
-
 fn test_byte_array_1() -> ByteArray {
     let mut ba1 = Default::default();
     ba1.append_word(0x01, 1);