Skip to content

refactor: simplify redundant string conversions #8675

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Nov 24, 2025
Merged

refactor: simplify redundant string conversions #8675

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
62c96c8
Update test_utils.rs
MamunC0der Nov 16, 2025
d20062b
Update colored_printer.rs
MamunC0der Nov 16, 2025
cc1c0ce
Update test_utils.rs
MamunC0der Nov 16, 2025
032d960
Ran `./scripts/rust_fmt.sh`.
orizi Nov 24, 2025
9b1d3a6
Merge branch 'main' into main
orizi Nov 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion crates/cairo-lang-parser/src/colored_printer.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ impl ColoredPrinter<'_> {
self.result.push_str(format!("{}", "<m>".red()).as_str());
} else {
self.result
.push_str(set_color(text.long(self.db), node.kind).to_string().as_str());
.push_str(&set_color(text.long(self.db), node.kind).to_string());
}
}
GreenNodeDetails::Node { .. } => {
Expand Down
4 changes: 2 additions & 2 deletions crates/cairo-lang-sierra-to-casm/src/invocations/test_utils.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -105,7 +105,7 @@ struct MockSpecializationContext {}
impl TypeSpecializationContext for MockSpecializationContext {
fn try_get_type_info(&self, id: ConcreteTypeId) -> Option<TypeInfo> {
let long_id = cairo_lang_sierra::ConcreteTypeLongIdParser::new()
.parse(id.to_string().as_str())
.parse(&id.to_string())
.unwrap();
Some(
CoreType::specialize_by_id(self, &long_id.generic_id, &long_id.generic_args)
Expand Down Expand Up @@ -217,7 +217,7 @@ impl std::fmt::Debug for ReducedCompiledInvocation {
/// Currently, only works if all the libfunc's types (both inputs and output) are of size 1.
pub fn compile_libfunc(libfunc: &str, refs: Vec<ReferenceExpression>) -> ReducedCompiledInvocation {
let long_id = cairo_lang_sierra::ConcreteLibfuncLongIdParser::new()
.parse(libfunc.to_string().as_str())
.parse(libfunc)
.unwrap();
let context = MockSpecializationContext {};
let libfunc =
Expand Down
Loading