Skip to content

admin key can be exposed  #7

@ddebrunner

Description

@ddebrunner

The action uses ::add:mask:: to mask the input adminkey but this ends up logging the key, becuase there's no way in a composite action to mask values pulled from input within the action itself.

Best to remove that step and document that the caller should mask the key.

Usually this is not an issue because the key comes from GitHub secrets so it is automatically masked, but if the key came from an input on a workflow dispatch the value will be exposed.

See actions/runner#475 (comment)

Metadata

Metadata

Assignees

Labels

No labels
No labels

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions