Skip to content

Conversation

@mulkieran
Copy link
Member

@mulkieran mulkieran commented Oct 23, 2025

@mulkieran mulkieran self-assigned this Oct 23, 2025
@mulkieran mulkieran moved this to Pending in 2025October Oct 23, 2025
@coderabbitai
Copy link

coderabbitai bot commented Oct 23, 2025

Walkthrough

CI workflows are updated to use Fedora 42 container images instead of Fedora 41 across three GitHub Actions workflow files. The base image tags are updated in container specifications while workflow logic and steps remain unchanged.

Changes

Cohort / File(s) Summary
CI Workflow Container Updates
.github/workflows/cargo.yml, .github/workflows/main.yml, .github/workflows/nightly.yml
Container image references updated from fedora:41 to fedora:42 in respective job definitions

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

  • All changes are identical updates to container image tags across workflow files—no logic modifications or conditional changes

Possibly related PRs

Suggested reviewers

  • jbaublitz

Poem

🐰 From Fedora forty-one we hop,
To version forty-two, we won't stop!
Container images fresh and new,
CI workflows polished through and through,
Rab-bits thrive in gardens green! 🌱

Pre-merge checks and finishing touches

❌ Failed checks (1 warning)
Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. You can run @coderabbitai generate docstrings to improve docstring coverage.
✅ Passed checks (2 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title Check ✅ Passed The pull request title "Increase CURRENT DEVELOPMENT ENVIRONMENT to Fedora 42" directly aligns with the changeset. All three modified workflow files (.github/workflows/cargo.yml, main.yml, and nightly.yml) have the same change: updating the container image from fedora:41 to fedora:42. The title clearly identifies the primary change as an upgrade to Fedora 42 and is specific enough to give reviewers immediate understanding of the update's scope without requiring them to inspect the individual file changes.
✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between df50ea7 and 3975411.

📒 Files selected for processing (3)
  • .github/workflows/cargo.yml (1 hunks)
  • .github/workflows/main.yml (1 hunks)
  • .github/workflows/nightly.yml (1 hunks)
🔇 Additional comments (3)
.github/workflows/cargo.yml (1)

24-24: Consistent environment update to Fedora 42.

The container image update from fedora:41 to fedora:42 is minimal, focused, and aligns with the stated PR objective. The workflow logic remains unchanged, and the commented label properly identifies this as the CURRENT DEVELOPMENT ENVIRONMENT.

Please verify that Fedora 42 container images are available and stable on registry.fedoraproject.org or the relevant container registry used by your CI.

.github/workflows/main.yml (1)

253-253: Consistent environment update in yamllint verification job.

The container image change to fedora:42 is consistent with other workflow updates in this PR. The shorthand container: syntax is valid in GitHub Actions. All workflow steps remain unchanged.

.github/workflows/nightly.yml (1)

36-36: Environment update consistent across nightly workflow.

The container image change to fedora:42 mirrors the update in cargo.yml and maintains consistency across all workflow files in this PR. The structure and all workflow steps remain unchanged.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@packit-as-a-service
Copy link

Congratulations! One of the builds has completed. 🍾

You can install the built RPMs by following these steps:

  • sudo yum install -y dnf-plugins-core on RHEL 8
  • sudo dnf install -y dnf-plugins-core on Fedora
  • dnf copr enable packit/stratis-storage-libcryptsetup-rs-453
  • And now you can install the packages.

Please note that the RPMs should be used only in a testing environment.

@mulkieran mulkieran marked this pull request as ready for review October 30, 2025 23:49
@mulkieran mulkieran merged commit 306449c into stratis-storage:master Oct 31, 2025
44 of 45 checks passed
@github-project-automation github-project-automation bot moved this from Pending to Done in 2025October Oct 31, 2025
@mulkieran mulkieran deleted the issue_project_805 branch October 31, 2025 00:00
@mulkieran mulkieran moved this from Done to Done(3) in 2025October Nov 4, 2025
@mulkieran mulkieran moved this from Done(3) to Done(4) in 2025October Nov 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done(4)

Development

Successfully merging this pull request may close these issues.

1 participant