-
Notifications
You must be signed in to change notification settings - Fork 696
Update google places SDK. #12036
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Update google places SDK. #12036
Conversation
|
Diffuse output: APKMANIFESTDEX |
3 builds decreased size
Stripe Identity Example 22.2.0-theme1 (20)
|
| Item | Install Size Change | Download Size Change |
|---|---|---|
| androidx.compose.ui.input.key.KeyEvent_androidKt | ⬆️ 29.1 kB | ⬆️ 14.0 kB |
| 🗑 androidx.compose.foundation.lazy.layout.LazySaveableStateHolderKt | ⬇️ -26.6 kB | ⬇️ -12.8 kB |
| 🗑 androidx.compose.ui.platform.coreshims.ViewCompatShims | ⬇️ -24.8 kB | ⬇️ -11.9 kB |
| 📝 androidx.compose.runtime.saveable.SaveableStateRegistryImpl$regis... | ⬆️ 23.5 kB | ⬆️ 11.3 kB |
| android.support.v4.media.session.MediaSessionCompat | ⬇️ -20.1 kB | ⬇️ -9.6 kB |
Financial Connections Example 22.2.0 (220200)
com.stripe.android.financialconnections.example
⚖️ Compare build
⏱️ Analyze build performance
Total install size change: ⬇️ 164.7 kB (-1.6%)
Total download size change: ⬇️ 72.8 kB (-1.57%)
Largest size changes
| Item | Install Size Change | Download Size Change |
|---|---|---|
| 🗑 com.stripe.android.ui.core.elements.MandateTextUIKt | ⬇️ -73.7 kB | ⬇️ -34.5 kB |
| 📝 com.stripe.android.payments.bankaccount.ui.CollectBankAccountView... | ⬆️ 69.1 kB | ⬆️ 32.3 kB |
| 🗑 com.stripe.android.ui.core.elements.SaveForFutureUseElementUIKt | ⬇️ -67.5 kB | ⬇️ -31.6 kB |
| 🗑 com.stripe.android.ui.core.elements.H4TextKt | ⬇️ -63.2 kB | ⬇️ -29.6 kB |
| 📝 kotlin.time.DurationKt | ⬆️ 62.9 kB | ⬆️ 29.4 kB |
PaymentSheet Example 22.2.0 (11)
com.stripe.android.paymentsheet.example
⚖️ Compare build
⏱️ Analyze build performance
Total install size change: ⬇️ 1.2 MB (-8.58%)
Total download size change: ⬇️ 390.0 kB (-6.48%)
Largest size changes
| Item | Install Size Change | Download Size Change |
|---|---|---|
| 📝 com.bumptech.glide.GlideBuilder$LogRequestOrigins | ⬆️ 73.3 kB | ⬆️ 34.2 kB |
| 🗑 com.stripe.android.uicore.elements.bottomsheet.StripeBottomSheetS... | ⬇️ -62.3 kB | ⬇️ -28.2 kB |
| 🗑 androidx.compose.ui.text.font.FontLoadingStrategy | ⬇️ -60.2 kB | ⬇️ -27.2 kB |
| 📝 androidx.compose.ui.unit.IntRectKt | ⬆️ 57.5 kB | ⬆️ 26.8 kB |
| com.google.android.gms.dynamite.zzb | ⬇️ -60.8 kB | ⬇️ -26.8 kB |
🛸 Powered by Emerge Tools
Comment trigger: Size diff threshold of 100.00kB exceeded
2c77906 to
de54c62
Compare
de54c62 to
8624697
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@toluo-stripe can you take a look at these changes?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
| @Config(sdk = [Build.VERSION_CODES.O]) | ||
| fun `onRenderProcessGone calls errorHandler with view URL`() = testWithSetup { client, errors, webView -> | ||
| webView.loadUrl(HOST_URL) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A little surprised this passed. Do our tests run on android version >= O?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Gemeni tells me the default robolectric version is the highest supported version. But I honestly don't know!
| throw AssertionError("Not expected") | ||
| } | ||
|
|
||
| override fun zza( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A little weird that these functions are obfuscated and the above aren't



Summary
Updates the places SDK to the latest version.
While updating, we had to also update the minSDK version given the places SDK transitively updates the minSDK version as well.
Motivation
https://jira.corp.stripe.com/browse/RUN_MOBILESDK-4894
#12035
Changelog