add RanDeviceGen for random device generation #2273
+967
−12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…auth.py for greater control
onlined
reviewed
Oct 6, 2025
Contributor
There was a problem hiding this comment.
name should be ran_device_gen.py according to PEP 8.
onlined
reviewed
Oct 6, 2025
| "cpu": "qcom", | ||
| "version_code": "314665256", | ||
| } | ||
| self.device_settings = device or DeviceGen.random_device() |
Contributor
There was a problem hiding this comment.
This breaks current behavior, you might want to add a parameter or configuration flag for setting a random device. Or better, you can leave here alone and let callers pass DeviceGen.random_device().
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces a new feature: the RanDeviceGen module, designed to generate random yet configurable device data for authentication purposes.
Key Changes:
Added RanDeviceGen module for generating random device attributes
Integrated RanDeviceGen into auth.py to allow finer control over device behavior during authentication
Introduced helper methods:
Purpose:
Enables more realistic and customizable device parameter simulation, which can be useful for improving authentication flexibility and testing under varied regional/device configurations.