has_ephem_table is not defined in helioimage2fits

[sageyu123]

@binchensun,

I was poking around in helioimage2fits.py and noticed we're using has_ephem_table in our np.savez call like this:

np.savez(msinfofile, vis=vis, observatory=observatory, scans=scans, fieldids=fieldids, inttimes=inttimes,
         btimes=btimes, btimestr=btimestr, ras=ras, decs=decs, has_ephem_table=has_ephem_table)

It looks like has_ephem_table isn't defined anywhere before this. See helioimage2fits.py#L420

If I'm not wrong, it should be replaced by

np.savez(msinfofile, vis=vis, observatory=observatory, scans=scans, fieldids=fieldids, inttimes=inttimes,
         btimes=btimes, btimestr=btimestr, ras=ras, decs=decs, has_ephem_table=msinfo['has_ephem_table'])

[binchensun]

Correct! Thanks for noticing that. Make a PR?

…

On Tue, Mar 12, 2024 at 4:29 PM Sijie Yu ***@***.***> wrote: @binchensun, I was poking around in helioimage2fits. py and noticed we're using has_ephem_table in our np. savez call like this: np. savez(msinfofile, vis=vis, observatory=observatory, scans=scans, fieldids=fieldids, inttimes=inttimes, btimes=btimes, @binchensun <https://urldefense.com/v3/__https://github.com/binchensun__;!!DLa72PTfQgg!NsvH7v_BjI6aQK_LnKuqLe_II3oxnSTGheHVXitE1PenDBsKhkIIJl_nZ-uVnqj6LjohPzcIWLlHlihZGyCz8JUH$> , I was poking around in helioimage2fits.py <https://urldefense.com/v3/__http://helioimage2fits.py__;!!DLa72PTfQgg!NsvH7v_BjI6aQK_LnKuqLe_II3oxnSTGheHVXitE1PenDBsKhkIIJl_nZ-uVnqj6LjohPzcIWLlHlihZG1vwcfiH$> and noticed we're using has_ephem_table in our np.savez call like this: np.savez(msinfofile, vis=vis, observatory=observatory, scans=scans, fieldids=fieldids, inttimes=inttimes, btimes=btimes, btimestr=btimestr, ras=ras, decs=decs, has_ephem_table=has_ephem_table) It looks like has_ephem_table isn't defined anywhere before this. See helioimage2fits.py#L420 <https://urldefense.com/v3/__https://github.com/suncasa/suncasa-src/blob/13f95bfafdb824ef96b30c8fc69029e8610a1df2/suncasa/utils/helioimage2fits.py*L420__;Iw!!DLa72PTfQgg!NsvH7v_BjI6aQK_LnKuqLe_II3oxnSTGheHVXitE1PenDBsKhkIIJl_nZ-uVnqj6LjohPzcIWLlHlihZG7nZogOG$> If I'm not wrong, it should be replaced by np.savez(msinfofile, vis=vis, observatory=observatory, scans=scans, fieldids=fieldids, inttimes=inttimes, btimes=btimes, btimestr=btimestr, ras=ras, decs=decs, has_ephem_table=msinfo['has_ephem_table']) — Reply to this email directly, view it on GitHub <https://urldefense.com/v3/__https://github.com/suncasa/suncasa-src/issues/278__;!!DLa72PTfQgg!NsvH7v_BjI6aQK_LnKuqLe_II3oxnSTGheHVXitE1PenDBsKhkIIJl_nZ-uVnqj6LjohPzcIWLlHlihZGxMxvcKD$>, or unsubscribe <https://urldefense.com/v3/__https://github.com/notifications/unsubscribe-auth/AB5MZJV5QIB6NZ7Q2F74LW3YX5QSHAVCNFSM6AAAAABES54JVGVHI2DSMVQWIX3LMV43ASLTON2WKOZSGE4DENRRGUYDAOI__;!!DLa72PTfQgg!NsvH7v_BjI6aQK_LnKuqLe_II3oxnSTGheHVXitE1PenDBsKhkIIJl_nZ-uVnqj6LjohPzcIWLlHlihZG2vC-MO0$> . You are receiving this because you were mentioned.Message ID: ***@***.***>