more fixes

Author: psteinroe

crates/pglt_cli/src/commands/mod.rs

@@ -183,7 +183,7 @@ impl PgltCommand {
             | PgltCommand::Stop
             | PgltCommand::Init
             | PgltCommand::RunServer { .. }
-            | PgltCommand::Clean { .. }
+            | PgltCommand::Clean
             | PgltCommand::PrintSocket => None,
         }
     }

crates/pglt_cli/src/execute/mod.rs

@@ -103,7 +103,7 @@ pub enum TraversalMode {
 impl Display for TraversalMode {
     fn fmt(&self, f: &mut Formatter<'_>) -> std::fmt::Result {
         match self {
-            TraversalMode::Dummy { .. } => write!(f, "dummy"),
+            TraversalMode::Dummy => write!(f, "dummy"),
             TraversalMode::Check { .. } => write!(f, "check"),
         }
     }
@@ -165,33 +165,33 @@ impl Execution {
 
     pub(crate) fn as_diagnostic_category(&self) -> &'static Category {
         match self.traversal_mode {
-            TraversalMode::Dummy { .. } => category!("dummy"),
+            TraversalMode::Dummy => category!("dummy"),
             TraversalMode::Check { .. } => category!("check"),
         }
     }
 
     pub(crate) const fn is_dummy(&self) -> bool {
-        matches!(self.traversal_mode, TraversalMode::Dummy { .. })
+        matches!(self.traversal_mode, TraversalMode::Dummy)
     }
 
     /// Whether the traversal mode requires write access to files
     pub(crate) const fn requires_write_access(&self) -> bool {
         match self.traversal_mode {
-            TraversalMode::Dummy { .. } => false,
+            TraversalMode::Dummy => false,
             TraversalMode::Check { .. } => false,
         }
     }
 
     pub(crate) fn as_stdin_file(&self) -> Option<&Stdin> {
         match &self.traversal_mode {
-            TraversalMode::Dummy { .. } => None,
+            TraversalMode::Dummy => None,
             TraversalMode::Check { stdin, .. } => stdin.as_ref(),
         }
     }
 
     pub(crate) fn is_vcs_targeted(&self) -> bool {
         match &self.traversal_mode {
-            TraversalMode::Dummy { .. } => false,
+            TraversalMode::Dummy => false,
             TraversalMode::Check { vcs_targeted, .. } => {
                 vcs_targeted.staged || vcs_targeted.changed
             }
@@ -205,7 +205,7 @@ impl Execution {
     /// Returns [true] if the user used the `--write`/`--fix` option
     pub(crate) fn is_write(&self) -> bool {
         match self.traversal_mode {
-            TraversalMode::Dummy { .. } => false,
+            TraversalMode::Dummy => false,
             TraversalMode::Check { .. } => false,
         }
     }

crates/pglt_cli/src/execute/traverse.rs

@@ -487,7 +487,7 @@ impl TraversalContext for TraversalOptions<'_, '_> {
         }
 
         match self.execution.traversal_mode() {
-            TraversalMode::Dummy { .. } => true,
+            TraversalMode::Dummy => true,
             TraversalMode::Check { .. } => true,
         }
     }

crates/pglt_cli/src/reporter/terminal.rs

@@ -151,7 +151,7 @@ impl fmt::Display for SummaryTotal<'_> {
     fn fmt(&self, fmt: &mut Formatter) -> io::Result<()> {
         let files = Files(self.1);
         match self.0 {
-            TraversalMode::Dummy { .. } => fmt.write_markup(markup! {
+            TraversalMode::Dummy => fmt.write_markup(markup! {
                 "Dummy "{files}" in "{self.2}"."
             }),
             TraversalMode::Check { .. } => fmt.write_markup(markup! {

crates/pglt_cli/src/service/unix.rs

@@ -186,12 +186,7 @@ pub(crate) async fn ensure_daemon(
 
     // If the connection couldn't be opened after 10 tries fail with the last
     // error message from the OS, or a generic error message otherwise
-    Err(last_error.unwrap_or_else(|| {
-        io::Error::new(
-            io::ErrorKind::Other,
-            "could not connect to the daemon socket",
-        )
-    }))
+    Err(last_error.unwrap_or_else(|| io::Error::other("could not connect to the daemon socket")))
 }
 
 /// Ensure the server daemon is running and ready to receive connections and

crates/pglt_completions/src/context.rs

@@ -122,10 +122,7 @@ impl<'a> CompletionContext<'a> {
 
     pub fn get_ts_node_content(&self, ts_node: tree_sitter::Node<'a>) -> Option<&'a str> {
         let source = self.text;
-        match ts_node.utf8_text(source.as_bytes()) {
-            Ok(content) => Some(content),
-            Err(_) => None,
-        }
+        ts_node.utf8_text(source.as_bytes()).ok()
     }
 
     fn gather_tree_context(&mut self) {

crates/pglt_configuration/src/analyser/linter/rules.rs

@@ -2,7 +2,7 @@
 
 use crate::analyser::{RuleConfiguration, RulePlainConfiguration};
 use biome_deserialize_macros::Merge;
-use pglt_analyse::{options::RuleOptions, RuleFilter};
+use pglt_analyse::{RuleFilter, options::RuleOptions};
 use pglt_diagnostics::{Category, Severity};
 use rustc_hash::FxHashSet;
 #[cfg(feature = "schema")]

crates/pglt_configuration/src/files.rs

@@ -8,7 +8,7 @@ use serde::{Deserialize, Serialize};
 /// Limit the size of files to 1.0 MiB by default
 pub const DEFAULT_FILE_SIZE_LIMIT: NonZeroU64 =
     // SAFETY: This constant is initialized with a non-zero value
-    unsafe { NonZeroU64::new_unchecked(1024 * 1024) };
+    NonZeroU64::new(1024 * 1024).unwrap();
 
 /// The configuration of the filesystem
 #[derive(Clone, Debug, Deserialize, Eq, Partial, PartialEq, Serialize)]

crates/pglt_console/src/write/termcolor.rs

@@ -53,10 +53,7 @@ where
                     if adapter.error.is_err() {
                         adapter.error
                     } else {
-                        Err(io::Error::new(
-                            io::ErrorKind::Other,
-                            "a Display formatter returned an error",
-                        ))
+                        Err(io::Error::other("a Display formatter returned an error"))
                     }
                 }
             }

crates/pglt_diagnostics/src/context.rs

@@ -344,19 +344,15 @@ mod internal {
 
     impl fmt::Write for DisplayMarkup<'_, '_> {
         fn write_str(&mut self, _: &fmt::MarkupElements<'_>, content: &str) -> io::Result<()> {
-            self.0
-                .write_str(content)
-                .map_err(|error| io::Error::new(io::ErrorKind::Other, error))
+            self.0.write_str(content).map_err(io::Error::other)
         }
 
         fn write_fmt(
             &mut self,
             _: &fmt::MarkupElements<'_>,
             content: std::fmt::Arguments<'_>,
         ) -> io::Result<()> {
-            self.0
-                .write_fmt(content)
-                .map_err(|error| io::Error::new(io::ErrorKind::Other, error))
+            self.0.write_fmt(content).map_err(io::Error::other)
         }
     }