error message when version is invalid

Author: imor

cli/src/commands/publish.rs

@@ -24,6 +24,10 @@ pub async fn publish(
     let request = create_publish_package_request(&payload);
     client.publish_package(&jwt, &request).await?;
 
+    if payload.install_files.is_empty() {
+        return Err(anyhow::anyhow!("No valid script file (.sql) found."));
+    }
+
     let mut num_published = 0;
 
     for install_file in &payload.install_files {
@@ -45,10 +49,6 @@ pub async fn publish(
         }
     }
 
-    if num_published == 0 {
-        return Err(anyhow::anyhow!("No valid script file (.sql) found."));
-    }
-
     for upgrade_file in &payload.upgrade_files {
         let request =
             create_publich_package_upgrade_request(&payload.metadata.extension_name, upgrade_file);

cli/src/models.rs

@@ -171,7 +171,7 @@ impl Payload {
                         continue;
                     }
                     if !util::is_valid_version(ver) {
-                        println!("Warning: file `{file_name}` will be skipped because its version (`{ver}`) is invalid");
+                        println!("Warning: file `{file_name}` will be skipped because its version (`{ver}`) is invalid. It should be have the format `major.minor.patch`.");
                         continue;
                     }
 
@@ -190,11 +190,11 @@ impl Payload {
                         continue;
                     }
                     if !util::is_valid_version(from_ver) {
-                        println!("Warning: file `{file_name}` will be skipped because its from version(`{from_ver}`) is invalid.");
+                        println!("Warning: file `{file_name}` will be skipped because its from version(`{from_ver}`) is invalid. It should be have the format `major.minor.patch`.");
                         continue;
                     }
                     if !util::is_valid_version(to_ver) {
-                        println!("Warning: file `{file_name}` will be skipped because its from version(`{to_ver}`) is invalid.");
+                        println!("Warning: file `{file_name}` will be skipped because its from version(`{to_ver}`) is invalid. It should be have the format `major.minor.patch`.");
                         continue;
                     }
 

cli/src/util.rs

@@ -16,7 +16,23 @@ pub fn is_valid_extension_name(name: &str) -> bool {
     name_regex.is_match(name)
 }
 
-pub fn is_valid_version(_version: &str) -> bool {
+pub fn is_valid_version(version: &str) -> bool {
+    let nums: Vec<&str> = version.split('.').collect();
+    if nums.len() != 3 {
+        println!("1");
+        return false;
+    }
+
+    for num_str in nums {
+        let num: i16 = match num_str.parse() {
+            Ok(n) => n,
+            _ => return false,
+        };
+        if num < 0 {
+            return false;
+        }
+    }
+
     true
 }