Skip to content

Commit 90ff927

Browse files
authored
Merge pull request #102 from supabase/feat/better-upload-url
Better method of getting `upload_url`
2 parents 7f9f786 + 537c3bb commit 90ff927

File tree

1 file changed

+5
-12
lines changed

1 file changed

+5
-12
lines changed

.github/workflows/release-cli.yaml

Lines changed: 5 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -24,6 +24,8 @@ jobs:
2424
TODO: Write release notes
2525
draft: false
2626
prerelease: false
27+
outputs:
28+
upload_url: ${{ steps.create_release.outputs.upload_url }}
2729

2830
build-linux:
2931
name: Release Artifacts on Linux
@@ -55,12 +57,10 @@ jobs:
5557
cargo build --release
5658
cd ./target/release && tar -czvf dbdev.tar.gz ./dbdev
5759
58-
- name: Get Upload Url
59-
run: echo UPLOAD_URL=$(curl --silent https://api.github.com/repos/${{ github.repository }}/releases/latest | jq .upload_url --raw-output) >> $GITHUB_ENV
60-
6160
- name: Upload Release Asset
6261
uses: actions/upload-release-asset@v1
6362
env:
63+
UPLOAD_URL: ${{ needs.create-release.outputs.upload_url }}
6464
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
6565
with:
6666
upload_url: ${{ env.UPLOAD_URL }}
@@ -88,12 +88,10 @@ jobs:
8888
cargo build --release
8989
cd ./target/release && tar -czvf dbdev.tar.gz ./dbdev
9090
91-
- name: Get Upload Url
92-
run: echo UPLOAD_URL=$(curl --silent https://api.github.com/repos/${{ github.repository }}/releases/latest | jq .upload_url --raw-output) >> $GITHUB_ENV
93-
9491
- name: Upload Release Asset
9592
uses: actions/upload-release-asset@v1
9693
env:
94+
UPLOAD_URL: ${{ needs.create-release.outputs.upload_url }}
9795
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
9896
with:
9997
upload_url: ${{ env.UPLOAD_URL }}
@@ -121,15 +119,10 @@ jobs:
121119
cargo build --release
122120
cd ./target/release && Compress-Archive -Path ./dbdev.exe -Destination dbdev.zip
123121
124-
- name: Get Upload Url
125-
run: |
126-
$Json = Invoke-WebRequest -Uri https://api.github.com/repos/${{ github.repository }}/releases/latest | ConvertFrom-Json
127-
$UploadUrl = $Json.upload_url
128-
echo "UPLOAD_URL=$UploadUrl" | Out-File -FilePath $env:GITHUB_ENV -Encoding utf8 -Append
129-
130122
- name: Upload Release Asset
131123
uses: actions/upload-release-asset@v1
132124
env:
125+
UPLOAD_URL: ${{ needs.create-release.outputs.upload_url }}
133126
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
134127
with:
135128
upload_url: ${{ env.UPLOAD_URL }}

0 commit comments

Comments
 (0)