removes the behaviour of the core not starting in case can't connect to db during license check

Author: rishabhpoddar

ee/src/main/java/io/supertokens/ee/EEFeatureFlag.java

@@ -73,7 +73,7 @@ public void updateEnabledFeaturesValueReadFromDbTime(long newTime) {
     }
 
     @Override
-    public void constructor(Main main) throws StorageQueryException {
+    public void constructor(Main main) {
         this.main = main;
         Cronjobs.addCronjob(main, EELicenseCheck.getInstance(main));
         try {
@@ -85,12 +85,6 @@ public void constructor(Main main) throws StorageQueryException {
             // the license key that was in the db was invalid. If this error is thrown,
             // it means that the key was removed from the db anyway.. so we can just ignore
             // here.
-        } catch (StorageQueryException e) {
-            ProcessState.getInstance(main)
-                    .addState(ProcessState.PROCESS_STATE.INIT_FAILURE_DUE_TO_LICENSE_KEY_DB_CHECK, e);
-            // we intentionally throw this error so that the core stops
-            // since we need to know the initial state of the license and features from the db
-            throw e;
         } catch (Throwable ignored) {
         }
     }

ee/src/test/java/io/supertokens/ee/test/EETest.java

@@ -950,36 +950,6 @@ public void testVariousOpaqueKeys()
         }
     }
 
-    @Test
-    public void testDbQueryOnCoreStartStopsCore()
-            throws Exception {
-        String[] args = {"../../"};
-
-        {
-            TestingProcessManager.TestingProcess process = TestingProcessManager.start(args, false);
-            process.main.waitToEnableFeatureFlag();
-            process.startProcess();
-            Thread.sleep(4000);
-            process.main.deleteAllInformationForTesting();
-            process.main.proceedToEnableFeatureFlag();
-            if (StorageLayer.getStorage(process.getProcess()).getType() == STORAGE_TYPE.SQL
-                    && !Version.getVersion(process.getProcess()).getPluginName().equals("sqlite")) {
-                ProcessState.EventAndException coreFailure = process.checkOrWaitForEvent(
-                        ProcessState.PROCESS_STATE.INIT_FAILURE);
-                ProcessState.EventAndException fromEE = process.checkOrWaitForEvent(
-                        ProcessState.PROCESS_STATE.INIT_FAILURE_DUE_TO_LICENSE_KEY_DB_CHECK);
-                assertNotNull(coreFailure);
-                assertNotNull(fromEE);
-                assertEquals(coreFailure.exception.getCause(), fromEE.exception);
-            } else {
-                Assert.assertNotNull(process.checkOrWaitForEvent(ProcessState.PROCESS_STATE.STARTED));
-            }
-
-            process.kill();
-            Assert.assertNotNull(process.checkOrWaitForEvent(ProcessState.PROCESS_STATE.STOPPED));
-        }
-    }
-
     @Test
     public void testThatInvalidOpaqueKeyOnCoreStartCausesNoFeaturesToBeLoaded() throws Exception {
         String[] args = {"../../"};

src/main/java/io/supertokens/ProcessState.java

@@ -84,7 +84,7 @@ public enum PROCESS_STATE {
         CREATING_NEW_TABLE, SENDING_TELEMETRY, SENT_TELEMETRY, SETTING_ACCESS_TOKEN_SIGNING_KEY_TO_NULL,
         PASSWORD_HASH_BCRYPT, PASSWORD_HASH_ARGON, PASSWORD_VERIFY_BCRYPT, PASSWORD_VERIFY_ARGON,
         PASSWORD_VERIFY_FIREBASE_SCRYPT, ADDING_REMOTE_ADDRESS_FILTER, LICENSE_KEY_CHECK_NETWORK_CALL,
-        INVALID_LICENSE_KEY, SERVER_ERROR_DURING_LICENSE_KEY_CHECK_FAIL, INIT_FAILURE_DUE_TO_LICENSE_KEY_DB_CHECK
+        INVALID_LICENSE_KEY, SERVER_ERROR_DURING_LICENSE_KEY_CHECK_FAIL
     }
 
     public static class EventAndException {

src/main/java/io/supertokens/featureflag/EEFeatureFlagInterface.java

@@ -30,7 +30,7 @@ public interface EEFeatureFlagInterface {
     @TestOnly
     void updateEnabledFeaturesValueReadFromDbTime(long newTime);
 
-    void constructor(Main main) throws StorageQueryException;
+    void constructor(Main main);
 
     EE_FEATURES[] getEnabledFeatures() throws StorageQueryException;
 

src/main/java/io/supertokens/featureflag/FeatureFlag.java

@@ -19,7 +19,6 @@
 import com.google.gson.JsonObject;
 import io.supertokens.Main;
 import io.supertokens.ResourceDistributor;
-import io.supertokens.exceptions.QuitProgramException;
 import io.supertokens.featureflag.exceptions.InvalidLicenseKeyException;
 import io.supertokens.featureflag.exceptions.NoLicenseKeyFoundException;
 import io.supertokens.httpRequest.HttpResponseException;
@@ -73,11 +72,7 @@ private FeatureFlag(Main main, String eeFolderPath) throws MalformedURLException
 
         if (eeLayerTemp != null) {
             this.eeFeatureFlag = eeLayerTemp;
-            try {
-                this.eeFeatureFlag.constructor(main);
-            } catch (StorageQueryException e) {
-                throw new QuitProgramException(e);
-            }
+            this.eeFeatureFlag.constructor(main);
         } else {
             eeFeatureFlag = null;
         }