Skip to content

Commit dd8aa42

Browse files
authored
fix: bulk import external userid error translation (#1144)
* fix: fixes null pointer exception in case of missing externalUserId in bulkImport * chore: add changelog
1 parent affa771 commit dd8aa42

File tree

2 files changed

+2
-1
lines changed

2 files changed

+2
-1
lines changed

CHANGELOG.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -11,6 +11,7 @@ to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).
1111

1212
- Fixes bulk migration user roles association when there is no external userId assigned to the user
1313
- Bulk migration now actually uses the `isVerified` field's value in the loginMethod input
14+
- Fixes nullpointer exception in bulk migration error handling in case of null external user id
1415

1516
## [10.1.3]
1617

src/main/java/io/supertokens/cronjobs/bulkimport/ProcessBulkUsersImportWorker.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -215,7 +215,7 @@ private static void handleBulkImportException(List<BulkImportUser> usersBatch, B
215215
Map<String, Exception> userIndexToError = exception.exceptionByUserId;
216216
for(String userid : userIndexToError.keySet()){
217217
Optional<BulkImportUser> userWithId = usersBatch.stream()
218-
.filter(bulkImportUser -> bulkImportUser.id.equals(userid) || bulkImportUser.externalUserId.equals(userid)).findFirst();
218+
.filter(bulkImportUser -> userid.equals(bulkImportUser.id) || userid.equals(bulkImportUser.externalUserId)).findFirst();
219219
String id = null;
220220
if(userWithId.isPresent()){
221221
id = userWithId.get().id;

0 commit comments

Comments
 (0)