chore: fix shadow plugin to work with kotlin 2.1.20-RC multiplatform plugin

Author: sureshg

README.md

@@ -72,8 +72,16 @@ For testing, a separate [sandbox project](/sandbox) is available with the plugin
 `settings.gradle.kts`. First publish the plugin to the local maven repository and then run the sandbox project.
 
    ```bash
+   # Publish the plugins to maven local
    $ ./gradlew publishToMavenLocal
-   $ ./gradlew -p sandbox :build
+
+   # Build the sandbox app using published plugin
+   $ ./gradlew -p sandbox :build -PjvmArgs=
+
+   # Run the sandbox app
+   $ sandbox/build/libs/sandbox-app
+
+   # Run other plugin tasks
    $ ./gradlew -p sandbox :dependencyUpdates --no-configuration-cache
    ```
 

plugins/project/src/main/kotlin/common/Multiplatform.kt

@@ -102,7 +102,7 @@ fun KotlinMultiplatformExtension.jvmTarget(project: Project) =
         // val test by testRuns.existing
         testRuns.configureEach { executionTask.configure { configureJavaTest() } }
 
-        // Configure application executable only it's enabled
+        // Configures JavaExec task with name "runJvm" and Gradle distribution "jvmDistZip"
         if (isKmpExecEnabled) {
           binaries {
             executable {
@@ -113,14 +113,6 @@ fun KotlinMultiplatformExtension.jvmTarget(project: Project) =
           }
         }
 
-        // Register a task to execute a class using jvm runtime dependencies.
-        // compilations.getByName("test") {
-        //   tasks.register<JavaExec>("ktExec") {
-        //     classpath(runtimeDependencyFiles, output)
-        //     mainClass = "dev.suresh.test.ExecMain"
-        //   }
-        // }
-
         // attributes.attribute(KotlinPlatformType.attribute, KotlinPlatformType.jvm)
       }
 

plugins/project/src/main/kotlin/dev.suresh.plugin.kotlin.mpp.gradle.kts

@@ -1,6 +1,7 @@
 @file:Suppress("UnstableApiUsage")
 @file:OptIn(ExperimentalKotlinGradlePluginApi::class, ExperimentalBCVApi::class)
 
+import com.github.jengelman.gradle.plugins.shadow.tasks.ShadowJar
 import com.google.devtools.ksp.gradle.KspAATask
 import com.javiersc.kotlin.kopy.args.KopyFunctions
 import common.*
@@ -135,6 +136,34 @@ tasks {
     }
   }
 
+  pluginManager.withPlugin("com.gradleup.shadow") {
+    // Register a shadowJar task for the default jvm target
+    val mainCompilation = kotlin.jvm().compilations.getByName("main")
+    val shadowJvmJar by
+        registering(ShadowJar::class) {
+          from(tasks.named("jvmJar"))
+          // from(mainCompilation.output.allOutputs) -> allOutputs == classes + resources
+          val runtimeDepConfig =
+              project.configurations.getByName(mainCompilation.runtimeDependencyConfigurationName)
+          configurations = listOf(runtimeDepConfig)
+          archiveClassifier = "all"
+          mergeServiceFiles()
+          manifest {
+            attributes[Attributes.Name.MAIN_CLASS.toString()] = libs.versions.app.mainclass
+          }
+        }
+
+    val buildExecutable by
+        registering(ReallyExecJar::class) {
+          jarFile = shadowJvmJar.flatMap { it.archiveFile }
+          javaOpts = jvmRunArgs
+          execJarFile = layout.buildDirectory.dir("libs").map { it.file("${project.name}-app") }
+          onlyIf { OperatingSystem.current().isUnix }
+        }
+
+    build { finalizedBy(buildExecutable) }
+  }
+
   pluginManager.withPlugin("org.jetbrains.kotlinx.binary-compatibility-validator") {
     configure<ApiValidationExtension> {
       ignoredPackages.add("dev.suresh.test")
@@ -144,22 +173,9 @@ tasks {
     }
 
     withType<KotlinApiBuildTask>().configureEach {
-      // inputJar = named<Jar>("shadowJar").flatMap { it.archiveFile }
+      // inputJar = named<Jar>("shadowJvmJar").flatMap { it.archiveFile }
     }
   }
-
-  pluginManager.withPlugin("com.gradleup.shadow") {
-    val buildExecutable by
-        registering(ReallyExecJar::class) {
-          jarFile = named<Jar>("shadowJar").flatMap { it.archiveFile }
-          // javaOpts = application.applicationDefaultJvmArgs
-          javaOpts = named<JavaExec>("run").get().jvmArgs
-          execJarFile = layout.buildDirectory.dir("libs").map { it.file("${project.name}-app") }
-          onlyIf { OperatingSystem.current().isUnix }
-        }
-
-    build { finalizedBy(buildExecutable) }
-  }
 }
 
 var npmEnabled: String? by rootProject.extra