WSL Rework Discussion #1957

[svpernova09]

Original Discussion: laravel#1957

[sdespont]

Could you consider merging laravel#1983 in your fork ?

[sdespont]

@svpernova09 thank you! Can you clarify the status of the two projects please? Is https://github.com/laravel/homestead no longer maintained and this is the new one? I mean, where do I put the pull requests for WSL now?

[svpernova09]

Laravel Homestead is no longer maintained.

I am maintaining Svpernova09/homestead which is where any WSL PRS should be sent.

The PRs that were opened on laravel/homestead by me this morning were mistaken / me following bad links and have been closed.

One concern I have with your WSL change I merged today is that the WSL script was never intended to use the feature scripts in Homestead. Since we're reworking that in its own branch I feel safer testing that out to see what breaks and if it's robust enough.

Thanks!

[sdespont]

OK and thanks for your work !

I won't ask why you forked the repo, but why isn't there a message stating that the Laravel repo is no longer maintained?

[svpernova09]

OK and thanks for your work !

I won't ask why you forked the repo, but why isn't there a message stating that the Laravel repo is no longer maintained?

This issue has more context: laravel#1977

[fish3046]

Hello, I'm wondering what the state of the wsl-rework branch is. I've been using it with great success for months, but now it's time to start looking at PHP 8.4 which this branch doesn't have. Should we be switching back to main and swapping back to the old wsl_sites method?

Is there some missing piece before wsl-rework can be merged to main? I considered copying the feature from main to wsl-sites but that seems like the wrong direction.

[svpernova09]

Hello, I'm wondering what the state of the wsl-rework branch is. I've been using it with great success for months, but now it's time to start looking at PHP 8.4 which this branch doesn't have. Should we be switching back to main and swapping back to the old wsl_sites method?

Is there some missing piece before wsl-rework can be merged to main? I considered copying the feature from main to wsl-sites but that seems like the wrong direction.

It's great to hear it's working for you. I'm trying to get the next major versions of Homestead and its base box out the door, and then I will get back to WSL. My primary concern is that it consumes the PHP feature scripts, which weren't intended, but should be fine. My uncertainty is purely from my own lack of testing of that functionality.

[MichaelBelgium]

I just did a fresh wsl-init and php8.4 gets installed, together with php 8.3

This installs php 8.4 (somehow)

homestead/bin/wsl-init

Lines 105 to 107 in 54d27f4

	# Install Generic PHP packages
	apt-get install -y --allow-change-held-packages \
	php-imagick php-memcached php-redis php-xdebug php-dev php-swoole

This installs php 8.3

homestead/bin/wsl-init

Lines 109 to 110 in 54d27f4

	# PHP 8.3
	bash 'scripts/features/php8.3.sh'

The "Install Generic PHP packages" part is unecessary I think.
We need to choose a default PHP version and then call that feature script, like the 8.3 one

But if you want 8.4, it's also a feature script so you can specify it in homestead.yml you want it installed

EDIT:

My primary concern is that it consumes the PHP feature scripts, which weren't intended, but should be fine.

Honestly it looks cleaner to just consume the feature script, its modular. Dont need to copy paste stuff when you already have the commands to do it

EDIT2:

I'd also recommend to install nvm for nodejs in stead of the current installation commands, nvm is very easy to use

MichaelBelgium@dcea833

I have it ready in my fork, which I can do a PR for

[skeeith]

@svpernova09 @MichaelBelgium @sdespont @fish3046 hey guys, what's the update on this?

what's the status on this one?
is there any test needed on this or help? I would be happy to help work on this.

[MichaelBelgium]

@skeeith I just did a PR with my requested changes. Contributes to WSL deploy stability

The only thing i'd like to see is to have nvm installed for nodejs, but i couldn't get it to work via the bash script. Only manually installing works somehow

Overall, I'm not sure what @svpernova09 plan is from this point. He's unfortunately not active at most time😛

[skeeith]

@MichaelBelgium he's active but probably a bit busy on some things, he just close a few tickets and open a new one for testing a Homestead version and Settler Box version.

I'm sure he'll look into this soon, but while he's busy working on trying to push the new Homestead and Settler Box version, I'll take a look at this, I'll see if I can make nvm installed by default on WSL.

Also, can you help test this one? #24

[skeeith]

@MichaelBelgium can you tell me what files have you tried tinkering with this to try to make nvm installed by default?

I wouldn't have to start from scratch?

[MichaelBelgium]

@skeeith In wsl-init bash: dcea833

But i reverted this yesterday as this doesn't seem to work, it doesn't detect nvm automaticly