Skip to content

Commit 1cdb157

Browse files
committed
Respect Windows Path Separators in isRxJSImport
Resolves #139
1 parent 2276fe2 commit 1cdb157

File tree

4 files changed

+8
-2
lines changed

4 files changed

+8
-2
lines changed

CHANGELOG.md

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,10 @@
22

33
Install the latest version from the [Visual Studio Marketplace](https://marketplace.visualstudio.com/items?itemName=manuelalabor.rxjs-debugging-for-vs-code).
44

5+
## 1.1.1
6+
7+
- Bugfix: RxJS is not detected on Windows Systems [#139](https://github.com/swissmanu/rxjs-debugging-for-vscode/issues/139)
8+
59
## 1.1.0
610

711
- Improvement: Support for Plain JavaScript [#126](https://github.com/swissmanu/rxjs-debugging-for-vscode/issues/126)

README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@ Add non-intrusive debugging capabilities for [RxJS](https://rxjs.dev/) applicati
2222
- [Node.js 12](https://nodejs.org/) or newer
2323
- To debug Webpack-based web applications:
2424
- [Webpack 5.60.0](https://webpack.js.org/) or newer
25-
- The [@rxjs-debugging/runtime-webpack](https://www.npmjs.com/package/@rxjs-debugging/runtime-webpack) Webpack plugin
25+
- The latest [@rxjs-debugging/runtime-webpack](https://www.npmjs.com/package/@rxjs-debugging/runtime-webpack) Webpack plugin (see [here](https://www.npmjs.com/package/@rxjs-debugging/runtime-webpack) for setup instructions)
2626

2727
## Usage
2828

packages/runtime/src/utils/isRxJSImport.test.ts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -14,6 +14,7 @@ describe('Runtime', () => {
1414
[true, '/node_modules/rxjs/internal/Observable.js'],
1515
[true, '/node_modules/rxjs/internal/Observable'],
1616
[true, 'rxjs/internal/Observable'],
17+
[true, 'C:\\projects\\rxjsdebugger\\rxjs\\internal\\Observable.js'],
1718
[false, 'rxjs'],
1819
[false, 'rxjs/Observable'],
1920
[false, 'Observable'],

packages/runtime/src/utils/isRxJSImport.ts

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,5 @@
1-
const OBSERVABLE_MODULE_REGEX = /rxjs\/(dist\/|esm\/|esm5\/|_esm5\/|_esm2015\/|cjs\/)*internal\/Observable(\.js)?$/;
1+
const OBSERVABLE_MODULE_REGEX =
2+
/rxjs(\/|\\)(dist(\/|\\)|esm(\/|\\)|esm5(\/|\\)|_esm5(\/|\\)|_esm2015(\/|\\)|cjs(\/|\\))*internal(\/|\\)Observable(\.js)?$/;
23

34
/**
45
* Tests if a given path is leads to RxJS' `Observable.js` file.

0 commit comments

Comments
 (0)