adding limit option to candidates

Author: dbu

Candidates/Candidates.php

@@ -29,12 +29,25 @@ class Candidates implements CandidatesInterface
      */
     protected $locales;
 
+    /**
+     * A limit to apply to the number of candidates generated.
+     *
+     * This is to prevent abusive requests with a lot of "/". The limit is per
+     * batch, that is if a locale matches you could get as many as 2 * $limit
+     * candidates if the URL has that many slashes.
+     *
+     * @var int
+     */
+    protected $limit;
+
     /**
      * @param array $locales The locales to support.
+     * @param int   $limit   A limit to apply to the candidates generated.
      */
-    public function __construct(array $locales = array())
+    public function __construct(array $locales = array(), $limit = 20)
     {
         $this->setLocales($locales);
+        $this->limit = $limit;
     }
 
     /**
@@ -125,7 +138,11 @@ protected function getCandidatesFor($url, $prefix = '')
             }
 
             $part = $url;
+            $count = 0;
             while (false !== ($pos = strrpos($part, '/'))) {
+                if (++$count > $this->limit) {
+                    return $candidates;
+                }
                 $candidates[] = $prefix . $part;
                 $part = substr($url, 0, $pos);
             }

Tests/Candidates/CandidatesTest.php

@@ -88,4 +88,22 @@ public function testGetCandidatesLocales()
             $paths
         );
     }
+
+    public function testGetCandidatesLimit()
+    {
+        $candidates = new Candidates(array(), 1);
+
+        $request = Request::create('/my/path/is/deep.html');
+
+        $paths = $candidates->getCandidates($request);
+
+        $this->assertEquals(
+            array(
+                '/my/path/is/deep.html',
+                '/my/path/is/deep',
+            ),
+            $paths
+        );
+
+    }
 }