CS fixes

nicolas-grekas · nicolas-grekas · commit 8ff659ffd3b8 · 2025-07-10T10:14:14.000+02:00
diff --git a/Authentication/Token/AbstractToken.php b/Authentication/Token/AbstractToken.php
@@ -134,7 +134,7 @@ public function hasAttribute(string $name): bool
     public function getAttribute(string $name): mixed
     {
         if (!\array_key_exists($name, $this->attributes)) {
-            throw new \InvalidArgumentException(sprintf('This token has no "%s" attribute.', $name));
+            throw new \InvalidArgumentException(\sprintf('This token has no "%s" attribute.', $name));
         }
 
         return $this->attributes[$name];
@@ -158,7 +158,7 @@ public function __toString(): string
             $roles[] = $role;
         }
 
-        return sprintf('%s(user="%s", roles="%s")', $class, $this->getUserIdentifier(), implode(', ', $roles));
+        return \sprintf('%s(user="%s", roles="%s")', $class, $this->getUserIdentifier(), implode(', ', $roles));
     }
 
     /**
diff --git a/Authorization/AccessDecisionManager.php b/Authorization/AccessDecisionManager.php
@@ -53,7 +53,7 @@ public function decide(TokenInterface $token, array $attributes, mixed $object =
     {
         // Special case for AccessListener, do not remove the right side of the condition before 6.0
         if (\count($attributes) > 1 && !$allowMultipleAttributes) {
-            throw new InvalidArgumentException(sprintf('Passing more than one Security attribute to "%s()" is not supported.', __METHOD__));
+            throw new InvalidArgumentException(\sprintf('Passing more than one Security attribute to "%s()" is not supported.', __METHOD__));
         }
 
         return $this->strategy->decide(
@@ -69,7 +69,7 @@ private function collectResults(TokenInterface $token, array $attributes, mixed
         foreach ($this->getVoters($attributes, $object) as $voter) {
             $result = $voter->vote($token, $object, $attributes);
             if (!\is_int($result) || !(self::VALID_VOTES[$result] ?? false)) {
-                throw new \LogicException(sprintf('"%s::vote()" must return one of "%s" constants ("ACCESS_GRANTED", "ACCESS_DENIED" or "ACCESS_ABSTAIN"), "%s" returned.', get_debug_type($voter), VoterInterface::class, var_export($result, true)));
+                throw new \LogicException(\sprintf('"%s::vote()" must return one of "%s" constants ("ACCESS_GRANTED", "ACCESS_DENIED" or "ACCESS_ABSTAIN"), "%s" returned.', get_debug_type($voter), VoterInterface::class, var_export($result, true)));
             }
 
             yield $result;
diff --git a/Authorization/AuthorizationChecker.php b/Authorization/AuthorizationChecker.php
@@ -30,7 +30,7 @@ class AuthorizationChecker implements AuthorizationCheckerInterface
     public function __construct(TokenStorageInterface $tokenStorage, AccessDecisionManagerInterface $accessDecisionManager, bool $exceptionOnNoToken = false)
     {
         if ($exceptionOnNoToken) {
-            throw new \LogicException(sprintf('Argument $exceptionOnNoToken of "%s()" must be set to "false".', __METHOD__));
+            throw new \LogicException(\sprintf('Argument $exceptionOnNoToken of "%s()" must be set to "false".', __METHOD__));
         }
 
         $this->tokenStorage = $tokenStorage;
diff --git a/Authorization/ExpressionLanguage.php b/Authorization/ExpressionLanguage.php
@@ -15,7 +15,7 @@
 use Symfony\Component\ExpressionLanguage\ExpressionLanguage as BaseExpressionLanguage;
 
 if (!class_exists(BaseExpressionLanguage::class)) {
-    throw new \LogicException(sprintf('The "%s" class requires the "ExpressionLanguage" component. Try running "composer require symfony/expression-language".', ExpressionLanguage::class));
+    throw new \LogicException(\sprintf('The "%s" class requires the "ExpressionLanguage" component. Try running "composer require symfony/expression-language".', ExpressionLanguage::class));
 } else {
     // Help opcache.preload discover always-needed symbols
     class_exists(ExpressionLanguageProvider::class);
diff --git a/Authorization/ExpressionLanguageProvider.php b/Authorization/ExpressionLanguageProvider.php
@@ -28,7 +28,7 @@ public function getFunctions(): array
 
             new ExpressionFunction('is_fully_authenticated', fn () => '$token && $auth_checker->isGranted("IS_AUTHENTICATED_FULLY")', fn (array $variables) => $variables['token'] && $variables['auth_checker']->isGranted('IS_AUTHENTICATED_FULLY')),
 
-            new ExpressionFunction('is_granted', fn ($attributes, $object = 'null') => sprintf('$auth_checker->isGranted(%s, %s)', $attributes, $object), fn (array $variables, $attributes, $object = null) => $variables['auth_checker']->isGranted($attributes, $object)),
+            new ExpressionFunction('is_granted', fn ($attributes, $object = 'null') => \sprintf('$auth_checker->isGranted(%s, %s)', $attributes, $object), fn (array $variables, $attributes, $object = null) => $variables['auth_checker']->isGranted($attributes, $object)),
 
             new ExpressionFunction('is_remember_me', fn () => '$token && $auth_checker->isGranted("IS_REMEMBERED")', fn (array $variables) => $variables['token'] && $variables['auth_checker']->isGranted('IS_REMEMBERED')),
         ];
diff --git a/Signature/SignatureHasher.php b/Signature/SignatureHasher.php
@@ -94,7 +94,7 @@ public function verifySignatureHash(UserInterface $user, int $expires, string $h
 
         if ($this->expiredSignaturesStorage && $this->maxUses) {
             if ($this->expiredSignaturesStorage->countUsages($hash) >= $this->maxUses) {
-                throw new ExpiredSignatureException(sprintf('Signature can only be used "%d" times.', $this->maxUses));
+                throw new ExpiredSignatureException(\sprintf('Signature can only be used "%d" times.', $this->maxUses));
             }
 
             $this->expiredSignaturesStorage->incrementUsages($hash);
@@ -118,7 +118,7 @@ public function computeSignatureHash(UserInterface $user, int $expires): string
             }
 
             if (!\is_scalar($value) && !$value instanceof \Stringable) {
-                throw new \InvalidArgumentException(sprintf('The property path "%s" on the user object "%s" must return a value that can be cast to a string, but "%s" was returned.', $property, $user::class, get_debug_type($value)));
+                throw new \InvalidArgumentException(\sprintf('The property path "%s" on the user object "%s" must return a value that can be cast to a string, but "%s" was returned.', $property, $user::class, get_debug_type($value)));
             }
             hash_update($fieldsHash, ':'.base64_encode($value));
         }
diff --git a/Tests/Authorization/AccessDecisionManagerTest.php b/Tests/Authorization/AccessDecisionManagerTest.php
@@ -39,7 +39,7 @@ public function testVoterCalls()
             $this->getUnexpectedVoter(),
         ];
 
-        $strategy = new class() implements AccessDecisionStrategyInterface {
+        $strategy = new class implements AccessDecisionStrategyInterface {
             public function decide(\Traversable $results): bool
             {
                 $i = 0;
diff --git a/Tests/Authorization/Voter/AuthenticatedVoterTest.php b/Tests/Authorization/Voter/AuthenticatedVoterTest.php
@@ -90,7 +90,7 @@ protected function getToken($authenticated)
         $user = new InMemoryUser('wouter', '', ['ROLE_USER']);
 
         if ('fully' === $authenticated) {
-            $token = new class() extends AbstractToken {
+            $token = new class extends AbstractToken {
                 public function getCredentials()
                 {
                 }
diff --git a/Tests/Authorization/Voter/VoterTest.php b/Tests/Authorization/Voter/VoterTest.php
@@ -41,7 +41,7 @@ public static function getTests(): array
 
             [$voter, ['DELETE'], VoterInterface::ACCESS_ABSTAIN, new \stdClass(), 'ACCESS_ABSTAIN if no attribute is supported'],
 
-            [$voter, ['EDIT'], VoterInterface::ACCESS_ABSTAIN, new class() {}, 'ACCESS_ABSTAIN if class is not supported'],
+            [$voter, ['EDIT'], VoterInterface::ACCESS_ABSTAIN, new class {}, 'ACCESS_ABSTAIN if class is not supported'],
 
             [$voter, ['EDIT'], VoterInterface::ACCESS_ABSTAIN, null, 'ACCESS_ABSTAIN if object is null'],
 
diff --git a/Tests/Resources/TranslationFilesTest.php b/Tests/Resources/TranslationFilesTest.php
@@ -26,7 +26,7 @@ public function testTranslationFileIsValid($filePath)
 
         $errors = XliffUtils::validateSchema($document);
 
-        $this->assertCount(0, $errors, sprintf('"%s" is invalid:%s', $filePath, \PHP_EOL.implode(\PHP_EOL, array_column($errors, 'message'))));
+        $this->assertCount(0, $errors, \sprintf('"%s" is invalid:%s', $filePath, \PHP_EOL.implode(\PHP_EOL, array_column($errors, 'message'))));
     }
 
     /**
@@ -39,7 +39,7 @@ public function testTranslationFileIsValidWithoutEntityLoader($filePath)
 
         $errors = XliffUtils::validateSchema($document);
 
-        $this->assertCount(0, $errors, sprintf('"%s" is invalid:%s', $filePath, \PHP_EOL.implode(\PHP_EOL, array_column($errors, 'message'))));
+        $this->assertCount(0, $errors, \sprintf('"%s" is invalid:%s', $filePath, \PHP_EOL.implode(\PHP_EOL, array_column($errors, 'message'))));
     }
 
     public static function provideTranslationFiles()
diff --git a/User/ChainUserProvider.php b/User/ChainUserProvider.php
@@ -66,7 +66,7 @@ public function loadUserByIdentifier(string $identifier): UserInterface
             }
         }
 
-        $ex = new UserNotFoundException(sprintf('There is no user with identifier "%s".', $identifier));
+        $ex = new UserNotFoundException(\sprintf('There is no user with identifier "%s".', $identifier));
         $ex->setUserIdentifier($identifier);
         throw $ex;
     }
@@ -92,11 +92,11 @@ public function refreshUser(UserInterface $user): UserInterface
 
         if ($supportedUserFound) {
             $username = $user->getUserIdentifier();
-            $e = new UserNotFoundException(sprintf('There is no user with name "%s".', $username));
+            $e = new UserNotFoundException(\sprintf('There is no user with name "%s".', $username));
             $e->setUserIdentifier($username);
             throw $e;
         } else {
-            throw new UnsupportedUserException(sprintf('There is no user provider for user "%s". Shouldn\'t the "supportsClass()" method of your user provider return true for this classname?', get_debug_type($user)));
+            throw new UnsupportedUserException(\sprintf('There is no user provider for user "%s". Shouldn\'t the "supportsClass()" method of your user provider return true for this classname?', get_debug_type($user)));
         }
     }
 
diff --git a/User/InMemoryUserProvider.php b/User/InMemoryUserProvider.php
@@ -80,7 +80,7 @@ public function loadUserByIdentifier(string $identifier): UserInterface
     public function refreshUser(UserInterface $user): UserInterface
     {
         if (!$user instanceof InMemoryUser) {
-            throw new UnsupportedUserException(sprintf('Instances of "%s" are not supported.', get_debug_type($user)));
+            throw new UnsupportedUserException(\sprintf('Instances of "%s" are not supported.', get_debug_type($user)));
         }
 
         $storedUser = $this->getUser($user->getUserIdentifier());
@@ -104,7 +104,7 @@ public function supportsClass(string $class): bool
     private function getUser(string $username): UserInterface
     {
         if (!isset($this->users[strtolower($username)])) {
-            $ex = new UserNotFoundException(sprintf('Username "%s" does not exist.', $username));
+            $ex = new UserNotFoundException(\sprintf('Username "%s" does not exist.', $username));
             $ex->setUserIdentifier($username);
 
             throw $ex;
diff --git a/User/MissingUserProvider.php b/User/MissingUserProvider.php
@@ -28,7 +28,7 @@ class MissingUserProvider implements UserProviderInterface
      */
     public function __construct(string $firewall)
     {
-        throw new InvalidConfigurationException(sprintf('"%s" firewall requires a user provider but none was defined.', $firewall));
+        throw new InvalidConfigurationException(\sprintf('"%s" firewall requires a user provider but none was defined.', $firewall));
     }
 
     public function loadUserByUsername(string $username): UserInterface
diff --git a/User/OidcUser.php b/User/OidcUser.php
@@ -45,7 +45,7 @@ public function __construct(
         private ?\DateTimeInterface $updatedAt = null,
 
         // Additional Claims (https://openid.net/specs/openid-connect-core-1_0.html#AdditionalClaims)
-        ...$additionalClaims
+        ...$additionalClaims,
     ) {
         if (null === $sub || '' === $sub) {
             throw new \InvalidArgumentException('The "sub" claim cannot be empty.');
diff --git a/Validator/Constraints/UserPasswordValidator.php b/Validator/Constraints/UserPasswordValidator.php
@@ -55,7 +55,7 @@ public function validate(mixed $password, Constraint $constraint)
         $user = $this->tokenStorage->getToken()->getUser();
 
         if (!$user instanceof PasswordAuthenticatedUserInterface) {
-            throw new ConstraintDefinitionException(sprintf('The "%s" class must implement the "%s" interface.', get_debug_type($user), PasswordAuthenticatedUserInterface::class));
+            throw new ConstraintDefinitionException(\sprintf('The "%s" class must implement the "%s" interface.', get_debug_type($user), PasswordAuthenticatedUserInterface::class));
         }
 
         $hasher = $this->hasherFactory->getPasswordHasher($user);

Original file line number	Diff line number	Diff line change
`@@ -134,7 +134,7 @@ public function hasAttribute(string $name): bool`
`134`	`134`	`public function getAttribute(string $name): mixed`
`135`	`135`	`{`
`136`	`136`	`if (!\array_key_exists($name, $this->attributes)) {`
`137`		`- throw new \InvalidArgumentException(sprintf('This token has no "%s" attribute.', $name));`
	`137`	`+ throw new \InvalidArgumentException(\sprintf('This token has no "%s" attribute.', $name));`
`138`	`138`	`}`
`139`	`139`
`140`	`140`	`return $this->attributes[$name];`
`@@ -158,7 +158,7 @@ public function __toString(): string`
`158`	`158`	`$roles[] = $role;`
`159`	`159`	`}`
`160`	`160`
`161`		`- return sprintf('%s(user="%s", roles="%s")', $class, $this->getUserIdentifier(), implode(', ', $roles));`
	`161`	`+ return \sprintf('%s(user="%s", roles="%s")', $class, $this->getUserIdentifier(), implode(', ', $roles));`
`162`	`162`	`}`
`163`	`163`
`164`	`164`	`/**`
Original file line number	Diff line number	Diff line change
`@@ -53,7 +53,7 @@ public function decide(TokenInterface $token, array $attributes, mixed $object =`
`53`	`53`	`{`
`54`	`54`	`// Special case for AccessListener, do not remove the right side of the condition before 6.0`
`55`	`55`	`if (\count($attributes) > 1 && !$allowMultipleAttributes) {`
`56`		`- throw new InvalidArgumentException(sprintf('Passing more than one Security attribute to "%s()" is not supported.', __METHOD__));`
	`56`	`+ throw new InvalidArgumentException(\sprintf('Passing more than one Security attribute to "%s()" is not supported.', __METHOD__));`
`57`	`57`	`}`
`58`	`58`
`59`	`59`	`return $this->strategy->decide(`
`@@ -69,7 +69,7 @@ private function collectResults(TokenInterface $token, array $attributes, mixed`
`69`	`69`	`foreach ($this->getVoters($attributes, $object) as $voter) {`
`70`	`70`	`$result = $voter->vote($token, $object, $attributes);`
`71`	`71`	`if (!\is_int($result) \|\| !(self::VALID_VOTES[$result] ?? false)) {`
`72`		`- throw new \LogicException(sprintf('"%s::vote()" must return one of "%s" constants ("ACCESS_GRANTED", "ACCESS_DENIED" or "ACCESS_ABSTAIN"), "%s" returned.', get_debug_type($voter), VoterInterface::class, var_export($result, true)));`
	`72`	`+ throw new \LogicException(\sprintf('"%s::vote()" must return one of "%s" constants ("ACCESS_GRANTED", "ACCESS_DENIED" or "ACCESS_ABSTAIN"), "%s" returned.', get_debug_type($voter), VoterInterface::class, var_export($result, true)));`
`73`	`73`	`}`
`74`	`74`
`75`	`75`	`yield $result;`
Original file line number	Diff line number	Diff line change
`@@ -30,7 +30,7 @@ class AuthorizationChecker implements AuthorizationCheckerInterface`
`30`	`30`	`public function __construct(TokenStorageInterface $tokenStorage, AccessDecisionManagerInterface $accessDecisionManager, bool $exceptionOnNoToken = false)`
`31`	`31`	`{`
`32`	`32`	`if ($exceptionOnNoToken) {`
`33`		`- throw new \LogicException(sprintf('Argument $exceptionOnNoToken of "%s()" must be set to "false".', __METHOD__));`
	`33`	`+ throw new \LogicException(\sprintf('Argument $exceptionOnNoToken of "%s()" must be set to "false".', __METHOD__));`
`34`	`34`	`}`
`35`	`35`
`36`	`36`	`$this->tokenStorage = $tokenStorage;`
Original file line number	Diff line number	Diff line change
`@@ -94,7 +94,7 @@ public function verifySignatureHash(UserInterface $user, int $expires, string $h`
`94`	`94`
`95`	`95`	`if ($this->expiredSignaturesStorage && $this->maxUses) {`
`96`	`96`	`if ($this->expiredSignaturesStorage->countUsages($hash) >= $this->maxUses) {`
`97`		`- throw new ExpiredSignatureException(sprintf('Signature can only be used "%d" times.', $this->maxUses));`
	`97`	`+ throw new ExpiredSignatureException(\sprintf('Signature can only be used "%d" times.', $this->maxUses));`
`98`	`98`	`}`
`99`	`99`
`100`	`100`	`$this->expiredSignaturesStorage->incrementUsages($hash);`
`@@ -118,7 +118,7 @@ public function computeSignatureHash(UserInterface $user, int $expires): string`
`118`	`118`	`}`
`119`	`119`
`120`	`120`	`if (!\is_scalar($value) && !$value instanceof \Stringable) {`
`121`		`- throw new \InvalidArgumentException(sprintf('The property path "%s" on the user object "%s" must return a value that can be cast to a string, but "%s" was returned.', $property, $user::class, get_debug_type($value)));`
	`121`	`+ throw new \InvalidArgumentException(\sprintf('The property path "%s" on the user object "%s" must return a value that can be cast to a string, but "%s" was returned.', $property, $user::class, get_debug_type($value)));`
`122`	`122`	`}`
`123`	`123`	`hash_update($fieldsHash, ':'.base64_encode($value));`
`124`	`124`	`}`
Original file line number	Diff line number	Diff line change
`@@ -39,7 +39,7 @@ public function testVoterCalls()`
`39`	`39`	`$this->getUnexpectedVoter(),`
`40`	`40`	`];`
`41`	`41`
`42`		`- $strategy = new class() implements AccessDecisionStrategyInterface {`
	`42`	`+ $strategy = new class implements AccessDecisionStrategyInterface {`
`43`	`43`	`public function decide(\Traversable $results): bool`
`44`	`44`	`{`
`45`	`45`	`$i = 0;`
Original file line number	Diff line number	Diff line change
`@@ -90,7 +90,7 @@ protected function getToken($authenticated)`
`90`	`90`	`$user = new InMemoryUser('wouter', '', ['ROLE_USER']);`
`91`	`91`
`92`	`92`	`if ('fully' === $authenticated) {`
`93`		`- $token = new class() extends AbstractToken {`
	`93`	`+ $token = new class extends AbstractToken {`
`94`	`94`	`public function getCredentials()`
`95`	`95`	`{`
`96`	`96`	`}`
Original file line number	Diff line number	Diff line change
`@@ -26,7 +26,7 @@ public function testTranslationFileIsValid($filePath)`
`26`	`26`
`27`	`27`	`$errors = XliffUtils::validateSchema($document);`
`28`	`28`
`29`		`- $this->assertCount(0, $errors, sprintf('"%s" is invalid:%s', $filePath, \PHP_EOL.implode(\PHP_EOL, array_column($errors, 'message'))));`
	`29`	`+ $this->assertCount(0, $errors, \sprintf('"%s" is invalid:%s', $filePath, \PHP_EOL.implode(\PHP_EOL, array_column($errors, 'message'))));`
`30`	`30`	`}`
`31`	`31`
`32`	`32`	`/**`
`@@ -39,7 +39,7 @@ public function testTranslationFileIsValidWithoutEntityLoader($filePath)`
`39`	`39`
`40`	`40`	`$errors = XliffUtils::validateSchema($document);`
`41`	`41`
`42`		`- $this->assertCount(0, $errors, sprintf('"%s" is invalid:%s', $filePath, \PHP_EOL.implode(\PHP_EOL, array_column($errors, 'message'))));`
	`42`	`+ $this->assertCount(0, $errors, \sprintf('"%s" is invalid:%s', $filePath, \PHP_EOL.implode(\PHP_EOL, array_column($errors, 'message'))));`
`43`	`43`	`}`
`44`	`44`
`45`	`45`	`public static function provideTranslationFiles()`