[Translation] Make the extractor alias optional

Author: zoliszabo

CHANGELOG.md

@@ -4,6 +4,7 @@ CHANGELOG
 7.4
 ---
 
+ * Make the extractor alias optional
  * Deprecate `TranslatableMessage::__toString`
  * Add `Symfony\Component\Translation\StaticMessage`
 

DependencyInjection/TranslationExtractorPass.php

@@ -13,7 +13,6 @@
 
 use Symfony\Component\DependencyInjection\Compiler\CompilerPassInterface;
 use Symfony\Component\DependencyInjection\ContainerBuilder;
-use Symfony\Component\DependencyInjection\Exception\RuntimeException;
 use Symfony\Component\DependencyInjection\Reference;
 
 /**
@@ -30,11 +29,7 @@ public function process(ContainerBuilder $container): void
         $definition = $container->getDefinition('translation.extractor');
 
         foreach ($container->findTaggedServiceIds('translation.extractor', true) as $id => $attributes) {
-            if (!isset($attributes[0]['alias'])) {
-                throw new RuntimeException(\sprintf('The alias for the tag "translation.extractor" of service "%s" must be set.', $id));
-            }
-
-            $definition->addMethodCall('addExtractor', [$attributes[0]['alias'], new Reference($id)]);
+            $definition->addMethodCall('addExtractor', [$attributes[0]['alias'] ?? $id, new Reference($id)]);
         }
     }
 }

Tests/DependencyInjection/TranslationExtractorPassTest.php

@@ -13,7 +13,6 @@
 
 use PHPUnit\Framework\TestCase;
 use Symfony\Component\DependencyInjection\ContainerBuilder;
-use Symfony\Component\DependencyInjection\Exception\RuntimeException;
 use Symfony\Component\DependencyInjection\Reference;
 use Symfony\Component\Translation\DependencyInjection\TranslationExtractorPass;
 
@@ -50,15 +49,13 @@ public function testProcessNoDefinitionFound()
     public function testProcessMissingAlias()
     {
         $container = new ContainerBuilder();
-        $container->register('translation.extractor');
+        $extractorDefinition = $container->register('translation.extractor');
         $container->register('foo.id')
             ->addTag('translation.extractor', []);
 
         $translationDumperPass = new TranslationExtractorPass();
-
-        $this->expectException(RuntimeException::class);
-        $this->expectExceptionMessage('The alias for the tag "translation.extractor" of service "foo.id" must be set.');
-
         $translationDumperPass->process($container);
+
+        $this->assertEquals([['addExtractor', ['foo.id', new Reference('foo.id')]]], $extractorDefinition->getMethodCalls());
     }
 }