do not use PHPUnit mock objects without configured expectations

Author: xabbuh

Test/CompoundConstraintTestCase.php

@@ -13,6 +13,7 @@
 
 use PHPUnit\Framework\ExpectationFailedException;
 use PHPUnit\Framework\TestCase;
+use Symfony\Component\Translation\IdentityTranslator;
 use Symfony\Component\Validator\Constraint;
 use Symfony\Component\Validator\Constraints\Compound;
 use Symfony\Component\Validator\Constraints\CompoundValidator;
@@ -21,7 +22,6 @@
 use Symfony\Component\Validator\Context\ExecutionContextInterface;
 use Symfony\Component\Validator\Validation;
 use Symfony\Component\Validator\Validator\ValidatorInterface;
-use Symfony\Contracts\Translation\TranslatorInterface;
 
 /**
  * A test case to ease testing Compound Constraints.
@@ -58,10 +58,7 @@ protected function createValidator(): ValidatorInterface
 
     protected function createContext(?ValidatorInterface $validator = null): ExecutionContextInterface
     {
-        $translator = $this->createMock(TranslatorInterface::class);
-        $translator->expects($this->any())->method('trans')->willReturnArgument(0);
-
-        return new ExecutionContext($validator ?? $this->createValidator(), $this->root, $translator);
+        return new ExecutionContext($validator ?? $this->createValidator(), $this->root, new IdentityTranslator());
     }
 
     public function assertViolationsRaisedByCompound(Constraint|array $constraints): void

Tests/Mapping/Loader/PropertyInfoLoaderTest.php

@@ -111,7 +111,7 @@ public function getTypes(string $class, string $property, array $context = []):
             }
         };
 
-        $propertyAccessExtractor = $this->createMock(PropertyAccessExtractorInterface::class);
+        $propertyAccessExtractor = $this->createStub(PropertyAccessExtractorInterface::class);
         $propertyAccessExtractor
             ->method('isWritable')
             ->willReturn(
@@ -247,7 +247,7 @@ public function getTypes(string $class, string $property, array $context = []):
             }
         };
 
-        $propertyAccessExtractor = $this->createMock(PropertyAccessExtractorInterface::class);
+        $propertyAccessExtractor = $this->createStub(PropertyAccessExtractorInterface::class);
 
         $propertyInfoLoader = new PropertyInfoLoader($propertyListExtractor, $propertyTypeExtractor, $propertyAccessExtractor, $classValidatorRegexp);
 
@@ -287,7 +287,7 @@ public function getTypes(string $class, string $property, array $context = []):
             };
         }
 
-        $propertyAccessExtractor = $this->createMock(PropertyAccessExtractorInterface::class);
+        $propertyAccessExtractor = $this->createStub(PropertyAccessExtractorInterface::class);
 
         $propertyInfoLoader = new PropertyInfoLoader($propertyListExtractor, $propertyTypeExtractor, $propertyAccessExtractor, '{.*}');
         $validator = Validation::createValidatorBuilder()