Merge pull request #41 from t3rr11/bugfix/fix-macos-updater-failing

Fix MacOS updater failing silently

Author: t3rr11

apps/electron/package.json

@@ -1,6 +1,6 @@
 {
   "name": "requesto-electron",
-  "version": "1.5.3",
+  "version": "1.5.4",
   "description": "Requesto - API Client",
   "homepage": "https://requesto.com.au",
   "main": "dist/main.js",

apps/electron/src/ipcHandlers.ts

@@ -1,4 +1,4 @@
-import { ipcMain, dialog, BrowserWindow } from 'electron';
+import { ipcMain, dialog, shell, BrowserWindow } from 'electron';
 import { autoUpdater } from 'electron-updater';
 import { SIMULATE_UPDATE_AVAILABLE } from './constants';
 import { state } from './state';
@@ -40,15 +40,43 @@ export function registerIpcHandlers(): void {
     return autoUpdater.downloadUpdate();
   });
 
-  ipcMain.handle('update:install', () => {
-    if (SIMULATE_UPDATE_AVAILABLE) return;
+  ipcMain.handle('update:install', async () => {
+    if (process.platform === 'darwin') {
+      // macOS requires code signing for silent in-place updates. Since this app
+      // is unsigned, quitAndInstall() will silently fail. Instead, show the user
+      // where the downloaded file is and direct them to install it manually.
+      const downloadedFile = state.downloadedUpdatePath;
+      const buttons = downloadedFile
+        ? ['Show in Finder', 'Open Releases Page', 'Cancel']
+        : ['Open Releases Page', 'Cancel'];
+
+      const { response } = await dialog.showMessageBox({
+        type: 'info',
+        title: 'Manual Installation Required',
+        message: 'Automatic updates require the app to be signed.',
+        detail: downloadedFile
+          ? 'The update has been downloaded. Open it in Finder, drag the new Requesto.app into your Applications folder, and relaunch.'
+          : 'Please download the latest version from the releases page and drag it into your Applications folder.',
+        buttons,
+        defaultId: 0,
+        cancelId: buttons.length - 1,
+      });
+
+      if (downloadedFile && response === 0) {
+        shell.showItemInFolder(downloadedFile);
+      } else if (response === (downloadedFile ? 1 : 0)) {
+        shell.openExternal('https://github.com/t3rr11/Requesto/releases/latest');
+      }
+      return;
+    }
+
     autoUpdater.quitAndInstall();
   });
 
   // OAuth: open a child BrowserWindow for the OAuth flow, intercept the redirect
   // back to our callback URL, and return the full callback URL to the renderer.
   ipcMain.handle('oauth:open-window', (_event, authUrl: string, callbackUrlPrefix: string): Promise<string | null> => {
-    return new Promise<string | null>((resolve) => {
+    return new Promise<string | null>(resolve => {
       const oauthWindow = new BrowserWindow({
         width: 520,
         height: 720,

apps/electron/src/main.ts

@@ -13,14 +13,14 @@ function setupAutoUpdater(): void {
   autoUpdater.autoDownload = false;
   autoUpdater.autoInstallOnAppQuit = false;
 
-  autoUpdater.on('update-available', (info) => {
+  autoUpdater.on('update-available', info => {
     state.mainWindow?.webContents.send('update:available', {
       version: info.version,
       releaseNotes: info.releaseNotes ?? null,
     });
   });
 
-  autoUpdater.on('download-progress', (progress) => {
+  autoUpdater.on('download-progress', progress => {
     state.mainWindow?.webContents.send('update:progress', {
       percent: progress.percent,
       bytesPerSecond: progress.bytesPerSecond,
@@ -29,11 +29,12 @@ function setupAutoUpdater(): void {
     });
   });
 
-  autoUpdater.on('update-downloaded', () => {
+  autoUpdater.on('update-downloaded', info => {
+    state.downloadedUpdatePath = info.downloadedFile ?? null;
     state.mainWindow?.webContents.send('update:downloaded');
   });
 
-  autoUpdater.on('error', (err) => {
+  autoUpdater.on('error', err => {
     state.mainWindow?.webContents.send('update:error', err.message);
   });
 }
@@ -84,7 +85,7 @@ app.whenReady().then(async () => {
         });
       }, 2000);
     } else {
-      autoUpdater.checkForUpdates().catch((err) => {
+      autoUpdater.checkForUpdates().catch(err => {
         console.error('Update check failed:', err);
       });
     }

apps/electron/src/state.ts

@@ -6,9 +6,11 @@ export const state: {
   splashWindow: BrowserWindow | null;
   backendProcess: ChildProcess | null;
   isQuitting: boolean;
+  downloadedUpdatePath: string | null;
 } = {
   mainWindow: null,
   splashWindow: null,
   backendProcess: null,
   isQuitting: false,
+  downloadedUpdatePath: null,
 };

apps/frontend/src/App.tsx

@@ -20,8 +20,22 @@ function App() {
   const { loadWorkspaces } = useWorkspaceStore();
   const { checkGit } = useGitStore();
   const { isDarkMode } = useThemeStore();
-  const { isOpen: alertOpen, title: alertTitle, message: alertMessage, variant: alertVariant, closeAlert } = useAlertStore();
-  const { dialogOpen: updateDialogOpen, setAvailable, setDownloading, setProgress, setDownloaded, setError, setDialogOpen } = useUpdateStore();
+  const {
+    isOpen: alertOpen,
+    title: alertTitle,
+    message: alertMessage,
+    variant: alertVariant,
+    closeAlert,
+  } = useAlertStore();
+  const {
+    dialogOpen: updateDialogOpen,
+    setAvailable,
+    setDownloading,
+    setProgress,
+    setDownloaded,
+    setError,
+    setDialogOpen,
+  } = useUpdateStore();
 
   useEffect(() => {
     loadWorkspaces().then(() => {
@@ -50,10 +64,19 @@ function App() {
   useEffect(() => {
     const api = window.electronAPI?.update;
     if (!api) return;
-    const unsubAvailable = api.onAvailable((info) => { setAvailable(info); setDialogOpen(true); });
-    const unsubProgress = api.onProgress((p) => { setDownloading(); setProgress(p); });
+    const unsubAvailable = api.onAvailable(info => {
+      setAvailable(info);
+      const dismissed = localStorage.getItem('update-dismissed-version');
+      if (dismissed !== info.version) {
+        setDialogOpen(true);
+      }
+    });
+    const unsubProgress = api.onProgress(p => {
+      setDownloading();
+      setProgress(p);
+    });
     const unsubDownloaded = api.onDownloaded(() => setDownloaded());
-    const unsubError = api.onError((msg) => setError(msg));
+    const unsubError = api.onError(msg => setError(msg));
     return () => {
       unsubAvailable();
       unsubProgress();

apps/frontend/src/components/UpdateDialog.tsx

@@ -15,6 +15,13 @@ function formatBytes(bytes: number): string {
 export function UpdateDialog({ isOpen, onClose }: UpdateDialogProps) {
   const { status, version, releaseNotes, progress, errorMessage, setDownloading, setError } = useUpdateStore();
 
+  function handleClose() {
+    if (status === 'available' && version) {
+      localStorage.setItem('update-dismissed-version', version);
+    }
+    onClose();
+  }
+
   async function handleDownload() {
     setDownloading();
     try {
@@ -30,21 +37,29 @@ export function UpdateDialog({ isOpen, onClose }: UpdateDialogProps) {
   }
 
   return (
-    <Dialog isOpen={isOpen} onClose={onClose} title="Update Available" size="sm">
+    <Dialog isOpen={isOpen} onClose={handleClose} title="Update Available" size="sm">
       {status === 'available' && (
         <>
           <p className="text-sm text-gray-600 dark:text-gray-300">
             Version <span className="font-semibold text-gray-900 dark:text-gray-100">{version}</span> is available.
           </p>
           {releaseNotes && (
             <div className="mt-3 p-3 bg-gray-50 dark:bg-gray-700/50 rounded-lg max-h-40 overflow-y-auto">
-              <p className="text-xs text-gray-500 dark:text-gray-400 font-medium uppercase tracking-wide mb-1">Release Notes</p>
-              <p className="text-sm text-gray-700 dark:text-gray-300 whitespace-pre-wrap">{releaseNotes}</p>
+              <p className="text-xs text-gray-500 dark:text-gray-400 font-medium uppercase tracking-wide mb-1">
+                Release Notes
+              </p>
+              <p className="text-sm text-gray-700 dark:text-gray-300 whitespace-pre-wrap">
+                {releaseNotes.replace(/<[^>]+>/g, '').trim()}
+              </p>
             </div>
           )}
           <div className="flex justify-end gap-2 mt-5">
-            <Button onClick={onClose} variant="secondary" size="md">Later</Button>
-            <Button onClick={handleDownload} variant="primary" size="md">Download Update</Button>
+            <Button onClick={handleClose} variant="secondary" size="md">
+              Later
+            </Button>
+            <Button onClick={handleDownload} variant="primary" size="md">
+              Download Update
+            </Button>
           </div>
         </>
       )}
@@ -60,23 +75,31 @@ export function UpdateDialog({ isOpen, onClose }: UpdateDialogProps) {
           </div>
           {progress && (
             <p className="text-xs text-gray-500 dark:text-gray-400 mt-2">
-              {formatBytes(progress.transferred)} / {formatBytes(progress.total)} &mdash; {formatBytes(progress.bytesPerSecond)}/s
+              {formatBytes(progress.transferred)} / {formatBytes(progress.total)} &mdash;{' '}
+              {formatBytes(progress.bytesPerSecond)}/s
             </p>
           )}
           <div className="flex justify-end mt-5">
-            <Button disabled variant="primary" size="md">Downloading…</Button>
+            <Button disabled variant="primary" size="md">
+              Downloading…
+            </Button>
           </div>
         </>
       )}
 
       {status === 'downloaded' && (
         <>
           <p className="text-sm text-gray-600 dark:text-gray-300">
-            Version <span className="font-semibold text-gray-900 dark:text-gray-100">{version}</span> is ready to install. The app will restart automatically.
+            Version <span className="font-semibold text-gray-900 dark:text-gray-100">{version}</span> is ready to
+            install. The app will restart automatically.
           </p>
           <div className="flex justify-end gap-2 mt-5">
-            <Button onClick={onClose} variant="secondary" size="md">Later</Button>
-            <Button onClick={handleInstall} variant="primary" size="md">Restart &amp; Install</Button>
+            <Button onClick={onClose} variant="secondary" size="md">
+              Later
+            </Button>
+            <Button onClick={handleInstall} variant="primary" size="md">
+              Restart &amp; Install
+            </Button>
           </div>
         </>
       )}
@@ -85,11 +108,17 @@ export function UpdateDialog({ isOpen, onClose }: UpdateDialogProps) {
         <>
           <p className="text-sm text-gray-600 dark:text-gray-300 mb-1">The update could not be downloaded.</p>
           {errorMessage && (
-            <p className="text-xs text-red-500 dark:text-red-400 bg-red-50 dark:bg-red-900/20 rounded p-2">{errorMessage}</p>
+            <p className="text-xs text-red-500 dark:text-red-400 bg-red-50 dark:bg-red-900/20 rounded p-2">
+              {errorMessage}
+            </p>
           )}
           <div className="flex justify-end gap-2 mt-5">
-            <Button onClick={onClose} variant="secondary" size="md">Close</Button>
-            <Button onClick={handleDownload} variant="primary" size="md">Retry</Button>
+            <Button onClick={onClose} variant="secondary" size="md">
+              Close
+            </Button>
+            <Button onClick={handleDownload} variant="primary" size="md">
+              Retry
+            </Button>
           </div>
         </>
       )}

package-lock.json

@@ -1,6 +1,6 @@
 {
   "name": "requesto",
-  "version": "1.5.3",
+  "version": "1.5.4",
   "author": "Matthew Allen",
   "description": "A lightweight, self-hosted API client",
   "private": true,