gdpr safe fake mobile and line line numbers

+ laravel lint cleanup

Author: tanthammar

composer.json

@@ -18,7 +18,7 @@
     ],
     "require": {
         "php": "^8.1|^8.2",
-        "brick/phonenumber": "^0.4.0",
+        "brick/phonenumber": "^0.6.0",
         "byrokrat/banking": "^2.2",
         "laravel/framework": "^9.0|^10.0",
         "personnummer/personnummer": "^3.0.4",

src/Factories/FakeMobileNumber.php

@@ -5,6 +5,7 @@
 /**
  * Swedish mobile number formats, while waiting for PR
  *
+ * @see https://fakerphp.github.io/locales/sv_SE/#fakerprovidersv_semobilenumber
  * @see https://github.com/FakerPHP/Faker/pull/491
  * @see https://www.pts.se/sv/bransch/telefoni/nummer-och-adressering/telefoninummerplanen/telefonnummers-struktur/
  */
@@ -38,4 +39,10 @@ public static function make(bool $international = true): string
 
         return self::numerify($val);
     }
+
+    /* Publishable GDPR Safe Swedish mobile number series */
+    public static function gdprSafe(): string
+    {
+        return '070-1740' . fake()->numberBetween(605, 699);
+    }
 }

src/Factories/FakePhoneNumber.php

@@ -4,6 +4,8 @@
 
 /**
  * Swedish phone number formats, both landline and mobile
+ *
+ * @see https://fakerphp.github.io/locales/sv_SE/#fakerprovidersv_sephonenumber
  */
 class FakePhoneNumber extends \Faker\Provider\PhoneNumber
 {
@@ -50,4 +52,15 @@ public static function make(bool $international = true): string
 
         return self::numerify($val);
     }
+
+    /* Publishable GDPR Safe Swedish landline phone number series */
+    public static function gdprSafe(): string
+    {
+        return fake()->randomElement([
+            '031-3900' . fake()->numberBetween(600, 699),
+            '040-6280' . fake()->numberBetween(400, 499),
+            '08-46500' . fake()->numberBetween(400, 499),
+            '0980-319' . fake()->numberBetween(200, 299),
+        ]);
+    }
 }

src/Helpers/BusinessTypeFromNr.php

@@ -9,7 +9,7 @@
 class BusinessTypeFromNr
 {
     /** returns 'business', 'individual' or 'undefined' */
-    public static function make(string|int $nr): string
+    public static function make(string | int $nr): string
     {
         if (filled($nr)) {
             if ((new PersonNummer)->passes(null, $nr)) {

src/LaravelRulesServiceProvider.php

@@ -59,7 +59,7 @@ public function bootingPackage(): void
     public function bootTranslations()
     {
         $name = $this->package->name;
-        $langPath = resource_path('lang/'.'vendor/'.$name);
+        $langPath = resource_path('lang/' . 'vendor/' . $name);
 
         $this->publishes([
             $this->package->basePath('/../resources/lang') => $langPath,

src/RuleHelpers.php

@@ -9,9 +9,6 @@
 class RuleHelpers
 {
     /**
-     * @param  string  $vatID
-     * @return string
-     *
      * @deprecated use BusinessNameFromVatID::lookup(string $vatID)
      */
     public static function getBusinessNameFromVatID(string $vatID): string
@@ -24,9 +21,6 @@ public static function getBusinessNameFromVatID(string $vatID): string
     }
 
     /**
-     * @param  string  $vatID
-     * @return object
-     *
      * @deprecated use VatDetailsFromVatID::lookup(string $vatID)
      */
     public static function getVATDetailsFromVatID(string $vatID): object
@@ -39,6 +33,7 @@ public static function getVATDetailsFromVatID(string $vatID): object
             'name' => '',
             'address' => '',
         ]);
+
         try {
             return VatCalculator::getVATDetails($vatID) ?? $empty;
         } catch (\Exception) {
@@ -47,12 +42,9 @@ public static function getVATDetailsFromVatID(string $vatID): object
     }
 
     /**
-     * @param  string|int  $nr
-     * @return string
-     *
      * @deprecated use BusinessTypeFromNr::make(string|int $nr)
      */
-    public static function check_business_type(string|int $nr): string
+    public static function check_business_type(string | int $nr): string
     {
         if (filled($nr)) {
             if ((new PersonNummer)->passes(null, $nr)) {

src/Rules/BankGiro.php

@@ -14,13 +14,13 @@ class BankGiro implements Rule
      *
      * @param  string  $attribute
      * @param  mixed  $value
-     * @return bool
      */
     public function passes($attribute, $value): bool
     {
         if (blank($value)) {
             return false;
         }
+
         try {
             return (new BankgiroFactory)->createAccount($value)->getBankName() === BankNames::BANK_BANKGIRO;
         } catch (Exception $e) {
@@ -30,8 +30,6 @@ public function passes($attribute, $value): bool
 
     /**
      * Get the validation error message.
-     *
-     * @return string
      */
     public function message(): string
     {

src/Rules/BankKonto.php

@@ -13,13 +13,13 @@ class BankKonto implements Rule
      *
      * @param  string  $attribute
      * @param  mixed  $value
-     * @return bool
      */
     public function passes($attribute, $value): bool
     {
         if (blank($value)) {
             return false;
         }
+
         try {
             return filled((new AccountFactory)->createAccount($value));
         } catch (Exception $e) {
@@ -29,8 +29,6 @@ public function passes($attribute, $value): bool
 
     /**
      * Get the validation error message.
-     *
-     * @return string
      */
     public function message(): string
     {

src/Rules/FixedLineNumber.php

@@ -15,16 +15,16 @@ class FixedLineNumber implements Rule
     /**
      * @param  string  $attribute
      * @param  mixed  $value
-     * @return bool
      */
     public function passes($attribute, $value): bool
     {
         if (blank($value)) {
             return false;
         }
+
         try {
             if (! str_starts_with($value, '+')) {
-                $value = '+'.$value;
+                $value = '+' . $value;
             }
             $number = Validator::parse((string) $value);
 

src/Rules/Latitude.php

@@ -20,8 +20,6 @@ public function passes($attribute, $value): bool
 
     /**
      * Get the validation error message.
-     *
-     * @return string
      */
     public function message(): string
     {