Turn on warnings during compilations, fix various issues.

Author: LTLA

include/tatami_python/sparse_matrix.hpp

@@ -93,7 +93,6 @@ void parse_Sparse2darray(const pybind11::object& matrix, Value_* const vbuffer,
     auto svt = raw_svt.template cast<pybind11::list>();
 
     const auto shape = get_shape<Index_>(matrix);
-    const auto NR = shape.first;
     const auto NC = shape.second;
 
     for (I<decltype(NC)> c = 0; c < NC; ++c) {

tests/lib/CMakeLists.txt

@@ -20,6 +20,7 @@ target_include_directories(tatami_python_test PRIVATE "../../build/_deps/tatami_
 target_include_directories(tatami_python_test PRIVATE "../../include")
 
 target_compile_definitions(tatami_python_test PRIVATE TEST_CUSTOM_PARALLEL=1)
+target_compile_options(tatami_python_test PRIVATE -Wall -Wpedantic -Wextra -Werror)
 
 set_property(TARGET tatami_python_test PROPERTY CXX_STANDARD 17)
 

tests/lib/src/bindings.cpp

@@ -152,7 +152,6 @@ pybind11::list dense_block(
     const std::int32_t len
 ) {
     auto ptr = reinterpret_cast<TestMatrix*>(ptr0);
-    const auto secondary = (!row ? ptr->nrow() : ptr->ncol());
     auto ext = create_extractor<false, oracle_>(*ptr, row, idx, first, len, true, true);
     const auto iptr = static_cast<const std::int32_t*>(idx.request().ptr);
     const std::size_t num = idx.size();
@@ -219,7 +218,6 @@ pybind11::list dense_indexed(
     const pybind11::array_t<std::int32_t>& subset
 ) {
     auto ptr = reinterpret_cast<TestMatrix*>(ptr0);
-    const auto secondary = (!row ? ptr->nrow() : ptr->ncol());
     auto ext = create_extractor<false, oracle_>(*ptr, row, idx, subset, true, true);
     const auto iptr = static_cast<const std::int32_t*>(idx.request().ptr);
     const std::size_t num = idx.size();
@@ -477,7 +475,7 @@ template<bool oracle_>
 pybind11::array_t<double> dense_sums(
     const std::uintptr_t ptr0,
     const bool row,
-    const std::int32_t num_threads
+    [[maybe_unused]] const std::int32_t num_threads
 ) {
     auto ptr = reinterpret_cast<TestMatrix*>(reinterpret_cast<void*>(ptr0));
     const auto primary = (row ? ptr->nrow() : ptr->ncol());
@@ -564,7 +562,7 @@ template<bool oracle_>
 pybind11::array_t<double> sparse_sums(
     const std::uintptr_t ptr0,
     const bool row,
-    const std::int32_t num_threads
+    [[maybe_unused]] const std::int32_t num_threads
 ) {
     auto ptr = reinterpret_cast<TestMatrix*>(reinterpret_cast<void*>(ptr0));
     const auto primary = (row ? ptr->nrow() : ptr->ncol());