PR feedback and minor fixes due to banning 'using' in switch case/default

rbuckton · rbuckton · commit f56e3f70266f · 2025-06-02T13:44:11.000-04:00
diff --git a/test/language/statements/using/syntax/block-scope-syntax-using-declarations-mixed-with-without-initializer.js b/test/language/statements/using/syntax/block-scope-syntax-using-declarations-mixed-with-without-initializer.js
@@ -2,9 +2,22 @@
 // This code is governed by the BSD license found in the LICENSE file.
 
 /*---
-esid: pending
+esid: sec-let-and-const-declarations-static-semantics-early-errors
 description: >
     using declarations mixed: with, without initializer
+info: |
+    Static Semantics : Early Errors
+      LexicalBinding : BindingIdentifier Initializer?
+
+      - It is a Syntax Error if Initializer is not present and IsConstantDeclaration of the LexicalDeclaration containing
+        this LexicalBinding is true.
+
+    Static Semantics : IsConstantDeclaration
+      UsingDeclaration :
+        `using` BindingList ;
+
+      1. Return true.
+
 negative:
   phase: parse
   type: SyntaxError
diff --git a/test/language/statements/using/syntax/block-scope-syntax-using-declarations-mixed-without-with-initializer.js b/test/language/statements/using/syntax/block-scope-syntax-using-declarations-mixed-without-with-initializer.js
@@ -2,9 +2,22 @@
 // This code is governed by the BSD license found in the LICENSE file.
 
 /*---
-esid: pending
+esid: sec-let-and-const-declarations-static-semantics-early-errors
 description: >
     using declarations mixed: without, with initializer
+info: |
+    Static Semantics : Early Errors
+      LexicalBinding : BindingIdentifier Initializer?
+
+      - It is a Syntax Error if Initializer is not present and IsConstantDeclaration of the LexicalDeclaration containing
+        this LexicalBinding is true.
+
+    Static Semantics : IsConstantDeclaration
+      UsingDeclaration :
+        `using` BindingList ;
+
+      1. Return true.
+
 negative:
   phase: parse
   type: SyntaxError
diff --git a/test/language/statements/using/syntax/block-scope-syntax-using-declarations-without-initializer.js b/test/language/statements/using/syntax/block-scope-syntax-using-declarations-without-initializer.js
@@ -2,9 +2,22 @@
 // This code is governed by the BSD license found in the LICENSE file.
 
 /*---
-esid: pending
+esid: sec-let-and-const-declarations-static-semantics-early-errors
 description: >
     using declarations without initializer
+info: |
+    Static Semantics : Early Errors
+      LexicalBinding : BindingIdentifier Initializer?
+
+      - It is a Syntax Error if Initializer is not present and IsConstantDeclaration of the LexicalDeclaration containing
+        this LexicalBinding is true.
+
+    Static Semantics : IsConstantDeclaration
+      UsingDeclaration :
+        `using` BindingList ;
+
+      1. Return true.
+
 negative:
   phase: parse
   type: SyntaxError
diff --git a/test/language/statements/using/syntax/using-allowed-at-top-level-of-module.js b/test/language/statements/using/syntax/using-allowed-at-top-level-of-module.js
@@ -2,14 +2,14 @@
 // This code is governed by the BSD license found in the LICENSE file.
 
 /*---
-esid: pending
+esid: sec-let-const-using-and-await-using-declarations-static-semantics-early-errors
 description: >
     using declarations allowed at the top level of a module
 info: |
   UsingDeclaration : using BindingList ;
 
   - It is a Syntax Error if the goal symbol is Script and UsingDeclaration is not contained, either directly or 
-    indirectly, within a Block, CaseBlock, ForStatement, ForInOfStatement, FunctionBody, GeneratorBody, 
+    indirectly, within a Block, ForStatement, ForInOfStatement, FunctionBody, GeneratorBody, 
     AsyncGeneratorBody, AsyncFunctionBody, ClassStaticBlockBody, or ClassBody.
 
 flags: [module]
diff --git a/test/language/statements/using/syntax/using-allows-bindingidentifier.js b/test/language/statements/using/syntax/using-allows-bindingidentifier.js
@@ -2,7 +2,7 @@
 // This code is governed by the BSD license found in the LICENSE file.
 
 /*---
-esid: pending
+esid: sec-let-const-using-and-await-using-declarations
 description: >
     'using' allows BindingIdentifier in lexical bindings
 features: [explicit-resource-management]
diff --git a/test/language/statements/using/syntax/using-allows-multiple-bindings.js b/test/language/statements/using/syntax/using-allows-multiple-bindings.js
@@ -2,7 +2,7 @@
 // This code is governed by the BSD license found in the LICENSE file.
 
 /*---
-esid: pending
+esid: sec-let-const-using-and-await-using-declarations
 description: >
     'using' allows multiple lexical bindings
 features: [explicit-resource-management]
diff --git a/test/language/statements/using/syntax/using-declaring-let-split-across-two-lines.js b/test/language/statements/using/syntax/using-declaring-let-split-across-two-lines.js
@@ -2,7 +2,7 @@
 // This code is governed by the BSD license found in the LICENSE file.
 
 /*---
-esid: pending
+esid: sec-let-const-using-and-await-using-declarations
 description: >
     using: |using let| split across two lines is treated as two statements.
 info: |
diff --git a/test/language/statements/using/syntax/using-for-statement.js b/test/language/statements/using/syntax/using-for-statement.js
@@ -1,4 +1,4 @@
-// Copyright (C) 2011 the V8 project authors. All rights reserved.
+// Copyright (C) 2023 Ron Buckton. All rights reserved.
 // This code is governed by the BSD license found in the LICENSE file.
 /*---
 esid: sec-for-statement
diff --git a/test/language/statements/using/syntax/using-for-using-of-of.js b/test/language/statements/using/syntax/using-for-using-of-of.js
@@ -1,4 +1,4 @@
-// Copyright (C) 2011 the V8 project authors. All rights reserved.
+// Copyright (C) 2023 Ron Buckton. All rights reserved.
 // This code is governed by the BSD license found in the LICENSE file.
 /*---
 esid: sec-for-in-and-for-of-statements
diff --git a/test/language/statements/using/syntax/using-invalid-arraybindingpattern-after-bindingidentifier.js b/test/language/statements/using/syntax/using-invalid-arraybindingpattern-after-bindingidentifier.js
@@ -2,7 +2,7 @@
 // This code is governed by the BSD license found in the LICENSE file.
 
 /*---
-esid: pending
+esid: sec-let-const-using-and-await-using-declarations
 description: >
     'using' does not allow ArrayBindingPattern in lexical bindings, even after a valid lexical binding
 negative:
diff --git a/test/language/statements/using/syntax/using-invalid-arraybindingpattern-does-not-break-element-access.js b/test/language/statements/using/syntax/using-invalid-arraybindingpattern-does-not-break-element-access.js
@@ -2,7 +2,7 @@
 // This code is governed by the BSD license found in the LICENSE file.
 
 /*---
-esid: pending
+esid: sec-let-const-using-and-await-using-declarations
 description: >
     'using' does not break existing element access
 features: [explicit-resource-management]
diff --git a/test/language/statements/using/syntax/using-invalid-arraybindingpattern.js b/test/language/statements/using/syntax/using-invalid-arraybindingpattern.js
@@ -2,7 +2,7 @@
 // This code is governed by the BSD license found in the LICENSE file.
 
 /*---
-esid: pending
+esid: sec-let-const-using-and-await-using-declarations
 description: >
     'using' does not allow ArrayBindingPattern in lexical bindings
 negative:
diff --git a/test/language/statements/using/syntax/using-invalid-assignment-next-expression-for.js b/test/language/statements/using/syntax/using-invalid-assignment-next-expression-for.js
@@ -2,12 +2,13 @@
 // This code is governed by the BSD license found in the LICENSE file.
 
 /*---
-esid: pending
+esid: sec-declarative-environment-records-setmutablebinding-n-v-s
 description: >
-    using: invalid assignment in next expression
+    using: invalid assignment in next expression.  Since a `using` declaration introduces an immutable
+    binding, any attempt to change it results in a ReferenceError.
 features: [explicit-resource-management]
 ---*/
 
-assert.throws(TypeError, function() {
+assert.throws(ReferenceError, function() {
   for (using i = 0; i < 1; i++) {}
 });
diff --git a/test/language/statements/using/syntax/using-invalid-assignment-statement-body-for-of.js b/test/language/statements/using/syntax/using-invalid-assignment-statement-body-for-of.js
@@ -2,12 +2,13 @@
 // This code is governed by the BSD license found in the LICENSE file.
 
 /*---
-esid: pending
+esid: sec-declarative-environment-records-setmutablebinding-n-v-s
 description: >
-    using: invalid assignment in Statement body
+    using: invalid assignment in Statement body. Since a `using` declaration introduces an immutable
+    binding, any attempt to change it results in a ReferenceError.
 features: [explicit-resource-management]
 ---*/
 
-assert.throws(TypeError, function() {
+assert.throws(ReferenceError, function() {
   for (using x of [1, 2, 3]) { x++ }
 });
diff --git a/test/language/statements/using/syntax/using-invalid-for-in.js b/test/language/statements/using/syntax/using-invalid-for-in.js
@@ -1,4 +1,4 @@
-// Copyright (C) 2011 the V8 project authors. All rights reserved.
+// Copyright (C) 2023 Ron Buckton. All rights reserved.
 // This code is governed by the BSD license found in the LICENSE file.
 /*---
 esid: sec-for-in-and-for-of-statements
diff --git a/test/language/statements/using/syntax/using-invalid-objectbindingpattern-after-bindingidentifier.js b/test/language/statements/using/syntax/using-invalid-objectbindingpattern-after-bindingidentifier.js
@@ -2,7 +2,7 @@
 // This code is governed by the BSD license found in the LICENSE file.
 
 /*---
-esid: pending
+esid: sec-let-const-using-and-await-using-declarations
 description: >
     'using' does not allow ObjectBindingPattern in lexical bindings, even after a valid lexical binding
 negative:
diff --git a/test/language/statements/using/syntax/using-invalid-objectbindingpattern.js b/test/language/statements/using/syntax/using-invalid-objectbindingpattern.js
@@ -2,7 +2,7 @@
 // This code is governed by the BSD license found in the LICENSE file.
 
 /*---
-esid: pending
+esid: sec-let-const-using-and-await-using-declarations
 description: >
     'using' does not allow ObjectBindingPattern in lexical bindings
 negative:
diff --git a/test/language/statements/using/syntax/using-not-allowed-at-top-level-of-eval.js b/test/language/statements/using/syntax/using-not-allowed-at-top-level-of-eval.js
@@ -2,14 +2,14 @@
 // This code is governed by the BSD license found in the LICENSE file.
 
 /*---
-esid: pending
+esid: sec-let-const-using-and-await-using-declarations-static-semantics-early-errors
 description: >
-    using declarations not allowed at the top level of eval
+    using declarations not allowed at the top level of eval. Note that Eval parses text using the Script goal.
 info: |
   UsingDeclaration : using BindingList ;
 
   - It is a Syntax Error if the goal symbol is Script and UsingDeclaration is not contained, either directly or 
-    indirectly, within a Block, CaseBlock, ForStatement, ForInOfStatement, FunctionBody, GeneratorBody, 
+    indirectly, within a Block, ForStatement, ForInOfStatement, FunctionBody, GeneratorBody, 
     AsyncGeneratorBody, AsyncFunctionBody, ClassStaticBlockBody, or ClassBody.
 
 features: [explicit-resource-management]
diff --git a/test/language/statements/using/syntax/using-not-allowed-at-top-level-of-script.js b/test/language/statements/using/syntax/using-not-allowed-at-top-level-of-script.js
@@ -2,14 +2,14 @@
 // This code is governed by the BSD license found in the LICENSE file.
 
 /*---
-esid: pending
+esid:sec-let-const-using-and-await-using-declarations-static-semantics-early-errors
 description: >
     using declarations not allowed at the top level of a Script
 info: |
   UsingDeclaration : using BindingList ;
 
   - It is a Syntax Error if the goal symbol is Script and UsingDeclaration is not contained, either directly or 
-    indirectly, within a Block, CaseBlock, ForStatement, ForInOfStatement, FunctionBody, GeneratorBody, 
+    indirectly, within a Block, ForStatement, ForInOfStatement, FunctionBody, GeneratorBody, 
     AsyncGeneratorBody, AsyncFunctionBody, ClassStaticBlockBody, or ClassBody.
 
 negative:
diff --git a/test/language/statements/using/syntax/using-outer-inner-using-bindings.js b/test/language/statements/using/syntax/using-outer-inner-using-bindings.js
@@ -2,7 +2,7 @@
 // This code is governed by the BSD license found in the LICENSE file.
 
 /*---
-esid: pending
+esid: sec-runtime-semantics-fordeclarationbindinginstantiation
 description: >
     outer using binding unchanged by for-loop using binding
 features: [explicit-resource-management]
diff --git a/test/language/statements/using/syntax/using.js b/test/language/statements/using/syntax/using.js
@@ -2,7 +2,7 @@
 // This code is governed by the BSD license found in the LICENSE file.
 
 /*---
-esid: pending
+esid: sec-let-const-using-and-await-using-declarations
 description: >
     module and block scope using
 flags: [module]
diff --git a/test/language/statements/using/syntax/with-initializer-case-expression-statement-list.js b/test/language/statements/using/syntax/with-initializer-case-expression-statement-list.js
@@ -2,10 +2,18 @@
 // This code is governed by the BSD license found in the LICENSE file.
 
 /*---
-esid: pending
+esid: sec-let-const-using-and-await-using-declarations-static-semantics-early-errors
 description: >
     using declarations with initialisers in statement positions:
     case Expression : StatementList
+info: |
+  AwaitUsingDeclaration : CoverAwaitExpressionAndAwaitUsingDeclarationHead BindingList ;
+  - It is a Syntax Error if AwaitUsingDeclaration is contained directly within the StatementList of either a CaseClause or
+    DefaultClause.
+negative:
+  phase: parse
+  type: SyntaxError
 features: [explicit-resource-management]
 ---*/
+$DONOTEVALUATE();
 switch (true) { case true: using x = null; }
diff --git a/test/language/statements/using/syntax/with-initializer-default-statement-list.js b/test/language/statements/using/syntax/with-initializer-default-statement-list.js
@@ -2,10 +2,17 @@
 // This code is governed by the BSD license found in the LICENSE file.
 
 /*---
-esid: pending
+esid: sec-let-const-using-and-await-using-declarations-static-semantics-early-errors
 description: >
     using declarations with initialisers in statement positions:
     default : StatementList
+info: |
+  AwaitUsingDeclaration : CoverAwaitExpressionAndAwaitUsingDeclarationHead BindingList ;
+
+  - It is a Syntax Error if AwaitUsingDeclaration is contained directly within the StatementList of either a CaseClause or
+    DefaultClause.
+
 features: [explicit-resource-management]
 ---*/
+$DONOTEVALUATE();
 switch (true) { default: using x = null; }
diff --git a/test/language/statements/using/syntax/with-initializer-do-statement-while-expression.js b/test/language/statements/using/syntax/with-initializer-do-statement-while-expression.js
@@ -2,7 +2,7 @@
 // This code is governed by the BSD license found in the LICENSE file.
 
 /*---
-esid: pending
+esid: sec-do-while-statement
 description: >
     using declarations with initialisers in statement positions:
     do Statement while ( Expression )
diff --git a/test/language/statements/using/syntax/with-initializer-for-statement.js b/test/language/statements/using/syntax/with-initializer-for-statement.js
@@ -2,7 +2,7 @@
 // This code is governed by the BSD license found in the LICENSE file.
 
 /*---
-esid: pending
+esid: sec-for-statement
 description: >
     using declarations with initialisers in statement positions:
     for (;;) Statement
diff --git a/test/language/statements/using/syntax/with-initializer-if-expression-statement-else-statement.js b/test/language/statements/using/syntax/with-initializer-if-expression-statement-else-statement.js
@@ -2,7 +2,7 @@
 // This code is governed by the BSD license found in the LICENSE file.
 
 /*---
-esid: pending
+esid: sec-if-statement
 description: >
     using declarations with initialisers in statement positions:
     if ( Expression ) Statement else Statement
diff --git a/test/language/statements/using/syntax/with-initializer-if-expression-statement.js b/test/language/statements/using/syntax/with-initializer-if-expression-statement.js
@@ -2,7 +2,7 @@
 // This code is governed by the BSD license found in the LICENSE file.
 
 /*---
-esid: pending
+esid: sec-if-statement
 description: >
     using declarations with initialisers in statement positions:
     if ( Expression ) Statement
diff --git a/test/language/statements/using/syntax/with-initializer-label-statement.js b/test/language/statements/using/syntax/with-initializer-label-statement.js
@@ -2,7 +2,7 @@
 // This code is governed by the BSD license found in the LICENSE file.
 
 /*---
-esid: pending
+esid: sec-labelled-statements
 description: >
     using declarations with initialisers in statement positions:
     label: Statement
diff --git a/test/language/statements/using/syntax/with-initializer-while-expression-statement.js b/test/language/statements/using/syntax/with-initializer-while-expression-statement.js
@@ -2,7 +2,7 @@
 // This code is governed by the BSD license found in the LICENSE file.
 
 /*---
-esid: pending
+esid: sec-while-statement
 description: >
     using declarations with initialisers in statement positions:
     while ( Expression ) Statement
diff --git a/test/language/statements/using/syntax/without-initializer-case-expression-statement-list.js b/test/language/statements/using/syntax/without-initializer-case-expression-statement-list.js
diff --git a/test/language/statements/using/syntax/without-initializer-default-statement-list.js b/test/language/statements/using/syntax/without-initializer-default-statement-list.js
diff --git a/test/language/statements/using/syntax/without-initializer-do-statement-while-expression.js b/test/language/statements/using/syntax/without-initializer-do-statement-while-expression.js
diff --git a/test/language/statements/using/syntax/without-initializer-for-statement.js b/test/language/statements/using/syntax/without-initializer-for-statement.js
diff --git a/test/language/statements/using/syntax/without-initializer-if-expression-statement-else-statement.js b/test/language/statements/using/syntax/without-initializer-if-expression-statement-else-statement.js
diff --git a/test/language/statements/using/syntax/without-initializer-if-expression-statement.js b/test/language/statements/using/syntax/without-initializer-if-expression-statement.js
diff --git a/test/language/statements/using/syntax/without-initializer-label-statement.js b/test/language/statements/using/syntax/without-initializer-label-statement.js
diff --git a/test/language/statements/using/syntax/without-initializer-while-expression-statement.js b/test/language/statements/using/syntax/without-initializer-while-expression-statement.js

Original file line number	Diff line number	Diff line change
`@@ -1,4 +1,4 @@`
`1`		`-// Copyright (C) 2011 the V8 project authors. All rights reserved.`
	`1`	`+// Copyright (C) 2023 Ron Buckton. All rights reserved.`
`2`	`2`	`// This code is governed by the BSD license found in the LICENSE file.`
`3`	`3`	`/*---`
`4`	`4`	`esid: sec-for-statement`