Skip to content

Commit 0d78759

Browse files
authored
Merge pull request #114 from team-ppointer/hotfix/soft-delete
[hotfix] softdelete hibernate 6로 교체
2 parents b7ab32c + d0d8ee8 commit 0d78759

File tree

11 files changed

+16
-34
lines changed

11 files changed

+16
-34
lines changed

src/main/generated/com/moplus/moplus_server/domain/problem/service/mapper/ChildProblemMapperImpl.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@
1111

1212
@Generated(
1313
value = "org.mapstruct.ap.MappingProcessor",
14-
date = "2025-03-24T01:02:22+0900",
14+
date = "2025-03-30T15:17:55+0900",
1515
comments = "version: 1.6.3, compiler: javac, environment: Java 17.0.10 (JetBrains s.r.o.)"
1616
)
1717
@Component

src/main/generated/com/moplus/moplus_server/domain/problem/service/mapper/ProblemMapperImpl.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@
1515

1616
@Generated(
1717
value = "org.mapstruct.ap.MappingProcessor",
18-
date = "2025-03-24T01:02:22+0900",
18+
date = "2025-03-30T15:17:55+0900",
1919
comments = "version: 1.6.3, compiler: javac, environment: Java 17.0.10 (JetBrains s.r.o.)"
2020
)
2121
@Component

src/main/generated/com/moplus/moplus_server/domain/problemset/domain/QProblemSet.java

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -31,8 +31,6 @@ public class QProblemSet extends EntityPathBase<ProblemSet> {
3131

3232
public final NumberPath<Long> id = createNumber("id", Long.class);
3333

34-
public final BooleanPath isDeleted = createBoolean("isDeleted");
35-
3634
public final ListPath<Long, NumberPath<Long>> problemIds = this.<Long, NumberPath<Long>>createList("problemIds", Long.class, NumberPath.class, PathInits.DIRECT2);
3735

3836
public final QTitle title;

src/main/java/com/moplus/moplus_server/admin/publish/domain/Publish.java

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -13,9 +13,11 @@
1313
import lombok.Builder;
1414
import lombok.Getter;
1515
import lombok.NoArgsConstructor;
16+
import org.hibernate.annotations.SoftDelete;
1617

1718
@Getter
1819
@Entity
20+
@SoftDelete
1921
@NoArgsConstructor(access = AccessLevel.PROTECTED)
2022
public class Publish extends BaseEntity {
2123

src/main/java/com/moplus/moplus_server/domain/problem/domain/childProblem/ChildProblem.java

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -25,9 +25,11 @@
2525
import lombok.Getter;
2626
import lombok.NoArgsConstructor;
2727
import org.hibernate.annotations.BatchSize;
28+
import org.hibernate.annotations.SoftDelete;
2829

2930
@Getter
3031
@Entity
32+
@SoftDelete
3133
@NoArgsConstructor(access = AccessLevel.PROTECTED)
3234
public class ChildProblem extends BaseEntity {
3335

src/main/java/com/moplus/moplus_server/domain/problem/domain/problem/Problem.java

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -31,9 +31,11 @@
3131
import lombok.Builder;
3232
import lombok.Getter;
3333
import lombok.NoArgsConstructor;
34+
import org.hibernate.annotations.SoftDelete;
3435

3536
@Getter
3637
@Entity
38+
@SoftDelete
3739
@NoArgsConstructor(access = AccessLevel.PROTECTED)
3840
public class Problem extends BaseEntity {
3941

src/main/java/com/moplus/moplus_server/domain/problemset/domain/ProblemSet.java

Lines changed: 3 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -23,10 +23,12 @@
2323
import lombok.Builder;
2424
import lombok.Getter;
2525
import lombok.NoArgsConstructor;
26+
import org.hibernate.annotations.SoftDelete;
2627

2728
@Getter
2829
@Entity
2930
@NoArgsConstructor(access = AccessLevel.PROTECTED)
31+
@SoftDelete
3032
public class ProblemSet extends BaseEntity {
3133

3234
@Id
@@ -37,9 +39,6 @@ public class ProblemSet extends BaseEntity {
3739
@Embedded
3840
private Title title;
3941

40-
@Column(nullable = false)
41-
private boolean isDeleted;
42-
4342
@Enumerated(EnumType.STRING)
4443
@Column(nullable = false)
4544
private ProblemSetConfirmStatus confirmStatus;
@@ -53,7 +52,6 @@ public class ProblemSet extends BaseEntity {
5352
@Builder
5453
public ProblemSet(String title, List<Long> problemIds) {
5554
this.title = new Title(title);
56-
this.isDeleted = false;
5755
this.confirmStatus = ProblemSetConfirmStatus.NOT_CONFIRMED;
5856
this.problemIds = problemIds;
5957
}
@@ -69,10 +67,6 @@ public void updateProblemOrder(List<Long> newProblems) {
6967
this.problemIds = new ArrayList<>(newProblems);
7068
}
7169

72-
public void deleteProblemSet() {
73-
this.isDeleted = true;
74-
}
75-
7670
public void toggleConfirm(List<Problem> problems) {
7771
if (this.confirmStatus == ProblemSetConfirmStatus.NOT_CONFIRMED) {
7872
if (problems.isEmpty()) {
@@ -111,4 +105,5 @@ public boolean isProblemsChanged(List<Long> newProblems) {
111105
}
112106
return false;
113107
}
108+
114109
}

src/main/java/com/moplus/moplus_server/domain/problemset/repository/ProblemSetRepository.java

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,6 @@
33
import com.moplus.moplus_server.domain.problemset.domain.ProblemSet;
44
import com.moplus.moplus_server.domain.problemset.domain.ProblemSetConfirmStatus;
55
import com.moplus.moplus_server.global.error.exception.ErrorCode;
6-
import com.moplus.moplus_server.global.error.exception.InvalidValueException;
76
import com.moplus.moplus_server.global.error.exception.NotFoundException;
87
import org.springframework.data.jpa.repository.JpaRepository;
98

@@ -16,11 +15,6 @@ default ProblemSet findByIdElseThrow(Long problemSetId) {
1615
default void validatePublishableProblemSet(Long problemSetId) {
1716
ProblemSet problemSet = findByIdElseThrow(problemSetId);
1817

19-
//이거 soft delete 어노테이션으로 자동화 해야함(리팩토링 필요)
20-
if (problemSet.isDeleted()) {
21-
throw new InvalidValueException(ErrorCode.PROBLEM_SET_DELETED);
22-
}
23-
2418
if (!ProblemSetConfirmStatus.CONFIRMED.equals(problemSet.getConfirmStatus())) {
2519
throw new NotFoundException(ErrorCode.PROBLEM_SET_NOT_CONFIRMED);
2620
}

src/main/java/com/moplus/moplus_server/domain/problemset/service/ProblemSetDeleteService.java

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,6 @@ public class ProblemSetDeleteService {
1515
@Transactional
1616
public void deleteProblemSet(Long problemSetId) {
1717
ProblemSet problemSet = problemSetRepository.findByIdElseThrow(problemSetId);
18-
problemSet.deleteProblemSet();
1918
}
2019

2120
}

src/main/java/com/moplus/moplus_server/domain/problemset/service/ProblemSetGetService.java

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -10,8 +10,6 @@
1010
import com.moplus.moplus_server.domain.problemset.domain.ProblemSet;
1111
import com.moplus.moplus_server.domain.problemset.repository.ProblemSetRepository;
1212
import com.moplus.moplus_server.domain.publish.repository.PublishRepository;
13-
import com.moplus.moplus_server.global.error.exception.BusinessException;
14-
import com.moplus.moplus_server.global.error.exception.ErrorCode;
1513
import java.time.LocalDate;
1614
import java.util.ArrayList;
1715
import java.util.HashSet;
@@ -33,9 +31,7 @@ public class ProblemSetGetService {
3331
@Transactional(readOnly = true)
3432
public ProblemSetGetResponse getProblemSet(Long problemSetId) {
3533
ProblemSet problemSet = problemSetRepository.findByIdElseThrow(problemSetId);
36-
if (problemSet.isDeleted()) {
37-
throw new BusinessException(ErrorCode.DELETE_PROBLEM_SET_GET_ERROR);
38-
}
34+
3935
List<LocalDate> publishedDates = publishRepository.findByProblemSetId(problemSetId).stream()
4036
.map(Publish::getPublishedDate)
4137
.toList();

0 commit comments

Comments
 (0)