-
Notifications
You must be signed in to change notification settings - Fork 138
chore: migrate to PNPM #1793
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
chore: migrate to PNPM #1793
Changes from 9 commits
2ca5164
839c968
928bda1
c3e1157
da75713
4d43858
238f138
4bb73c4
12947b2
b8ee966
91f0690
29414fc
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -178,7 +178,7 @@ jobs: | |
| working-directory: ${{ runner.temp }} | ||
|
|
||
| - name: Compile code | ||
| run: npm run build -- --ignore @temporalio/core-bridge | ||
| run: pnpm run build --ignore @temporalio/core-bridge | ||
|
|
||
| - name: Publish to Verdaccio | ||
| run: node scripts/publish-to-verdaccio.js --registry-dir ${{ steps.tmp-dir.outputs.dir }}/npm-registry | ||
|
|
@@ -196,7 +196,7 @@ jobs: | |
| --headless &> ./devserver.log & | ||
|
|
||
| - name: Run Tests | ||
| run: npm run test | ||
| run: pnpm run test | ||
| env: | ||
| RUN_INTEGRATION_TESTS: true | ||
| REUSE_V8_CONTEXT: ${{ matrix.reuse-v8-context }} | ||
|
|
@@ -260,6 +260,7 @@ jobs: | |
|
|
||
| # End samples | ||
|
|
||
| # TODO: PNPM doesn't write logs to file by default | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I wouldn't mind just removing that step. |
||
| - name: Upload NPM logs | ||
| uses: actions/upload-artifact@v4 | ||
| if: failure() || cancelled() | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,6 +1,7 @@ | ||
| { | ||
| "version": "1.13.2", | ||
| "npmClient": "npm", | ||
| "npmClient": "pnpm", | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I'd expect the diff to show the previous line being deleted. Could it be that you duplicated the line rather than modify it? |
||
| "command": { | ||
| "publish": { | ||
| "message": "chore(release): Publish", | ||
|
|
@@ -11,4 +12,4 @@ | |
| } | ||
| }, | ||
| "$schema": "node_modules/lerna/schemas/lerna-schema.json" | ||
| } | ||
| } | ||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not 100% sure about this, but it seems reasonable to hope that
pnpmwill be more stable and not require this "retry 3 times" hack.