Support forwarding binary headers #3000
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description & motivation 💭
This PR adds support for forwarding binary gRPC headers (headers ending with
-binsuffix) from HTTP requests to gRPC metadata.Motivation:
Binary headers in gRPC are base64-encoded when transmitted over the wire, but must be stored as plain text in gRPC metadata. Previously, the header forwarding middleware would forward binary headers as-is (base64-encoded), which would cause double-encoding issues when the gRPC library re-encodes them for transmission.
Changes:
WithForwardHeadersto detect binary headers (those ending with-bin)Screenshots (if applicable) 📸
Design Considerations 🎨
Testing 🧪
How was this tested 👻
Steps for others to test: 🚶🏽♂️🚶🏽♀️
Checklists
Draft Checklist
Merge Checklist
Issue(s) closed
Docs
Any docs updates needed?