fix: correct usage of *_settings blocks within aws_dms_endpoint resource (#2)

* chore: fix typos and update image links to be accessible from registry

* chore: s3 task replication example is working successfully

* chore: update all settings blocks to match corrected format

Author: bryantbiggs

README.md

@@ -100,15 +100,15 @@ module "database_migration_service" {
 
 Within DMS you can have multiple combinations of resources depending on your use case. For example (not an exhaustive list of possible combinations):
 #### Simple
-  - One source endpdoint
+  - One source endpoint
   - One target/destination endpoint
   - One replication task
-  - Two event subcriptions
+  - Two event subscriptions
     - Replication instance event subscription
     - Replication task event subscriptions
 
 <p align="center">
-  <img src=".github/images/dms_simple.png" alt="DMS Simple" width="100%">
+  <img src="https://raw.githubusercontent.com/clowdhaus/terraform-aws-dms/main/.github/images/dms_simple.png" alt="DMS Simple" width="100%">
 </p>
 
 #### Multiple endpoints, multiple tasks
@@ -120,7 +120,7 @@ Within DMS you can have multiple combinations of resources depending on your use
     - Replication task event subscription for each task listed above
 
 <p align="center">
-  <img src=".github/images/dms_complex.png" alt="DMS Complex" width="100%">
+  <img src="https://raw.githubusercontent.com/clowdhaus/terraform-aws-dms/main/.github/images/dms_complex.png" alt="DMS Complex" width="100%">
 </p>
 
 In order to accommodate a flexible, multi-resource combinatorial module, keys and maps are used for cross-referencing resources created within the module.
@@ -199,7 +199,7 @@ Continuing the same lookup patter, to create event subscriptions, you simply ref
 Tasks are the "jobs" that perform the necessary actions of migrating from `source` to `target`, including any transformations and/or mappings of the data in transit. Tasks are largely controlled by [task settings](http://docs.aws.amazon.com/dms/latest/userguide/CHAP_Tasks.CustomizingTasks.TaskSettings.html) that are defined in a JSON document.
 
 <p align="center">
-  <img src=".github/images/replication_task.png" alt="Replication Task" width="100%">
+  <img src="https://raw.githubusercontent.com/clowdhaus/terraform-aws-dms/main/.github/images/replication_task.png" alt="Replication Task" width="100%">
 </p>
 
 #### [Example task settings JSON document](https://docs.aws.amazon.com/dms/latest/userguide/CHAP_Tasks.CustomizingTasks.TaskSettings.Saving.html):
@@ -325,7 +325,7 @@ No modules.
 | <a name="input_create"></a> [create](#input\_create) | Determines whether resources will be created | `bool` | `true` | no |
 | <a name="input_create_iam_roles"></a> [create\_iam\_roles](#input\_create\_iam\_roles) | Determines whether the required [DMS IAM resources](https://docs.aws.amazon.com/dms/latest/userguide/CHAP_Security.html#CHAP_Security.APIRole) will be created | `bool` | `true` | no |
 | <a name="input_create_repl_subnet_group"></a> [create\_repl\_subnet\_group](#input\_create\_repl\_subnet\_group) | Determines whether the replication subnet group will be created | `bool` | `true` | no |
-| <a name="input_endpoints"></a> [endpoints](#input\_endpoints) | Map of objects that define the endpoints to be created | `map(any)` | `{}` | no |
+| <a name="input_endpoints"></a> [endpoints](#input\_endpoints) | Map of objects that define the endpoints to be created | `any` | `{}` | no |
 | <a name="input_event_subscription_timeouts"></a> [event\_subscription\_timeouts](#input\_event\_subscription\_timeouts) | A map of timeouts for event subscription create/update/delete operations | `map(string)` | `{}` | no |
 | <a name="input_event_subscriptions"></a> [event\_subscriptions](#input\_event\_subscriptions) | Map of objects that define the event subscriptions to be created | `any` | `{}` | no |
 | <a name="input_iam_role_permissions_boundary"></a> [iam\_role\_permissions\_boundary](#input\_iam\_role\_permissions\_boundary) | ARN of the policy that is used to set the permissions boundary for the role | `string` | `null` | no |
@@ -350,7 +350,7 @@ No modules.
 | <a name="input_repl_subnet_group_name"></a> [repl\_subnet\_group\_name](#input\_repl\_subnet\_group\_name) | The name for the replication subnet group. Stored as a lowercase string, must contain no more than 255 alphanumeric characters, periods, spaces, underscores, or hyphens | `string` | `null` | no |
 | <a name="input_repl_subnet_group_subnet_ids"></a> [repl\_subnet\_group\_subnet\_ids](#input\_repl\_subnet\_group\_subnet\_ids) | A list of the EC2 subnet IDs for the subnet group | `list(string)` | `[]` | no |
 | <a name="input_repl_subnet_group_tags"></a> [repl\_subnet\_group\_tags](#input\_repl\_subnet\_group\_tags) | A map of additional tags to apply to the replication subnet group | `map(string)` | `{}` | no |
-| <a name="input_replication_tasks"></a> [replication\_tasks](#input\_replication\_tasks) | Map of objects that define the replication tasks to be created | `map(any)` | `{}` | no |
+| <a name="input_replication_tasks"></a> [replication\_tasks](#input\_replication\_tasks) | Map of objects that define the replication tasks to be created | `any` | `{}` | no |
 | <a name="input_tags"></a> [tags](#input\_tags) | A map of tags to use on all resources | `map(string)` | `{}` | no |
 
 ## Outputs

examples/complete/README.md

@@ -34,7 +34,7 @@ Note that this example may create resources which will incur monetary charges on
 
 | Name | Version |
 |------|---------|
-| <a name="provider_aws"></a> [aws](#provider\_aws) | >= 3.55 |
+| <a name="provider_aws"></a> [aws](#provider\_aws) | 3.58.0 |
 
 ## Modules
 
@@ -44,6 +44,7 @@ Note that this example may create resources which will incur monetary charges on
 | <a name="module_dms_default"></a> [dms\_default](#module\_dms\_default) | ../.. | n/a |
 | <a name="module_dms_disabled"></a> [dms\_disabled](#module\_dms\_disabled) | ../.. | n/a |
 | <a name="module_rds_aurora"></a> [rds\_aurora](#module\_rds\_aurora) | terraform-aws-modules/rds-aurora/aws | ~> 5 |
+| <a name="module_s3_bucket"></a> [s3\_bucket](#module\_s3\_bucket) | terraform-aws-modules/s3-bucket/aws | ~> 2 |
 | <a name="module_security_group"></a> [security\_group](#module\_security\_group) | terraform-aws-modules/security-group/aws | ~> 4 |
 | <a name="module_vpc"></a> [vpc](#module\_vpc) | terraform-aws-modules/vpc/aws | ~> 3 |
 | <a name="module_vpc_endpoint_security_group"></a> [vpc\_endpoint\_security\_group](#module\_vpc\_endpoint\_security\_group) | terraform-aws-modules/security-group/aws | ~> 4 |
@@ -53,7 +54,12 @@ Note that this example may create resources which will incur monetary charges on
 
 | Name | Type |
 |------|------|
+| [aws_iam_role.s3_role](https://registry.terraform.io/providers/hashicorp/aws/latest/docs/resources/iam_role) | resource |
+| [aws_rds_cluster_parameter_group.postgresql](https://registry.terraform.io/providers/hashicorp/aws/latest/docs/resources/rds_cluster_parameter_group) | resource |
+| [aws_s3_bucket_object.hr_data](https://registry.terraform.io/providers/hashicorp/aws/latest/docs/resources/s3_bucket_object) | resource |
 | [aws_sns_topic.example](https://registry.terraform.io/providers/hashicorp/aws/latest/docs/resources/sns_topic) | resource |
+| [aws_caller_identity.current](https://registry.terraform.io/providers/hashicorp/aws/latest/docs/data-sources/caller_identity) | data source |
+| [aws_partition.current](https://registry.terraform.io/providers/hashicorp/aws/latest/docs/data-sources/partition) | data source |
 | [aws_region.current](https://registry.terraform.io/providers/hashicorp/aws/latest/docs/data-sources/region) | data source |
 
 ## Inputs

examples/complete/configs/s3_table_definition.json

@@ -0,0 +1,35 @@
+{
+  "TableCount": "1",
+  "Tables": [{
+    "TableName": "employee",
+    "TablePath": "hr/employee/",
+    "TableOwner": "hr",
+    "TableColumns": [{
+        "ColumnName": "Id",
+        "ColumnType": "INT8",
+        "ColumnNullable": "false",
+        "ColumnIsPk": "true"
+      },
+      {
+        "ColumnName": "LastName",
+        "ColumnType": "STRING",
+        "ColumnLength": "20"
+      },
+      {
+        "ColumnName": "FirstName",
+        "ColumnType": "STRING",
+        "ColumnLength": "30"
+      },
+      {
+        "ColumnName": "HireDate",
+        "ColumnType": "DATETIME"
+      },
+      {
+        "ColumnName": "OfficeLocation",
+        "ColumnType": "STRING",
+        "ColumnLength": "20"
+      }
+    ],
+    "TableColumnsTotal": "5"
+  }]
+}

examples/complete/table_mappings.json renamed to examples/complete/configs/table_mappings.json

@@ -17,7 +17,7 @@
     "CommitRate": 10000
   },
   "Logging": {
-    "EnableLogging": false
+    "EnableLogging": true
   },
   "ControlTablesSettings": {
     "HistoryTimeslotInMinutes": 5,

examples/complete/task_settings.json renamed to examples/complete/configs/task_settings.json

@@ -0,0 +1,4 @@
+101,Smith,Bob,2014-06-04,New York
+102,Smith,Bob,2015-10-08,Los Angeles
+103,Smith,Bob,2017-03-13,Dallas
+104,Smith,Bob,2017-03-13,Dallas