fix: Replace deprecated aws_region data source name attribute #581
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…gion.current.region The name attribute of the aws_region data source has been deprecated in favor of the region attribute. This change updates the reference in the IRSA module to use the current recommended attribute. Signed-off-by: atilsensalduz <[email protected]>
…gion.current.region The name attribute of the aws_region data source has been deprecated in favor of the region attribute. This change updates the reference in the IRSA module to use the current recommended attribute. Signed-off-by: atilsensalduz <[email protected]>
…gion.current.region The name attribute of the aws_region data source has been deprecated in favor of the region attribute. This change updates the reference in the IRSA module to use the current recommended attribute. Signed-off-by: atilsensalduz <[email protected]>
…gion.current.region The name attribute of the aws_region data source has been deprecated in favor of the region attribute. This change updates the reference in the IRSA module to use the current recommended attribute. Signed-off-by: atilsensalduz <[email protected]>
…gion.current.region The name attribute of the aws_region data source has been deprecated in favor of the region attribute. This change updates the reference in the IRSA module to use the current recommended attribute. Signed-off-by: atilsensalduz <[email protected]>
…gion.current.region The name attribute of the aws_region data source has been deprecated in favor of the region attribute. This change updates the reference in the IRSA module to use the current recommended attribute. Signed-off-by: atilsensalduz <[email protected]>
…gion.current.region The name attribute of the aws_region data source has been deprecated in favor of the region attribute. This change updates the reference in the IRSA module to use the current recommended attribute. Signed-off-by: atilsensalduz <[email protected]>
…gion.current.region The name attribute of the aws_region data source has been deprecated in favor of the region attribute. This change updates the reference in the IRSA module to use the current recommended attribute. Signed-off-by: atilsensalduz <[email protected]>
…gion.current.region The name attribute of the aws_region data source has been deprecated in favor of the region attribute. This change updates the reference in the IRSA module to use the current recommended attribute. Signed-off-by: atilsensalduz <[email protected]>
…gion.current.region The name attribute of the aws_region data source has been deprecated in favor of the region attribute. This change updates the reference in the IRSA module to use the current recommended attribute. Signed-off-by: atilsensalduz <[email protected]>
…gion.current.region The name attribute of the aws_region data source has been deprecated in favor of the region attribute. This change updates the reference in the IRSA module to use the current recommended attribute. Signed-off-by: atilsensalduz <[email protected]>
…gion.current.region The name attribute of the aws_region data source has been deprecated in favor of the region attribute. This change updates the reference in the IRSA module to use the current recommended attribute. Signed-off-by: atilsensalduz <[email protected]>
…gion.current.region The name attribute of the aws_region data source has been deprecated in favor of the region attribute. This change updates the reference in the IRSA module to use the current recommended attribute. Signed-off-by: atilsensalduz <[email protected]>
|
I think theres a few more changes we'll want to make since its a breaking change. its on the list and we'll get to it soon |
2 tasks
|
thank you! @bryantbiggs I'm also interested in contributing to upgrades for the remaining modules. |
Merged
3 tasks
|
thank you but this upgrade cycle is a bit more involved for the modules hosted here - you can see more at #585 |
|
This issue has been resolved in version 6.0.0 🎉 |
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces the deprecated
data.aws_region.current.namewithdata.aws_region.current.regionin the IAM Role for Service Accounts EKS module.Description
modules/iam-role-for-service-accounts-eks/main.tfto use the non-deprecatedregionattribute instead ofnameMotivation and Context
The
nameattribute of theaws_regiondata source has been deprecated by the AWS provider. This change ensures compatibility with current and future versions of the AWS provider.https://registry.terraform.io/providers/hashicorp/aws/latest/docs/data-sources/region#name-1
fix: #574