Skip to content

Commit 823302f

Browse files
Copilotowilliams-tetrascienceCopilot
authored
fix: SW-2054 correct DataAppShell Storybook E2E test assertions for icon-only rail (#155)
Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: Oseer Williams (Small Fry) <265368733+owilliams-tetrascience@users.noreply.github.com> Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
1 parent e1bfb7d commit 823302f

2 files changed

Lines changed: 1 addition & 9 deletions

File tree

src/components/composed/DataAppShell/DataAppShell.stories.tsx

Lines changed: 1 addition & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -127,8 +127,6 @@ interface WorkflowStep {
127127
isActive?: boolean;
128128
disabled?: boolean;
129129
disabledReason?: string;
130-
inputCount?: number;
131-
outputCount?: number;
132130
onClick?: () => void;
133131
}
134132

@@ -346,7 +344,7 @@ const DefaultShell = ({ initialCollapsed = false }: { initialCollapsed?: boolean
346344
<Button
347345
variant="outline"
348346
size="sm"
349-
onClick={() => setActiveStepId(htsWorkflowSteps[activeStepIndex - 1].id)}
347+
onClick={() => setActiveStepId(steps[activeStepIndex - 1].id)}
350348
className="gap-1"
351349
>
352350
Back
@@ -715,17 +713,13 @@ const WorkflowInteractionShell = () => {
715713
icon: LayoutGrid,
716714
isActive: activeStepId === "step-a",
717715
onClick: () => setActiveStepId("step-a"),
718-
inputCount: 1000,
719-
outputCount: 800,
720716
},
721717
{
722718
id: "step-b",
723719
label: "Step Beta",
724720
icon: Filter,
725721
isActive: activeStepId === "step-b",
726722
onClick: () => setActiveStepId("step-b"),
727-
inputCount: 800,
728-
outputCount: 200,
729723
},
730724
{ id: "step-c", label: "Disabled", icon: Search, disabled: true, disabledReason: "Requires upstream data" },
731725
];

src/components/composed/DataAppShell/DataAppShell.tsx

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -174,8 +174,6 @@ function SidebarBody({
174174
<div
175175
className={cn(
176176
"shrink-0 flex",
177-
// Expanded: full-width header border. Collapsed: no full-width border —
178-
// a short centered divider (below) aligns under the icon column instead.
179177
compact ? "justify-center pt-1 pb-2" : "px-3 py-2.5 border-b border-sidebar-border"
180178
)}
181179
>

0 commit comments

Comments
 (0)