Merge pull request #6 from Lurivar/master

Fix for deleted product taxes

Author: zawaze

Config/module.xml

@@ -15,7 +15,7 @@
         <language>en_US</language>
         <language>fr_FR</language>
     </languages>
-    <version>2.3.1</version>
+    <version>2.3.2</version>
     <author>
         <name>Gilles Bourgeat</name>
         <email>gbourgeat@openstudio.fr</email>

Controller/CreditNoteController.php

@@ -749,11 +749,19 @@ protected function performOrderProducts(Form $formValidate, CreditNote $creditNo
                 ->setPriceWithTax($orderProductWithTax);
 
             if (null !== $pse = ProductSaleElementsQuery::create()->findOneById($orderProduct->getProductSaleElementsId())) {
-                $creditNoteDetail->setTaxRuleId(
-                    $pse->getProduct()->getTaxRuleId()
-                );
+                if ($pse->getProduct() === null) {
+                    $creditNoteDetail->setTaxRuleId(TaxRuleQuery::create()->findOneByIsDefault(true)->getId());
+                } else {
+                    $creditNoteDetail
+                        ->setTaxRuleId(
+                            $pse
+                                ->getProduct()
+                                ->getTaxRuleId()
+                        )
+                    ;
+                }
             }
-
+            
             $creditNote->addCreditNoteDetail(
                 $creditNoteDetail
             );