Skip to content

Commit 8b8d90a

Browse files
therefderekpierreMuhammad-Altabba
authored
Apply suggestions from code review
Co-authored-by: Derek Pierre <[email protected]> Co-authored-by: Muhammad Altabba <[email protected]>
1 parent 939f33d commit 8b8d90a

File tree

3 files changed

+4
-6
lines changed

3 files changed

+4
-6
lines changed

demos/README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,4 +3,4 @@
33
- [`taco-demo`](./taco-demo) - A demo of the `@nucypher/taco` library.
44
- [`taco-nft-demo`](./taco-nft-demo) - A demo an NFT-based condition using the
55
`@nucypher/taco` library.
6-
- [`taco-aa-signing`](./taco-aa-signing) - A demo showing TACo distributed signing with Account Abstraction wallets.
6+
- [`taco-aa-signing`](./taco-aa-signing) - A demo showing TACo distributed signing with MetaMask Delegation Toolkit Account Abstraction wallets.

demos/taco-aa-signing/package.json

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,11 +1,11 @@
11
{
22
"name": "taco-aa-signing-demo",
3-
"version": "0.0.0",
3+
"version": "0.1.0",
44
"description": "A demo showing TACo distributed signing with Account Abstraction wallets",
55
"private": true,
66
"author": "NuCypher <[email protected]>",
77
"scripts": {
8-
"check": "tsx --no-warnings src/index.ts --dry-run 2>/dev/null && echo '✓ Demo syntax check passed' || echo '✓ Demo syntax check passed'",
8+
"check": "tsx --no-warnings src/index.ts --dry-run 2>/dev/null && echo '✓ Demo syntax check passed'",
99
"start": "tsx src/index.ts",
1010
"dev": "tsx src/index.ts --debug",
1111
"type-check": "echo \"Note: Full type-check skipped due to viem/delegation-toolkit type incompatibilities\""

demos/taco-aa-signing/src/taco-account.ts

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@ import { toAccount } from 'viem/accounts';
44
/**
55
* Creates a minimal Viem Account that serves as a placeholder for the MetaMask Smart Account.
66
* This account is never actually used for signing - all real signing happens through the TACo network
7-
* via the separate signUserOpWithTaco function.
7+
* via the separate signUserOp function.
88
*
99
* @param cohortAddress - Address of a TACo cohort participant (used as the account address)
1010
* @returns A Viem Account with stub implementations
@@ -29,5 +29,3 @@ export function createViemTacoAccount(cohortAddress: Address) {
2929
});
3030
}
3131

32-
// Legacy alias - kept for backward compatibility if needed
33-
export const createTacoAccount = createViemTacoAccount;

0 commit comments

Comments
 (0)