Skip to content

tedge bridge test doesn't have the --show-all flag which makes it inconsistent with the tedge bridge inspect command #4121

@reubenmiller

Description

@reubenmiller

Describe the bug

tedge bridge test is still using the --debug instead of --show-all which makes it inconsistent with the tedge bridge inspect command.

See the Additional Context section for the full help output of the two commands.

To Reproduce

Just viewing the help of the two commands shows the inconsistency.

tedge bridge test --help

tedge bridge inspect --help

Expected behavior

  • tedge bridge test should have the --show-all flag
  • tedge bridge test should have the --debug flag where it just controls the logging level (as the standard used by all of the tedge commands)

Screenshots

Environment (please complete the following information):

  • OS [incl. version]: any
  • Hardware [incl. revision] any
  • System-Architecture [e.g. result of "uname -a"] any
  • thin-edge.io version [e.g. 0.1.0]: 2.0.0

Additional context

tedge bridge test

This shows it is missing the --show-all command. Currently the --debug command is being used for two purposes; to "show-all" rules, and to set the log-level to debug.

tedge bridge test --help
Tests where a specific MQTT topic would be forwarded by the bridge

Usage: tedge bridge test [OPTIONS] <CLOUD> <TOPIC>

Arguments:
  <CLOUD>
          The cloud or custom mapper to test (e.g. c8y, aws, az, or a custom mapper name)

  <TOPIC>
          The MQTT topic to test (local or remote, wildcards are not supported)

Options:
      --config-dir <CONFIG_DIR>
          [env: TEDGE_CONFIG_DIR, default: /etc/tedge]

      --profile <PROFILE>
          The cloud profile you wish to use

          [env: TEDGE_CLOUD_PROFILE]

      --debug
          Show skipped rules (e.g. due to unmet conditions or empty template loops)

      --log-level <LOG_LEVEL>
          Configures the logging level.

          One of error/warn/info/debug/trace. Logs with verbosity lower or equal to the selected level will be printed, i.e. warn prints ERROR and WARN logs and trace prints logs of all levels.

          Overrides `--debug`

  -h, --help
          Print help (see a summary with '-h')

tedge bridge inspect

# tedge bridge inspect --help
Shows the current bridge configuration

Usage: tedge bridge inspect [OPTIONS] <CLOUD>

Arguments:
  <CLOUD>
          The cloud or custom mapper to inspect (e.g. c8y, aws, az, or a custom mapper name)

Options:
      --config-dir <CONFIG_DIR>
          [env: TEDGE_CONFIG_DIR, default: /etc/tedge]

      --profile <PROFILE>
          The cloud profile you wish to use

          [env: TEDGE_CLOUD_PROFILE]

      --debug
          Turn-on the DEBUG log level.

          If off only reports ERROR, WARN, and INFO, if on also reports DEBUG

      --show-all
          Show skipped rules (e.g. due to unmet conditions or empty template loops)

      --log-level <LOG_LEVEL>
          Configures the logging level.

          One of error/warn/info/debug/trace. Logs with verbosity lower or equal to the selected level will be printed, i.e. warn prints ERROR and WARN logs and trace prints logs of all levels.

          Overrides `--debug`

  -h, --help
          Print help (see a summary with '-h')

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't workingtheme:cliTheme: cli related topics

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions