[navigation][fix] Record references to macros inside macro body definitions

When parsing a macro definition like `#define OUTER(x) INNER(x)`, the
reference to INNER was not being recorded. References were only recorded
during macro expansion, which meant navigation couldn't find them if the
outer macro was never expanded during the current parsing session.

Now `processDefineDirective` checks if identifiers in the macro body are
known macros and records references for them. This enables navigation
from a macro definition to find all references, including those inside
other macro definitions.

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>

Author: thoni56

src/yylex.c

@@ -1037,6 +1037,13 @@ protected void processDefineDirective(bool hasArguments) {
                     completionPositionFound = true;
                     completionStringInMacroBody = symbol->linkName;
                 }
+                /* Record reference if identifier is a known macro */
+                if (lexem == IDENTIFIER) {
+                    Symbol *referencedMacro = findMacroSymbol(currentLexemStart);
+                    if (referencedMacro != NULL) {
+                        handleFoundSymbolReference(referencedMacro, position, UsageUsed, NO_FILE_NUMBER);
+                    }
+                }
                 putLexemCodeAndAdvance(lexem, &lexemDestination);
                 /* Copy from input to destination (which is in the body buffer...) */
                 for (; currentLexemStart<currentInput.read; lexemDestination++,currentLexemStart++)

tests/test_macro_stdint/expected

@@ -25,5 +25,8 @@ UINT8_MAX
     @source.c:23:9
 __INT64_C
     @source.c:2:10
+    @source.c:15:22
+    @source.c:20:21
 __UINT64_C
     @source.c:3:10
+    @source.c:26:22

tests/test_navigation_macro_to_macro_reference/Makefile

@@ -0,0 +1,20 @@
+include ../Makefile.server
+
+# Test that NEXT finds references to a macro inside another macro's definition.
+# INNER_MACRO is defined on line 5, and used inside OUTER_MACRO on line 8.
+# PUSH on INNER_MACRO should find the definition, NEXT should find the usage
+# inside OUTER_MACRO's body.
+
+$(TEST):
+	$(CXREF_PROGRAM) -p $(CURDIR) -create > /dev/null
+	sleep 2
+# Create preload files for source files (simulating Emacs buffers)
+	cp macros.h macros.preload
+	@$(SERVER_DRIVER) $(EXTRA) commands.input > output.tmp
+	@$(NORMALIZE) output.tmp > output
+	$(VERIFY)
+
+trace: EXTRA = --extra '-debug -log=trace'
+trace: $(TEST)
+
+GDB_COMMANDS =

tests/test_navigation_macro_to_macro_reference/commands.input

@@ -0,0 +1,8 @@
+CXREF -xrefactory-II -server
+-olcxgetprojectname CURDIR/macros.h
+<sync>
+-olcxpush -preload CURDIR/macros.h CURDIR/macros.preload -olcursor=79 CURDIR/macros.h -p CURDIR
+<sync>
+-olcxnext -preload CURDIR/macros.h CURDIR/macros.preload -olcursor=79 CURDIR/macros.h -p CURDIR
+<sync>
+<exit>

tests/test_navigation_macro_to_macro_reference/expected

@@ -0,0 +1,23 @@
+CXREF -xrefactory-II -server -o server-buffer
+-olcxgetprojectname CURDIR/macros.h
+end-of-options
+
+<sync>
+<set-info len=<n>>test_navigation_macro_to_macro_reference</set-info>
+-olcxpush -preload CURDIR/macros.h CURDIR/macros.preload -olcursor=79 CURDIR/macros.h -p CURDIR
+end-of-options
+
+<sync>
+<goto>
+ <position-lc line=5 col=8 len=<n>>CURDIR/macros.h</position-lc>
+</goto>
+-olcxnext -preload CURDIR/macros.h CURDIR/macros.preload -olcursor=79 CURDIR/macros.h -p CURDIR
+end-of-options
+
+<sync>
+<goto>
+ <position-lc line=8 col=23 len=<n>>CURDIR/macros.h</position-lc>
+</goto>
+-exit
+end-of-options
+

tests/test_navigation_macro_to_macro_reference/macros.h

@@ -0,0 +1,10 @@
+#ifndef MACROS_H
+#define MACROS_H
+
+// First macro - we'll PUSH on this
+#define INNER_MACRO(x) ((x) + 1)
+
+// Second macro - uses INNER_MACRO, NEXT should find this reference
+#define OUTER_MACRO(y) INNER_MACRO(y)
+
+#endif

tests/test_navigation_macro_to_macro_reference/macros.preload

@@ -0,0 +1,10 @@
+#ifndef MACROS_H
+#define MACROS_H
+
+// First macro - we'll PUSH on this
+#define INNER_MACRO(x) ((x) + 1)
+
+// Second macro - uses INNER_MACRO, NEXT should find this reference
+#define OUTER_MACRO(y) INNER_MACRO(y)
+
+#endif

tests/test_navigation_macro_to_macro_reference/source.c

@@ -0,0 +1,6 @@
+#include "macros.h"
+
+int main() {
+    int result = OUTER_MACRO(5);
+    return result;
+}

tests/test_token_pasting_with_expansion/expected

@@ -6,6 +6,8 @@ EXPAND
 NUM
     @source.c:0:0
     @source.c:1:8
+    @source.c:2:27
+    @source.c:2:32
     @source.c:4:15
 NUM##NUM
     @source.c:2:31

tests/test_token_pasting_with_expansion_lhs/expected

@@ -6,6 +6,7 @@ EXPAND
 NUM
     @source.c:0:0
     @source.c:1:8
+    @source.c:2:27
     @source.c:4:19
 NUM##num
     @source.c:2:31