[completion][tests] Add a test for "Completion Goto Definition"

This exposed a bug which also was fixed

Author: thoni56

src/cxref.c

@@ -863,9 +863,16 @@ static void findAndGotoDefinition(ReferenceableItem *referenceable) {
     SessionStackEntry *top = sessionData.browsingStack.top;
     BrowserMenu menu = makeBrowserMenu(*referenceable, true, true, 0, UsageUsed, UsageNone,
                                        NO_POSITION);
+    top->hkSelectedSym = &menu;  // Needed for createSelectionMenu to find matching symbols
     top->menu = &menu;
-    ensureReferencesAreLoadedFor(referenceable->linkName);
+
+    // Load references from disk and associate with menu
+    scanReferencesToCreateMenu(referenceable->linkName);
+    mapOverReferenceableItemTable(putOnLineLoadedReferences);
+    recomputeSelectedReferenceable(top);
+
     orderRefsAndGotoDefinition(top);
+    top->hkSelectedSym = NULL;
     top->menu = NULL;
 
     // recover stack

tests/test_completion_goto_definition/Makefile

@@ -0,0 +1,12 @@
+include ../Makefile.server
+
+$(TEST): CXrefs
+	@$(SERVER_DRIVER) commands.input $(EXTRA) > output.tmp
+	@$(NORMALIZE) output.tmp > output
+	@$(VERIFY)
+
+trace: EXTRA = \'-debug\'
+trace: $(TEST)
+
+CXrefs: .c-xrefrc
+	@$(CXREF) src -create -o $(TEST).log

tests/test_completion_goto_definition/commands.input

@@ -0,0 +1,8 @@
+CXREF -xrefrc CURDIR/.c-xrefrc src/main.c -xrefactory-II -server -log=log.log -commandlog=commands.log
+-olcxgetprojectname -xrefrc CURDIR/.c-xrefrc CURDIR/src/main.c
+<sync>
+-olcxcomplet CURDIR/src/main.c -olcursor=243 -xrefrc CURDIR/.c-xrefrc -p CURDIR
+<sync>
+-olcxcgoto1 -xrefrc CURDIR/.c-xrefrc -p CURDIR
+<sync>
+<exit>

tests/test_completion_goto_definition/expected

@@ -0,0 +1,22 @@
+CXREF -xrefrc CURDIR/.c-xrefrc src/main.c -xrefactory-II -server -log=log.log -commandlog=commands.log -o server-buffer
+-olcxgetprojectname -xrefrc CURDIR/.c-xrefrc CURDIR/src/main.c
+end-of-options
+
+<sync>
+<set-info len=<n>>CURDIR</set-info>
+-olcxcomplet CURDIR/src/main.c -olcursor=243 -xrefrc CURDIR/.c-xrefrc -p CURDIR
+end-of-options
+
+<sync>
+<all-completions nofocus=0 len=<n>>my_global_first    :void my_global_first(int arg)
+my_global_second   :void my_global_second(void )</all-completions>
+-olcxcgoto1 -xrefrc CURDIR/.c-xrefrc -p CURDIR
+end-of-options
+
+<sync>
+<goto>
+<position-lc line=4 col=5 len=<n>>CURDIR/src/main.c</position-lc>
+</goto>
+-exit
+end-of-options
+

tests/test_completion_goto_definition/src/main.c

@@ -0,0 +1,14 @@
+#include "myheader.h"
+
+/* Definition of the global function */
+void my_global_first(int arg) {
+    int local_var = arg;
+}
+
+void my_global_second(void) {
+}
+
+void caller(void) {
+    /* Complete here to get menu with two options */
+    my_global_
+}

tests/test_completion_goto_definition/src/myheader.h

@@ -0,0 +1,8 @@
+#ifndef MYHEADER_H
+#define MYHEADER_H
+
+/* Global function declarations */
+void my_global_first(int arg);
+void my_global_second(void);
+
+#endif