Update bundler and factory_bot

Author: tiagopog

jsonapi-utils.gemspec

@@ -21,12 +21,12 @@ Gem::Specification.new do |spec|
 
   spec.add_runtime_dependency 'jsonapi-resources', '0.9.11'
 
-  spec.add_development_dependency 'bundler', '~> 2.0'
+  spec.add_development_dependency 'bundler', '>= 1.14'
   spec.add_development_dependency 'rake', '~> 12.3.3'
   spec.add_development_dependency 'rails', ENV['RAILS_VERSION'] || '~> 5.2.4'
   spec.add_development_dependency 'sqlite3', '~> 1.4'
   spec.add_development_dependency 'rspec-rails', '~> 3.9.0'
-  spec.add_development_dependency 'factory_girl', '~> 4.8'
+  spec.add_development_dependency 'factory_bot', '~> 5.1'
   spec.add_development_dependency 'smart_rspec', '~> 0.1.6'
   spec.add_development_dependency 'pry', '~> 0.12.2'
   spec.add_development_dependency 'pry-byebug'

spec/controllers/posts_controller_spec.rb

@@ -4,7 +4,7 @@
   include_context 'JSON API headers'
 
   before(:all) do
-    @post = FactoryGirl.create_list(:post, 3).first
+    @post = FactoryBot.create_list(:post, 3).first
   end
 
   before(:each) do

spec/controllers/users_controller_spec.rb

@@ -4,7 +4,7 @@
   include_context 'JSON API headers'
 
   before(:all) do
-    @user = FactoryGirl.create_list(:user, 3, :with_posts).first
+    @user = FactoryBot.create_list(:user, 3, :with_posts).first
   end
 
   before(:each) do

spec/features/page_count_spec.rb

@@ -34,7 +34,7 @@ def TestApp.draw_page_count_test_routes
 
   before(:all) do
     TestApp.draw_page_count_test_routes
-    FactoryGirl.create_list(:user, 3, :with_posts)
+    FactoryBot.create_list(:user, 3, :with_posts)
   end
 
   describe 'page count with a paged paginator' do

spec/features/record_count_spec.rb

@@ -56,7 +56,7 @@ def TestApp.draw_record_count_test_routes
 
   before(:all) do
     TestApp.draw_record_count_test_routes
-    FactoryGirl.create_list(:user, 3, :with_posts)
+    FactoryBot.create_list(:user, 3, :with_posts)
   end
 
   describe 'explicit count' do

spec/jsonapi/utils/support/pagination_spec.rb

@@ -6,7 +6,7 @@
   end
 
   before(:all) do
-    FactoryGirl.create_list(:user, 2)
+    FactoryBot.create_list(:user, 2)
   end
 
   let(:options) { {} }

spec/spec_helper.rb

@@ -1,10 +1,10 @@
 require 'smart_rspec'
-require 'factory_girl'
+require 'factory_bot'
 require 'support/helpers'
 
 RSpec.configure do |config|
-  config.include FactoryGirl::Syntax::Methods
   config.include Helpers::ResponseParser
+  config.include FactoryBot::Syntax::Methods
 
   config.define_derived_metadata do |meta|
     meta[:aggregate_failures] = true

spec/support/factories.rb

@@ -1,21 +1,9 @@
-require 'factory_girl'
+require 'factory_bot'
+require_relative './models'
 
-FactoryGirl.define do
-  factory :category, class: Category do
-    sequence(:title) { |n| "Title for Category #{n}" }
-  end
-
-  factory :post, class: Post do
-    association :author, factory: :user
-    category
-
-    sequence(:id) { |n| n }
-    sequence(:title) { |n| "Title for Post #{n}" }
-    sequence(:body) { |n| "Body for Post #{n}" }
-    content_type :article
-    hidden_field 'It\'s a hidden field!'
-  end
+# require 'byebug'; byebug
 
+FactoryBot.define do
   factory :user, class: User do
     sequence(:id) { |n| n }
     sequence(:first_name) { |n| "User##{n}" }
@@ -24,7 +12,7 @@
     after(:create) { |user| create(:profile, user: user) }
 
     trait :with_posts do
-      transient { post_count 3 }
+      transient { post_count { 3 } }
       after(:create) do |user, e|
         create_list(:post, e.post_count, author: user)
       end
@@ -37,4 +25,19 @@
     sequence(:nickname) { |n| "Nickname##{n}" }
     sequence(:location) { |n| "Location##{n}" }
   end
+
+  factory :post, class: Post do
+    association :author, factory: :user
+    category
+
+    sequence(:id) { |n| n }
+    sequence(:title) { |n| "Title for Post #{n}" }
+    sequence(:body) { |n| "Body for Post #{n}" }
+    content_type { :article }
+    hidden_field { 'It\'s a hidden field!' }
+  end
+
+  factory :category, class: Category do
+    sequence(:title) { |n| "Title for Category #{n}" }
+  end
 end