Skip to content

Commit 8e94e82

Browse files
committed
Use as.integer() from extension
1 parent 1ae4365 commit 8e94e82

File tree

3 files changed

+7
-2
lines changed

3 files changed

+7
-2
lines changed

R/aaa-meta.R

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,5 @@
11
# Overwritten in meta.R
2+
meta_ext_register <- function(...) {}
23
meta_rel_register <- function(...) {}
34
meta_rel_register_df <- function(...) {}
45
meta_rel_register_file <- function(...) {}

R/relational-duckdb.R

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,6 @@ duckplyr_macros <- c(
3838
# "as.Date" = '(x) AS strptime(x, \'%Y-%m-%d\')',
3939

4040
"grepl" = "(pattern, x) AS (CASE WHEN x IS NULL THEN FALSE ELSE regexp_matches(x, pattern) END)",
41-
"as.integer" = "(x) AS CAST(x AS int32)",
4241
"if_else" = "(test, yes, no) AS (CASE WHEN test THEN yes ELSE no END)",
4342
"|" = "(x, y) AS (x OR y)",
4443
"&" = "(x, y) AS (x AND y)",

R/relational.R

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -225,6 +225,7 @@ rel_translate <- function(
225225
"/" = "___divide",
226226
"log10" = "___log10",
227227
"log" = "___log",
228+
"as.integer" = "r_base::as.integer",
228229
NULL
229230
)
230231

@@ -263,6 +264,9 @@ rel_translate <- function(
263264

264265
if (name %in% names(aliases)) {
265266
name <- aliases[[name]]
267+
if (grepl("^r_base::", name)) {
268+
meta_ext_register()
269+
}
266270
}
267271
# name <- aliases[name] %|% name
268272

@@ -309,7 +313,8 @@ rel_translate <- function(
309313
)
310314

311315
if (name == "row_number") {
312-
fun <- relexpr_function("as.integer", list(fun))
316+
fun <- relexpr_function("r_base::as.integer", list(fun))
317+
meta_ext_register()
313318
}
314319
}
315320
fun

0 commit comments

Comments
 (0)