Replace custom auth middleware with default auth middleware and a custom redirect

Author: mattstauffer

app/Http/Middleware/Authenticate.php

@@ -2,11 +2,11 @@
 
 declare(strict_types=1);
 
-use App\Http\Middleware\Authenticate;
 use App\Providers\AppServiceProvider;
 use Illuminate\Foundation\Application;
 use Illuminate\Foundation\Configuration\Exceptions;
 use Illuminate\Foundation\Configuration\Middleware;
+use Illuminate\Http\Request;
 use KgBot\LaravelLocalization\LaravelLocalizationServiceProvider;
 
 return Application::configure(basePath: dirname(__DIR__))
@@ -23,11 +23,11 @@
     ->withMiddleware(function (Middleware $middleware) {
         $middleware->redirectUsersTo(AppServiceProvider::HOME);
 
-        $middleware->throttleApi();
+        $middleware->redirectGuestsTo(
+            fn (Request $request) => $request->expectsJson() ? null : route_wlocale('login'),
+        );
 
-        $middleware->alias([
-            'auth' => Authenticate::class,
-        ]);
+        $middleware->throttleApi();
     })
     ->withExceptions(function (Exceptions $exceptions) {
         //

bootstrap/app.php

@@ -9,6 +9,14 @@
 uses(TestCase::class);
 uses(RefreshDatabase::class);
 
+test('guests are redirected to the locale-prefixed login page', function () {
+    $this->get('/en/profile')->assertRedirect('/en/login');
+});
+
+test('guest json requests receive 401 instead of a redirect', function () {
+    $this->getJson('/en/profile')->assertUnauthorized();
+});
+
 test('user can log in', function () {
     $user = User::factory()->create();
 

tests/Feature/AuthTest.php

@@ -0,0 +1,23 @@
+<?php
+
+declare(strict_types=1);
+
+use Illuminate\Foundation\Testing\RefreshDatabase;
+use Tests\NovaTestCase;
+
+uses(NovaTestCase::class);
+uses(RefreshDatabase::class);
+
+test('guest json requests to nova api receive 401 instead of a url generation error', function () {
+    $this->getJson('/nova-api/users')->assertUnauthorized();
+});
+
+test('guest non-json requests to nova api do not throw a url generation error', function () {
+    // Regression: the framework's default guest redirect calls route('login')
+    // without the required {locale} parameter, causing a 500 in production.
+    $this->get('/nova-api/users')->assertUnauthorized();
+});
+
+test('guests requesting nova pages are redirected to the nova login page', function () {
+    $this->get('/nova')->assertRedirect('/nova/login');
+});