feat: automatically convert Vec into HashMap in histogram_opts! macro - #422
Closed
chad-codes wants to merge 2 commits into
Closed
chad-codes wants to merge 2 commits into
chad-codes wants to merge 2 commits into
Conversation
Signed-off-by: Chad Greenburg <cgreenburg93@gmail.com>
Member
|
Thanks for the PR! CI does not seem to like the proposed change, but I didn't look deeper into what's going on. On which toolchain version are you developing this? Does |
Signed-off-by: Chad Greenburg <cgreenburg93@gmail.com>
Author
|
Whoops, I had made the original commit directly from Github without cloning and testing. I've updated the tests and everything is working. This is a breaking change to existing functionality since |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I noticed that this happens in the
opts!macro already so I think it makes sense forhistogram_opts!to also do this.