Skip to content

Conversation

@ollz272
Copy link

@ollz272 ollz272 commented Sep 6, 2023

This would be useful for us to have for our own usage (We want to use the stats on average uptime/downtime to do some more analysis).

Let me know if anymore is needed.

@CLAassistant
Copy link

CLAassistant commented Sep 6, 2023

CLA assistant check
All committers have signed the CLA.

@syvb
Copy link
Member

syvb commented Sep 6, 2023

Please do cargo fmt so that we have consistent formatting - thanks!

@syvb syvb requested review from WireBaron and syvb September 6, 2023 18:27
@jonatas
Copy link
Contributor

jonatas commented Dec 15, 2023

Hi @ollz272, very good, I'm not a Rust dev here, but I'm an avid user of toolkit too 🤗

  1. can we add a few more tests just calling the functions and asserting the values?
  2. or at least add it on docs/test_caggs that could cover and exemplify.
  3. We also have this tests/update/heartbeat.md that could include some tests.

We still don't have the docs/heartbeat_agg which would be the right place to document it. Feel free to introduce the file if you think it makes sense.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants