Skip to content

ci: Run loom test in tokio-util #7536

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from
Closed

ci: Run loom test in tokio-util #7536

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
92df6a4
ci: add new CI rule for 'loom_cancelation_token' (fixes tokio-rs#7271)
pepedinho Aug 14, 2025
82ccb07
ci:remove --cfg loom flag to avoid conflicts during tests compilation
pepedinho Aug 15, 2025
422f56b
ci: gate net/fs/signal wrappers under cfg(not(loom))
pepedinho Aug 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 18 additions & 0 deletions .github/workflows/loom.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,3 +95,21 @@ jobs:
working-directory: tokio
env:
SCOPE: ${{ matrix.scope }}

loom-cancellation-token:
name: loom-cancellation-token
if: github.repository_owner == 'tokio-rs' && (contains(github.event.pull_request.labels.*.name, 'R-loom-sync-util') || (github.base_ref == null))
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v5
- name: Install Rust ${{ env.rust_stable }}
uses: dtolnay/rust-toolchain@master
with:
toolchain: ${{ env.rust_stable }}
- uses: Swatinem/rust-cache@v2
- name: Run CancellationToken Loom tests
run: |
LOOM_MAX_PREEMPTIONS=1 LOOM_MAX_BRANCHES=10000 \
RUSTFLAGS="-C debug_assertions --cfg loom --cfg tokio_unstable" \
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you clarify what you mean about not being able to apply --cfg loom? I see it right here.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

my bad, I removed it in my local tests, but I forgot to remove it in the CI, I will send a commit to fix that

cargo test --features full --test sync_cancellation_token -- --test-threads=1 --nocapture
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
cargo test --features full --test sync_cancellation_token -- --test-threads=1 --nocapture
cargo test --lib --release --features full -- --test-threads=1 --nocapture loom_cancellation_token

working-directory: tokio
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
working-directory: tokio
working-directory: tokio-util

Loading