You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
subscriber: fix leading comma with Pretty formatter (#1833)
## Motivation
PR #1661 introduced a regression with the `Pretty` formatter: the
`PrettyVisitor` type was [accidentally changed][1] from being
constructed with `is_empty: true` to being constructed with
`is_empty: false` This means that when visiting a set of span fields,
we emit a leading `, ` _before_ the first field, which looks quite bad.
## Solution
This branch changes it back, and now the output looks nice again. :)
### Before
```
2022-01-13T17:09:04.772411Z TRACE fmt_pretty::yak_shave: hello! I'm gonna shave a yak, excitement: "yay!"
at examples/examples/fmt/yak_shave.rs:16 on main
in fmt_pretty::yak_shave::shave with , yak: 2
in fmt_pretty::yak_shave::shaving_yaks with , yaks: 3
```
### After
```
2022-01-13T17:10:28.472525Z TRACE fmt_pretty::yak_shave: hello! I'm gonna shave a yak, excitement: "yay!"
at examples/examples/fmt/yak_shave.rs:16 on main
in fmt_pretty::yak_shave::shave with yak: 1
in fmt_pretty::yak_shave::shaving_yaks with yaks: 3,
```
Fixes: #1832
[1]: 937c5d7#diff-a27a4c3564a0c2f1b7af32be0f9eec25ddfbe8b4c2be8d74e84d874b919b393bR227
0 commit comments