Merge branch 'main' into tolk-docs

Author: verytactical

.github/workflows/bouncer.yml

@@ -5,11 +5,9 @@ env:
   # additions only
   MAX_ADDITIONS_FORKS: 500
   # on rare occasions maintainers need to edit a lot of things at once
-  MAX_ADDITIONS_DIRECT_BRANCHES: 800
+  MAX_ADDITIONS_DIRECT_BRANCHES: 1000
   # many target issues usually mean bigger pull requests
   MAX_ISSUES_PER_PR: 3
-  # the name of this workflow file wrapped in backticks
-  MSG_PREFIX: "`bouncer.yml`"
 
 on:
   pull_request_target: # do NOT use actions/checkout!
@@ -49,57 +47,6 @@ jobs:
         with:
           script: core.exportVariable('MAX_ADDITIONS', '${{ env.MAX_ADDITIONS_DIRECT_BRANCHES }}')
 
-      - name: Remove prior comments by their common prefix
-        if: github.event.action == 'synchronize'
-        uses: actions/github-script@f28e40c7f34bde8b3046d885e986cb6290c5673b # v7.1.0
-        with:
-          # This JavaScript code cannot be moved to a separate file because
-          # this workflow must NOT checkout the repository for security reasons
-          #
-          # The same note applies to all JS code in this file
-          script: |
-            await exec.exec('sleep 0.5s');
-            const comments = await github.rest.issues.listComments({
-              owner: context.repo.owner,
-              repo: context.repo.repo,
-              issue_number: context.payload.pull_request.number,
-            });
-            for (const comment of comments.data) {
-                await exec.exec('sleep 0.5s');
-                const isHidden = (await github.graphql(`
-                  query($nodeId: ID!) {
-                    node(id: $nodeId) {
-                      ... on IssueComment {
-                        isMinimized
-                      }
-                    }
-                  }
-                `, { nodeId: comment.node_id }))?.node?.isMinimized;
-                if (isHidden) { continue; }
-                if (
-                  comment.user.login === 'github-actions[bot]' &&
-                  comment.body.startsWith('${{ env.MSG_PREFIX }}')
-                ) {
-                  console.log('Comment node_id:', comment.node_id);
-                  await exec.exec('sleep 0.5s');
-                  console.log(await github.graphql(`
-                    mutation($subjectId: ID!) {
-                      minimizeComment(input: {
-                        subjectId: $subjectId,
-                        classifier: OUTDATED
-                      }) {
-                        minimizedComment {
-                          isMinimized
-                          minimizedReason
-                        }
-                      }
-                    }
-                  `, {
-                    subjectId: comment.node_id,
-                  }));
-                }
-              }
-
       - name: Check if a number of additions modulo filtered files is within the threshold
         id: stats
         uses: actions/github-script@f28e40c7f34bde8b3046d885e986cb6290c5673b # v7.1.0
@@ -121,9 +68,8 @@ jobs:
                   'ecosystem/api/toncenter/v3.yaml',
                   'ecosystem/api/toncenter/smc-index.json',
                   'tvm/instructions.mdx',
-                ].includes(f.filename) && !f.filename.endsWith('.py'),
+                ].includes(f.filename) && !f.filename.endsWith('.py') && !f.filename.startsWith('snippets'),
             );
-            // NOTE: consider looking for .changes
             const additions = filtered.reduce((acc, it) => acc + it.additions, 0);
             if (additions > maxAdditions) {
               core.setOutput('trigger', 'true');
@@ -142,7 +88,6 @@ jobs:
               repo: context.repo.repo,
               issue_number: context.payload.pull_request.number,
               body: [
-                '${{ env.MSG_PREFIX }}',
                 'Thank you for the contribution!',
                 [
                   'Unfortunately, it is too large, with over ${{ env.MAX_ADDITIONS }} added lines,',
@@ -154,7 +99,10 @@ jobs:
                   'reverting any unrelated changes, writing less, or approaching',
                   'the problem in the issue from a different angle.',
                 ].join(' '),
-                'I look forward to your next submissions. If you still intend to proceed as is, then you are at the mercy of the reviewers.',
+                [
+                  'I look forward to your next submissions.',
+                  'If you still intend to proceed as is, then you are at the mercy of the reviewers.',
+                ].join(' '),
               ].join('\n\n'),
             });
             process.exit(1);
@@ -164,25 +112,21 @@ jobs:
         uses: actions/github-script@f28e40c7f34bde8b3046d885e986cb6290c5673b # v7.1.0
         with:
           script: |
-            await exec.exec('sleep 0.5s');
-            await github.rest.issues.createComment({
-              owner: context.repo.owner,
-              repo: context.repo.repo,
-              issue_number: context.payload.pull_request.number,
-              body: [
-                '${{ env.MSG_PREFIX }}',
-                [
-                  'The most recent commit has made this PR go over ${{ env.MAX_ADDITIONS }} added lines.',
-                  'Please, decrease the size of this pull request or consider splitting it into several smaller requests.'
-                ].join(' '),
-                'Until then, the CI will be marked as failed.',
-              ].join('\n\n'),
-            });
+            core.setFailed([
+              [
+                'This pull request has gotten over ${{ env.MAX_ADDITIONS }} added lines,',
+                'which can be challenging to review and iterate on',
+                'Please, decrease the size of this PR or consider splitting it into several smaller requests.'
+              ].join(' '),
+              [
+                'Until then, the CI will be soft-marked as failed.',
+                'If you still intend to proceed as is, then you are at the mercy of the reviewers.',
+              ].join(' '),
+            ].join('\n\n'));
             process.exit(1);
 
   enforce-better-descriptions:
     name: "Title and description"
-    if: github.event.action == 'opened' || github.event.action == 'edited'
     runs-on: ubuntu-latest
     steps:
       # pr title check
@@ -192,7 +136,8 @@ jobs:
         with:
           script: |
             const title = context.payload.pull_request.title;
-            const pattern = /^(revert: )?(feat|fix|chore|refactor|test)(?:\/(feat|fix|chore|refactor|test))?!?(\(.+?\))?!?: [a-z].{1,200}/;
+            const types = 'feat|fix|chore|refactor|test';
+            const pattern = new RegExp(`^(revert: )?(${types})(?:\\/(${types}))?!?(\\([^\\)]+\\))?!?: [a-zA-Z].{1,200}`);
             const matches = title.match(pattern) !== null;
             if (!matches) {
               core.setFailed([
@@ -205,7 +150,7 @@ jobs:
 
       # pr close issue limits
       - name: "Check that there is no more than ${{ env.MAX_ISSUES_PER_PR }} linked issues"
-        if: ${{ !cancelled() }}
+        if: ${{ !cancelled() && github.event.pull_request.user.login != 'dependabot[bot]' }}
         uses: actions/github-script@f28e40c7f34bde8b3046d885e986cb6290c5673b # v7.1.0
         with:
           script: |

.github/workflows/linter.yml

@@ -46,7 +46,7 @@ jobs:
           files: |
             **.md
             **.mdx
-          separator: ":"
+          separator: " "
 
       - name: Check formatting of MDX and Markdown files
         id: check-fmt
@@ -55,7 +55,8 @@ jobs:
         uses: actions/github-script@f28e40c7f34bde8b3046d885e986cb6290c5673b # v7.1.0
         with:
           script: |
-            const files = (process.env.ALL_CHANGED_FILES ?? '').trim().split(':').filter(Boolean);
+            const files = (process.env.ALL_CHANGED_FILES ?? '')
+              .trim().split(' ').filter(Boolean).filter((it) => it.match(/\.mdx?$/) !== null);
             if (files.length === 0) {
               console.log('\nNo such files affected!');
               process.exit(0);
@@ -64,57 +65,52 @@ jobs:
             for (const file of files) {
               console.log(`- ${file}`);
             }
-            const filesQuoted = files.map((it) => '"' + it + '"');
             try {
-              await exec.exec('npm', ['run', 'check:fmt:some', '--', ...filesQuoted], {
+              await exec.exec('npm', ['run', 'check:fmt:some', '--', ...files], {
                 silent: true, // >/dev/null 2>&1
               });
             } catch (_) {
               // Comment right in the actions output
-              const filesJoined = filesQuoted.join(' ');
               console.log('\n\x1b[31mError:\x1b[0m Some files are not properly formatted!');
               console.log('1. Install necessary dependencies: \x1b[31mnpm ci\x1b[0m');
-              console.log(`2. Run this command to fix the issues: \x1b[31mnpm run fmt:some -- ${filesJoined}\x1b[0m`);
-
-              // Prepare a comment on the PR
-              const comment = [
-                'To fix the **formatting** issues:\n',
-                '1. Install necessary dependencises: `npm ci`',
-                '2. Then, run this command:',
-                '```shell',
-                `npm run fmt:some -- ${filesJoined}`,
-                '```',
-              ].join('\n');
-
-              // Set environment variable for subsequent steps
-              core.exportVariable('COMMENT', comment);
+              console.log(`2. Run this command to fix the issues: \x1b[31mnpm run fmt:some -- ${files.join(' ')}\x1b[0m`);
 
               // Rethrow the exit code of the failed formatting check
               core.setFailed('Some files are not properly formatted!');
               process.exit(1);
             }
 
       - name: Hide prior PR comments and issue a new one in case of failure
-        if: ${{ !cancelled() && github.event_name == 'pull_request' && github.event_name != 'pull_request_target' }}
+        if: |
+          (
+            !cancelled() &&
+            steps.changed-files.conclusion == 'success' &&
+            github.event_name == 'pull_request' &&
+            github.event_name != 'pull_request_target'
+          )
         env:
-          COMMENT: ${{ env.COMMENT }}
+          ALL_CHANGED_FILES: ${{ steps.changed-files.outputs.all_changed_files }}
           SUCCESS: ${{ steps.check-fmt.conclusion == 'failure' && 'false' || 'true' }}
         uses: actions/github-script@f28e40c7f34bde8b3046d885e986cb6290c5673b # v7.1.0
         with:
           script: |
             const { hidePriorCommentsWithPrefix, createComment } = await import('${{ github.workspace }}/.github/scripts/common.mjs');
             const success = JSON.parse(process.env.SUCCESS ?? 'false');
-            const rawCommentText = process.env.COMMENT ?? '';
-            if (!success && rawCommentText === '') {
-              console.log('There was a formatting error, but no comment was given, skipping...');
-              process.exit(0);
-            }
-            const prefix = rawCommentText.slice(1, 30);
+            const files = (process.env.ALL_CHANGED_FILES ?? '')
+              .trim().split(' ').filter(Boolean).filter((it) => it.match(/\.mdx?$/) !== null);
+            const comment = [
+              'To fix the **formatting** issues:\n',
+              '1. Install necessary dependencises: `npm ci`',
+              '2. Then, run this command:',
+              '```shell',
+              `npm run fmt:some -- ${files.join(' ')}`,
+              '```',
+            ].join('\n');
+            const prefix = comment.slice(0, 30);
             await hidePriorCommentsWithPrefix({ github, context, exec, prefix, resolved: success });
-            // Create a new comment in case of a new failure
+            // Create a new PR comment in case of a new failure
             if (!success) {
-              const body = rawCommentText.slice(1, -1).replace(/\\n/g, '\n');
-              await createComment({ github, context, exec, body });
+              await createComment({ github, context, exec, body: comment });
             }
 
   spell-check:

package-lock.json

@@ -38,7 +38,7 @@
     "unist-util-visit-parents": "^6.0.2"
   },
   "engines": {
-    "node": ">=20.0",
+    "node": ">=20.17",
     "npm": ">=9"
   },
   "packageManager": "[email protected]"