Hey everyone,
First of all: I love mlbserver, and I want to thank everyone involved in maintaining and contributing to it.
mlbserver already works well. There are no issues that need immediate attention. Sure, some dependencies are out of date, but it works and does what it is meant to do.
Initially, I only wanted to add a shortcut for condensed games and get a better understanding how mlbserver works.
But since I had some time on my hands, the scope of my changes for private use kept growing from week to week.
You can check out my branch here:
https://github.com/MothmanMK/mlbserver/tree/card-ux
I have been using it for a few weeks now, and it seems to work without any problems.
What has changed in my fork?
- Card design instead of tables
- Tooltips as expandable panels
- Mobile-friendly layout
- Shortcut to condensed games
- Separate CSS stylesheet
- Restructured options menu
- Some visual polish
So basically, these are mostly UX/UI changes, plus some restructuring of index.js.
The problem is: none of these changes are really necessary for mlbserver to work. And UX/UI changes are always a matter of opinion.
A lot of code has changed, and the commit history is not as helpful as it should be. I realize that reviewing this would take time, and I do not want to impose a large change set (nobody asked for) on tonywagner or anyone else.
But since @ghost64 spotted my branch, I thought I would put it up here for discussion.
Are these changes helpful to mlbserver?
Are there other changes that would be more useful to the project?
And if there are any questions in regard to the changes, I'm happy to give answers.
Hey everyone,
First of all: I love mlbserver, and I want to thank everyone involved in maintaining and contributing to it.
mlbserver already works well. There are no issues that need immediate attention. Sure, some dependencies are out of date, but it works and does what it is meant to do.
Initially, I only wanted to add a shortcut for condensed games and get a better understanding how mlbserver works.
But since I had some time on my hands, the scope of my changes for private use kept growing from week to week.
You can check out my branch here:
https://github.com/MothmanMK/mlbserver/tree/card-ux
I have been using it for a few weeks now, and it seems to work without any problems.
What has changed in my fork?
So basically, these are mostly UX/UI changes, plus some restructuring of index.js.
The problem is: none of these changes are really necessary for mlbserver to work. And UX/UI changes are always a matter of opinion.
A lot of code has changed, and the commit history is not as helpful as it should be. I realize that reviewing this would take time, and I do not want to impose a large change set (nobody asked for) on tonywagner or anyone else.
But since @ghost64 spotted my branch, I thought I would put it up here for discussion.
Are these changes helpful to mlbserver?
Are there other changes that would be more useful to the project?
And if there are any questions in regard to the changes, I'm happy to give answers.