Skip to content

Conversation

@dineshduggal
Copy link

Description

Fix Playwright Storybook test failure caused by OS-dependent shortcut naming.
Replaced hard-coded accessible name "Hide addons [⌥ A]" with a more reliable locator ("Hide addons [alt A]") so tests run consistently across environments.

Related issue(s)

Fixes #XXX (please replace with the actual issue number if one exists)

What kind of change does this PR introduce?

  • Bug fix (non-breaking change which fixes an issue)
  • New Feature (non-breaking change which adds functionality)
  • New Feature (BREAKING CHANGE which adds functionality)
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change?

  • Yes
  • No

If yes, please describe the impact and migration path for existing applications:
N/A

How has this been tested?

  • Ran Playwright tests locally on macOS and CI (Linux) — all tests pass.
  • Verified Storybook UI button is correctly found and clicked regardless of OS-specific shortcut label.

Screenshots (if appropriate):

Not applicable

The PR fulfils these requirements:

  • It's submitted to the main branch
  • Add refs #XXX or fixes #XXX to the related issue section if your PR refers to or fixes an issue.
  • My change requires no changes to the documentation.
  • I have added/adjusted tests to cover my changes.
  • "Allow edits from maintainers" is enabled.
  • I confirm I have read and agree to Tremor’s CONTRIBUTING.md and Apache License 2.0.

@vercel
Copy link

vercel bot commented Sep 27, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
tremor-storybook Ready Ready Preview Comment Sep 27, 2025 9:08pm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant