Skip to content

Commit 8fdbbeb

Browse files
authored
chore(helm): increase default clickhouse resources (#2635)
1 parent 255ea0a commit 8fdbbeb

File tree

4 files changed

+29
-29
lines changed

4 files changed

+29
-29
lines changed

hosting/k8s/helm/Chart.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@ apiVersion: v2
22
name: trigger
33
description: The official Trigger.dev Helm chart
44
type: application
5-
version: 4.0.4
5+
version: 4.0.5
66
appVersion: v4.0.4
77
home: https://trigger.dev
88
sources:

hosting/k8s/helm/README.md

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -656,14 +656,16 @@ helm upgrade --install trigger . \
656656
cpu: 250m
657657
memory: 512Mi
658658

659+
# ClickHouse can be very resource intensive, so we recommend setting limits and requests accordingly
660+
# Note: not doing this can cause OOM crashes which will cause issues across many different features
659661
clickhouse:
660662
resources:
661663
limits:
662-
cpu: 1000m
663-
memory: 2Gi
664+
cpu: 4000m
665+
memory: 16Gi
664666
requests:
665-
cpu: 500m
666-
memory: 1Gi
667+
cpu: 2000m
668+
memory: 8Gi
667669

668670
supervisor:
669671
resources:

hosting/k8s/helm/values-production-example.yaml

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -78,13 +78,15 @@ clickhouse:
7878
enabled: true
7979
size: 100Gi
8080
storageClass: "fast-ssd"
81+
# ClickHouse can be very resource intensive, so we recommend setting limits and requests accordingly
82+
# Note: not doing this can cause OOM crashes which will cause issues across many different
8183
resources:
8284
limits:
83-
cpu: 1000m
84-
memory: 2Gi
85+
cpu: 4000m
86+
memory: 16Gi
8587
requests:
86-
cpu: 500m
87-
memory: 1Gi
88+
cpu: 2000m
89+
memory: 8Gi
8890

8991
# Production S3-compatible object storage
9092
s3:

hosting/k8s/helm/values.yaml

Lines changed: 16 additions & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -110,8 +110,7 @@ webapp:
110110
defaultOrgExecutionConcurrencyLimit: 300
111111

112112
# Resources
113-
resources:
114-
{}
113+
resources: {}
115114
# Example resource configuration:
116115
# limits:
117116
# cpu: 1000m
@@ -125,8 +124,7 @@ webapp:
125124
postgres: true # Set to false to disable DATABASE_HOST env var (overrides postgres.external.connectivityCheck)
126125

127126
# Extra environment variables for webapp
128-
extraEnvVars:
129-
[]
127+
extraEnvVars: []
130128
# - name: CUSTOM_VAR
131129
# value: "custom-value"
132130
# - name: SECRET_VAR
@@ -140,8 +138,7 @@ webapp:
140138
# value: "/etc/ssl/certs/postgres-ca.crt"
141139

142140
# Extra volumes for the webapp pod
143-
extraVolumes:
144-
[]
141+
extraVolumes: []
145142
# - name: config-volume
146143
# configMap:
147144
# name: my-config
@@ -158,8 +155,7 @@ webapp:
158155
# path: postgres-ca.crt
159156

160157
# Extra volume mounts for the webapp container
161-
extraVolumeMounts:
162-
[]
158+
extraVolumeMounts: []
163159
# - name: config-volume
164160
# mountPath: /etc/config
165161
# readOnly: true
@@ -248,8 +244,7 @@ webapp:
248244
paths:
249245
- path: /
250246
pathType: Prefix
251-
tls:
252-
[]
247+
tls: []
253248
# - secretName: trigger-tls
254249
# hosts:
255250
# - trigger.local
@@ -322,8 +317,7 @@ supervisor:
322317
role:
323318
name: ""
324319
# Extra environment variables for Supervisor
325-
extraEnvVars:
326-
[]
320+
extraEnvVars: []
327321
# - name: CUSTOM_VAR
328322
# value: "custom-value"
329323

@@ -520,8 +514,7 @@ electric:
520514
url: "" # For example: "http://electric:3000"
521515

522516
# Extra environment variables for Electric
523-
extraEnvVars:
524-
[]
517+
extraEnvVars: []
525518
# - name: CUSTOM_VAR
526519
# value: "custom-value"
527520

@@ -553,6 +546,12 @@ clickhouse:
553546
persistence:
554547
enabled: true
555548
size: 10Gi
549+
550+
## ClickHouse resource requests and limits
551+
## ref: http://kubernetes.io/docs/concepts/configuration/manage-compute-resources-container/
552+
## @param resourcesPreset Set container resources according to one common preset (allowed values: none, nano, micro, small, medium, large, xlarge, 2xlarge). This is ignored if resources is set (resources is recommended for production).
553+
## More information: https://github.com/bitnami/charts/blob/main/bitnami/common/templates/_resources.tpl#L15
554+
resourcesPreset: "xlarge"
556555
resources: {}
557556

558557
# External ClickHouse connection (when deploy: false)
@@ -736,8 +735,7 @@ registry:
736735
successThreshold: 1
737736

738737
# Extra environment variables for Registry
739-
extraEnvVars:
740-
[]
738+
extraEnvVars: []
741739
# - name: CUSTOM_VAR
742740
# value: "custom-value"
743741

@@ -763,8 +761,7 @@ registry:
763761
paths:
764762
- path: /
765763
pathType: Prefix
766-
tls:
767-
[]
764+
tls: []
768765
# - secretName: registry-tls
769766
# hosts:
770767
# - registry.local
@@ -786,8 +783,7 @@ telemetry:
786783

787784
# Extra Kubernetes manifests
788785
# This allows you to add additional Kubernetes resources that will be deployed with the chart
789-
extraManifests:
790-
[]
786+
extraManifests: []
791787
# - apiVersion: v1
792788
# kind: ConfigMap
793789
# metadata:

0 commit comments

Comments
 (0)