Skip to content

Commit 92c349a

Browse files
committed
refactor: minor optimization
1 parent 1adc78b commit 92c349a

9 files changed

Lines changed: 26 additions & 67 deletions

File tree

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1 @@
1+
{"fetchedAt":"2026-01-11T01:28:51.680082400","rates":{"USD":"16860.0","EUR":"19628.0"}}

data/data-exchange/exchange_rates.json

Lines changed: 0 additions & 1 deletion
This file was deleted.

dokumentasi/release-helper.md

Lines changed: 18 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -53,8 +53,6 @@ Karena itu, properti seperti nama aplikasi, vendor, icon, dan shortcut **tidak d
5353
--icon "src/main/resources/app-icon/favicon.ico"
5454
--win-shortcut
5555
--win-menu
56-
57-
--win-console
5856
```
5957

6058
Atau berikut yang siap tempel di terminal (lakukan perubahan pada `--app-version` sesuai versi aplikasi):
@@ -63,7 +61,7 @@ Karena itu, properti seperti nama aplikasi, vendor, icon, dan shortcut **tidak d
6361
jpackage --name "Extra Wallet" --app-version 1.0.0 --vendor Extra-Inc --type exe --input target --dest target --main-jar extrawallet-v1.0.0.jar --main-class app.Main --module-path "C:\Program Files\Java\javafx-jmods-25.0.1;C:\Program Files\Java\jdk-25.0.1\jmods" --add-modules javafx.controls,javafx.fxml --icon "src/main/resources/app-icon/favicon.ico" --win-shortcut --win-menu --win-console
6462
```
6563

66-
Ada beberapa error, gunakan ini untuk solusi yang sedang ditest:
64+
## Ada beberapa error, gunakan ini untuk solusi yang sedang ditest
6765
Pertama gunakan jlink untuk bundle semua kepertluan packaging:
6866

6967
```bash
@@ -73,21 +71,30 @@ jlink --module-path "C:\Program Files\Java\javafx-jmods-25.0.1;C:\Program Files\
7371
dengan penggunaan jpackage sebagai berikut:
7472

7573
```bash
76-
jpackage \
77-
--name ExtraWallet \
78-
--input target \
79-
--main-jar extrawallet-v1.0.0.jar \
80-
--main-class app.Main \
81-
--type exe \
82-
--runtime-image my-runtime \
83-
--java-options "--enable-native-access=javafx.graphics"
74+
jpackage
75+
--name "Extra Wallet"
76+
--app-version 1.0.0
77+
--vendor Extra-Inc
78+
--type exe
79+
--input target
80+
--dest target
81+
--main-jar extrawallet-v1.0.0.jar
82+
--main-class app.Main
83+
--runtime-image my-runtime
84+
--java-options "--enable-native-access=javafx.graphics"
85+
--icon "src/main/resources/app-icon/favicon.ico"
86+
--win-shortcut
87+
--win-menu
88+
--win-console
8489
```
8590

8691
atau berikut yang siap tempel:
8792

8893
```bash
8994
jpackage --name "Extra Wallet" --app-version 1.0.0 --vendor Extra-Inc --type exe --input target --dest target --main-jar extrawallet-v1.0.0.jar --main-class app.Main --runtime-image my-runtime --java-options "--enable-native-access=javafx.graphics" --icon "src/main/resources/app-icon/favicon.ico" --win-shortcut --win-menu --win-console
9095
```
96+
97+
> [!ALERT] Perhatikan bahwa disini aku menggunakan `--win-console`, ini akan dijelaskan dibagain bawah!
9198
9299
## Tips trick:
93100
Ketka aku melakukan konversi ke JAR dengan melakukan `mvn clean install`, klik dua kali tidak akan membuka file JAR tersebut. File JAR tersebut baru bisa dibuka ketika aku menggunakan:

export-data/akun-report.csv

Lines changed: 0 additions & 26 deletions
This file was deleted.

export-data/akun-report_20260110_120826.csv

Lines changed: 0 additions & 26 deletions
This file was deleted.
File renamed without changes.

src/main/java/app/App.java

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -35,6 +35,7 @@
3535
import service.AppPaths;
3636
import service.CurrencyApiClient;
3737

38+
import java.io.IOException;
3839
import java.nio.file.Files;
3940
import java.nio.file.Path;
4041
import java.nio.file.Paths;
@@ -54,8 +55,11 @@ protected Void call() throws Exception {
5455

5556
updateProgress(0,100);
5657

57-
Path logDir = Paths.get(System.getProperty("user.home"), ".extrawallet");
58-
Files.createDirectories(logDir);
58+
try {
59+
Files.createDirectories(AppPaths.ROOT);
60+
} catch (IOException e) {
61+
log.error("gagal membuat folder app root!", e);
62+
}
5963

6064
updateProgress(7, 100);
6165

src/main/java/service/AppPaths.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@ public final class AppPaths {
2424
DB_FILE = DATABASE_DIR.resolve("finance.db");
2525

2626
EXCHANGE_JSON = ROOT
27-
.resolve("data-exchange")
27+
.resolve("currency-exchange")
2828
.resolve("exchange_rates.json");
2929
}
3030

0 commit comments

Comments
 (0)