[Push Plugin] Not able to invoke afterNotify Method

[J-artz]

Hi James, I am implementing the push plugin, here is my flow

1. push plugin successfully loaded. NotificationPusher#Start( ) breakpoint can be hit.
2. change the code below so it will propagate to notifyRelatedUsersOfAction0#afterNotify

    default Mono<RequestHandlerResult> beforeNotify(
            @NotNull RequestHandlerResult result,
            @NotNull Long requesterId,
            @NotNull DeviceType requesterDevice) {
        return Mono.just(result);
    }

3. Able to hit the breakpoint in

return mono
                .map(offlineRecipientIds -> pluginManager.invokeExtensionPointsSequentially(
                        RequestHandlerResultHandler.class,
                        RESULT_AFTER_NOTIFY_METHOD,
                        result,

4. From debugging ,I can see it goes to PluginManager#invokeExtensionPointsSequentially and everything looks fine , the variable are correct.
   
   

5. I expect it will go to the push plugin NotificationPusher#afterNotify( ) but it not able to hit the endpoint I set.

I am using the code provided in official push plugin and my step seems correct, but I wonder why it never invoke the afterNotify( ). Any help is appreciated ~~

[J-artz]

@JamesChenX Hi , James , it is able to work after I change it to

map:
Mono<OfflineIds> -> Mono<Mono<Result>>  (nested, inner Mono never executes)
Here, map just transforms the value but doesn't "flatten" the resulting Mono. So you end up with a Mono<Mono<Result>>, and the inner Mono (containing the afterNotify call) never gets subscribed to.
flatMap:
Mono<OfflineIds> -> Mono<Result>  (flattened, inner Mono executes)
flatMap both transforms and "flattens" the resulting Mono. It subscribes to the inner Mono returned by invokeExtensionPointsSequentially, which means the afterNotify actually gets executed.

[JamesChenX]

Good catch! Could you help create a PR for the bugfix?

[J-artz]

Sure , it is just a small change. btw how do I create the PR as I dont have the permission to this repo haha.

[JamesChenX]

Thanks in advance! You can fork this repo and create a bugfix commit to your repo, and then create a PR from your forked repo. For details, https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/proposing-changes-to-your-work-with-pull-requests/creating-a-pull-request-from-a-fork.