Replace (most of) custom set library by Skylib's sets.bzl #1834
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
evertedsphere
force-pushed
the
es/skylib-set
branch
from
bf9bd9c to
2146718
Compare
|
|
1 similar comment
|
|
evertedsphere
changed the title
sets
|
|
evertedsphere
requested review from
aherrmann and
googleson78
and removed request for
googleson78
evertedsphere
force-pushed
the
es/skylib-set
branch
from
2146718 to
d45f901
Compare
googleson78
reviewed
Nov 29, 2022
googleson78
reviewed
Nov 29, 2022
googleson78
reviewed
Nov 29, 2022
googleson78
reviewed
Nov 29, 2022
googleson78
suggested changes
Nov 29, 2022
Contributor
googleson78
left a comment
googleson78
left a comment
There was a problem hiding this comment.
I've left some very minor comments that could be addressed.
evertedsphere
force-pushed
the
es/skylib-set
branch
from
d45f901 to
f70ae5f
Compare
evertedsphere
force-pushed
the
es/skylib-set
branch
from
f70ae5f to
8f670cf
Compare
evertedsphere
force-pushed
the
es/skylib-set
branch
from
8f670cf to
ecf7ccc
Compare
googleson78
approved these changes
Nov 29, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #1799.
bazelbuild/bazel-skylib#415 tracks the addition of
mutable_{union,difference}to Skylib, but Skylib's merge process isn't the fastest. For the moment, I've left our implementations in, in the interest of getting this merged quickly. I'll remove those in a future PR, which will allow us to close the issue linked above.